From owner-freebsd-ports@freebsd.org Sun Jul 19 15:19:12 2015 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 578489A541C for ; Sun, 19 Jul 2015 15:19:12 +0000 (UTC) (envelope-from michelle@sorbs.net) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 424921EB5 for ; Sun, 19 Jul 2015 15:19:12 +0000 (UTC) (envelope-from michelle@sorbs.net) Received: by mailman.ysv.freebsd.org (Postfix) id 3F1919A541B; Sun, 19 Jul 2015 15:19:12 +0000 (UTC) Delivered-To: ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3DB809A541A for ; Sun, 19 Jul 2015 15:19:12 +0000 (UTC) (envelope-from michelle@sorbs.net) Received: from hades.sorbs.net (hades.sorbs.net [67.231.146.201]) by mx1.freebsd.org (Postfix) with ESMTP id 23DD91EB3; Sun, 19 Jul 2015 15:19:11 +0000 (UTC) (envelope-from michelle@sorbs.net) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII Received: from isux.com (firewall.isux.com [213.165.190.213]) by hades.sorbs.net (Oracle Communications Messaging Server 7.0.5.29.0 64bit (built Jul 9 2013)) with ESMTPSA id <0NRQ000E3QTSB100@hades.sorbs.net>; Sun, 19 Jul 2015 08:25:06 -0700 (PDT) Message-id: <55ABBFEC.60302@sorbs.net> Date: Sun, 19 Jul 2015 17:19:08 +0200 From: Michelle Sullivan User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.24) Gecko/20100301 SeaMonkey/1.1.19 To: Dimitry Andric Cc: "ports@freebsd.org" Subject: Re: Self committing... allowed or not? References: <55AB91ED.3080908@sorbs.net> <9917125A-6342-4F62-B374-E4F456EDC015@FreeBSD.org> In-reply-to: <9917125A-6342-4F62-B374-E4F456EDC015@FreeBSD.org> X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jul 2015 15:19:12 -0000 Dimitry Andric wrote: > On 19 Jul 2015, at 14:02, Michelle Sullivan wrote: > >> please correct me if I'm wrong but isn't self committing (those with the >> commit bit committing their own patches without QA/review/adding >> patchfiles to the PR) against the rules?... or is it just a free-for-all >> now? >> > > If they are the maintainer, it is OK by definition. Otherwise, approval > from either the maintainer or portmgr@ is needed. > > However, a number of people are on vacation, and they have notified > other developers that is OK to fix their ports while they are away. > Within reason, of course. :-) > > In any case, which specific ports are you worried about? > > -Dimitry > > Here's the case and the three referenced commits: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199265 And I know the top-level dependency will now break other things because of a minor detail that the committer did not take into account... That said I don't know if any other dependencies on it exist (so therefore it might not break anything else - however I am fairly sure it wasn't checked by the committer because of the speed and absoluteness of the change) because I don't need it/use it myself... but that is not the point. I was 'just lucky' to come across this change process as I was not looking for anything, just happened to be in the right place at the right time to see it, and considering the hoops use plebs (those without the commit bit) have to jump through I thought it was rather ironic that 3 separate ports were changed, no testing was recorded in the PR as we the plebs are required to do, no patches uploaded as we the plebs have to do and no review as we the plebs have to have... -- Michelle Sullivan http://www.mhix.org/