From nobody Fri Oct 10 17:16:41 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cjthB0gThz6Bcy9; Fri, 10 Oct 2025 17:16:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cjth96h0Nz3gwc; Fri, 10 Oct 2025 17:16:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760116601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OuNV6rZZz7dSnbRvJLLAvoBUh1LY5gL4zWOcdJRkZHc=; b=kNtLdA3OGSHduSna38zK4OWyinnJ+GaiYL7eR7ofXR9RA5tOLjryQYncxzjlG/Fo5FX2B8 SQO2Hgl82v7YWkdwZh0Q9HeYQZxlQ6onnqed1/vNgLP0nbS17d4Kfn0oZfWgJ7klphKXgF Mtq8NclwTHXXcXf6yomuTvpsPRUpTWYrN7X3FX+5vR4hcOIkAIXoaW45FrPV2fnonr0BSy ZLMuj1TaAuzpxUTicUtm+E0xWLwi7u5kUooDB40q1CqVMEbbaQQtv2xw6A3u06VYYSezOX AUYjWo/fH8UwO5RVakQeb6VTtWeQ/t02LDLlcDwpD/mCu1Y6qPjl2HmQbCR5IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760116601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OuNV6rZZz7dSnbRvJLLAvoBUh1LY5gL4zWOcdJRkZHc=; b=gPfjUG7Wm+RK1A2Cd52pilKiSa2SBs7ayX5QDVfbIwP/t7TNK4NzKsSqk1+xHSMz82KUmq jCEOPJGlgHNwisS2ssiip8tV7XBYkC6Qk4dWZ+csaeEwN+gP41mWvryq2KvKJ1Md/C1Zs7 zXS+Ygv5Rnb9+b3Dv/lLHDJOeHUkVzQYhv1C5QaEV9UPfK7sV/T9PGEDJgK3W4YR4ITAEb hdRKtnzOjaW6ydom4TIsjUPaAGw4ZVPkq8lmB0aJ0gnL+Hubg2zDkOGp7lXYpLeoyocDEa 3ijhaYny5OBzFY24R9TezxNghev9Ox6llITMrbzfYT3qCNa9J+/LN3IxbLapJg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760116601; a=rsa-sha256; cv=none; b=DwjQe0QNXPO34sMy/UIKbwf0iiQBSzBHD1eNLOHYbT/ofIAY8Qp4CriMwn8gGQnh93URPV ITOifN55xi4sCVaBTVn12BOm775C6qZz1LSORER0+zJNGfsk0W+DqpOsjb5WCuUSdua5NQ poMXWQp9KHCfG5BFE3Wm7vIVd7eBui1gfyYNq9lfbVVx0DUV2EcZVJqbYw5oiJW3WnGBEV xstQfK2XB3nohwmV7Prm5tD6IFLGwpe3gT8+tNQzF7emlfGKLMZKZ0RIhQCiu3uwCGLaOc lv08sIez027FyxCKvBkeCPY3CwkYX/czEFEJZNy9dYYuTNmb8dN0KHjJWpBdNA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cjth965jVz1BWM; Fri, 10 Oct 2025 17:16:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59AHGfYG009889; Fri, 10 Oct 2025 17:16:41 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59AHGftx009886; Fri, 10 Oct 2025 17:16:41 GMT (envelope-from git) Date: Fri, 10 Oct 2025 17:16:41 GMT Message-Id: <202510101716.59AHGftx009886@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 4b7c2a0193dd - stable/14 - nfsuserd: Fix OOB access on membership of too many groups, take 2 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 4b7c2a0193dd92b72628bc1c614d779cf77eef5d Auto-Submitted: auto-generated The branch stable/14 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=4b7c2a0193dd92b72628bc1c614d779cf77eef5d commit 4b7c2a0193dd92b72628bc1c614d779cf77eef5d Author: Olivier Certner AuthorDate: 2025-10-09 17:03:11 +0000 Commit: Olivier Certner CommitDate: 2025-10-10 17:16:03 +0000 nfsuserd: Fix OOB access on membership of too many groups, take 2 Forgot to reset 'ngroup' after one of the calls to getgrouplist() in the previous commit with same title (referenced also below). MFC after: 1 hour Fixes: e6c623c86ab4 ("Add support for the "-manage-gids" option to the nfsuserd daemon.") Fixes: bb339adfb2a2 ("nfsuserd: Fix OOB access on membership of too many groups") Sponsored by: The FreeBSD Foundation (cherry picked from commit 75eb6846269bb9bec1eaf4f0ad93d7525715b550) --- usr.sbin/nfsuserd/nfsuserd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/usr.sbin/nfsuserd/nfsuserd.c b/usr.sbin/nfsuserd/nfsuserd.c index 9df50e27efd1..e5fd6fb18c81 100644 --- a/usr.sbin/nfsuserd/nfsuserd.c +++ b/usr.sbin/nfsuserd/nfsuserd.c @@ -630,6 +630,7 @@ nfsuserdsrv(struct svc_req *rqstp, SVCXPRT *transp) syslog(LOG_ERR, "Group list of user '%s' too big", pwd->pw_name); + ngroup = NGROUPS; } nid.nid_ngroup = ngroup; nid.nid_grps = grps;