From owner-svn-src-all@freebsd.org Fri Nov 3 22:45:19 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 82BCDE5D200 for ; Fri, 3 Nov 2017 22:45:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 44CB976D84 for ; Fri, 3 Nov 2017 22:45:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22f.google.com with SMTP id d66so9493764ioe.5 for ; Fri, 03 Nov 2017 15:45:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=5td0B1W8HAU7cJJpiMATrgfmnK7EI17leec5q7mjaOY=; b=PyU/rfo0xkAKRCe5a2Mq4bzOR0iVM/zzN2w1cpST+Bwo/6lHL9IbI6anezO4bd+BCV SW8MBiVHHpkzcYOeZfpN/D4Yl9n5acntnl+pbcAMDQMP7Q7gzXTAfJQ/aBxTJt/CH9/m Pt2Pj/h72bDlf0Uh5jiBxGG+OKESwG5rBRyn7i+Uns3DwWUFP7rFQPzv70n2rHZsAl4X 9aHR0cHhsDgpbYYTqXdrksbrxPzFmvDwp2r8dfLacaGv0BFROTNK5r/U4WOSU0nYyWfF u77pvjtlqEna9sf4aetHJkPPHMbfhLV4kjXLuJixXla8qjUJqUuaNiYxP6Bbe5c5fVB6 ypdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=5td0B1W8HAU7cJJpiMATrgfmnK7EI17leec5q7mjaOY=; b=ELHwF/45Eqrkk6MR19nhPmSeEDz5ibtcM0Fbvydw5DvW44BSCLR2xxfQpbR1M09Z3a 0bW9UDKWLQTjMHEbpTyff9tcRPm8ucr5HsGkxVMu6C6vCUWrcQlkmZBYN9AvzJ0CFa7W aia//fmU5rYO5+WGUb3eJqzUhFMzhAlAicbU4kD+UxdKyq1ayyvysJS7CPhNrCspak6j mBo49MdPmO/mqe6gm8ZNZzrZAzRKFXu1vGaezX34a70AlU78IlPB4BoLvrRTGCN3iR3i D1f2DR5C0c02qpcXrd7cZhxEeL9XYBrtZwAWejPlnpMw9a9gCed6hdNOqf6hYuYJTniw lZ+A== X-Gm-Message-State: AJaThX7t1eY9bjceboqpGmq2PVxYMINRX5xOcGsUo5vfVq4aKH4YEaWu y0URE60W8m0ng4wFGypIjQEe9rtdOyq5xj9PWaB+Rw== X-Google-Smtp-Source: ABhQp+TxwIMaSdRKBjpjxZ6UJfhZ7b7sVWkYR2de4YUPU4xqcB/yP/Fy1EV/dOSnqyWq0bIVm10HW0cnb212PbdRD0M= X-Received: by 10.107.48.76 with SMTP id w73mr11249773iow.301.1509749118571; Fri, 03 Nov 2017 15:45:18 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.57.22 with HTTP; Fri, 3 Nov 2017 15:45:17 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:4daf:1291:4f1b:d2ea] In-Reply-To: <72ee6c6d-0d9a-ebe9-8e15-c278fc91ded2@FreeBSD.org> References: <201710300312.v9U3CcCT021416@repo.freebsd.org> <8d9e9f50-035c-403c-3bc5-6788b7a94dea@FreeBSD.org> <72ee6c6d-0d9a-ebe9-8e15-c278fc91ded2@FreeBSD.org> From: Warner Losh Date: Fri, 3 Nov 2017 16:45:17 -0600 X-Google-Sender-Auth: k8k7ID0t20WgwFv6it-k0zuZqRo Message-ID: Subject: Re: svn commit: r325116 - head To: Bryan Drewery Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 22:45:19 -0000 On Fri, Nov 3, 2017 at 4:40 PM, Bryan Drewery wrote: > On 11/3/2017 3:32 PM, Warner Losh wrote: > > > > > > On Fri, Nov 3, 2017 at 4:28 PM, Bryan Drewery > > wrote: > > > > On 10/29/2017 8:12 PM, Warner Losh wrote: > > > Author: imp > > > Date: Mon Oct 30 03:12:38 2017 > > > New Revision: 325116 > > > URL: https://svnweb.freebsd.org/changeset/base/325116 > > > > > > > > Log: > > > Return proper status from buildenv. > > > > > > make buildenv BUILDENV_SHELL= more useful. Remove > '|| > > > true' from the command line so that errors are properly > > > returned. There appears to be no reason for it, and it dates > back to > > > the original commit by ru@. > > > > > > Sponsored by: Netflix > > > > Now simply running 'make buildenv' and 'exit' throws a make error. > > > > Perhaps we need a BUILDENV_CMDS that does what you want and we > otherwise > > leave the ${BUILDENV_SHELL} || true handling. > > > > > > Are you sure? > > > > 4:29pm zooty:[242]> make buildenv > > Entering world for amd64:amd64 > > $ exit > > 4:29pm zooty:[243]> > > > > Perhaps you can give me an example that causes that? This was the very > > first thing I checked before committing the fix... > > > > Only happens with zsh. > > > [root@c1100-1][pts/8][zsh/2][Fri 11/03/2017 15:40:10 PDT][0?2&] > (git-svn)-[master]- > > ~/git/freebsd # BUILDENV_SHELL=csh make buildenv > > Entering world for amd64:amd64 > > root@c1100-1:~/git/freebsd # exit > > exit > > ~/git/freebsd # BUILDENV_SHELL=/usr/local/bin/zsh make buildenv > > Entering world for amd64:amd64 > > For ZSH you must run: export CPUTYPE= > > (buildenv) [root@c1100-1][pts/8][zsh/3][Fri 11/03/2017 15:40:23 > PDT][1?0&] (git-svn)-[master]- > > ~/git/freebsd # exit > > *** Error code 1 > > > > Stop. > > make[1]: stopped in /root/git/freebsd > > *** Error code 1 > > > > Stop. > > make: stopped in /root/git/freebsd > Shouldn't this be fixed in upstream zsh rather than yet another ZSH wart in the buildsystem that literally has another ZSH wart in the same line? Warner