From owner-freebsd-bugs Sun Jan 23 23:10: 5 2000 Delivered-To: freebsd-bugs@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id 7B1E714E5B for ; Sun, 23 Jan 2000 23:10:03 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id XAA11221; Sun, 23 Jan 2000 23:10:03 -0800 (PST) (envelope-from gnats@FreeBSD.org) Date: Sun, 23 Jan 2000 23:10:03 -0800 (PST) Message-Id: <200001240710.XAA11221@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Bruce Evans Subject: Re: bin/16320: fstat -f confuses some partitions Reply-To: Bruce Evans Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR bin/16320; it has been noted by GNATS. From: Bruce Evans To: krentel@dreamscape.com Cc: freebsd-gnats-submit@FreeBSD.ORG Subject: Re: bin/16320: fstat -f confuses some partitions Date: Mon, 24 Jan 2000 18:02:50 +1100 (EST) On Sun, 23 Jan 2000 krentel@dreamscape.com wrote: > >Fix: > I suggest the following patch. It removes the 0xffff mask from fsid, > so fstat correctly distinguishes between da0s1f and da0s2f. Instead, > it puts the mask on the printf statement, so fstat -n continues to > display da0s2f as device 4,5 instead of 4,0x00030005. > > Or, maybe da0s2f really should print as 4,0x00030005, I don't know. > I've never been that clear on Freebsd's use of the high-order bits > in the minor number. fstat should print the full number, but this will mess up the formatting. It uses %2d formatting, so it already messes up minor numbers larger than 99. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message