From owner-freebsd-hackers@FreeBSD.ORG  Sat Jan 24 00:30:08 2015
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id A0B8FDE2;
 Sat, 24 Jan 2015 00:30:08 +0000 (UTC)
Received: from mail-lb0-x231.google.com (mail-lb0-x231.google.com
 [IPv6:2a00:1450:4010:c04::231])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 2580EB0B;
 Sat, 24 Jan 2015 00:30:08 +0000 (UTC)
Received: by mail-lb0-f177.google.com with SMTP id p9so321149lbv.8;
 Fri, 23 Jan 2015 16:30:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=DTGdE8Hs8h1ePXhoTk/nsiqsQ6dRjvHCE++AbMnKwks=;
 b=YfRYVb8Gq2LhU73b8aozgPn+MwnCNJVcFIJ9GkvSGE5VBB3H7VABeeHDGuYiOA1uV1
 Q2VSEDNrEV3CUBt2BQ1CHQkLO2hi9Yn8XKK7DgbHZwTY8tVmliNNDS75rxadk0t8TYoD
 +ye7IYwd6/x552zzhDBgaBgpEV3hnOofKWWPED0+VCC234YAMcxci6wlGQ06V9ViNzML
 DxWFfUs0OxESg4JXmwynDJ5e9qgsNBce1aEs2vc01E/8lMh05gP+Hjyo/c5la/3yHXyw
 NwkDcv38d/1TboO24++Q1AlxSWcDd8MKuiIZGRh28piB1EMnoEbP3vUScAaeaGUOslCo
 QRJg==
MIME-Version: 1.0
X-Received: by 10.112.160.33 with SMTP id xh1mr10235767lbb.60.1422059406126;
 Fri, 23 Jan 2015 16:30:06 -0800 (PST)
Received: by 10.114.78.131 with HTTP; Fri, 23 Jan 2015 16:30:06 -0800 (PST)
In-Reply-To: <CAPyFy2AUdAWM+M0kgyH-NN64eVLRGnYA9qNFkca4c80LQW8Skg@mail.gmail.com>
References: <CAFMmRNxz252HMWWBmRf=Z69zh2_w9cD5e1AZGeizyagKezm2Hw@mail.gmail.com>
 <20150120083212.GC42409@kib.kiev.ua>
 <CAFMmRNz6Dof+95zyekUFEbmcqeFSqXr96Y7BUZpqJ9z0XoWVOA@mail.gmail.com>
 <20150122083514.GU42409@kib.kiev.ua>
 <CAFMmRNziuN_jWyeNjdcB8yzM6uVM8_BO_h0U1Gphn+13E-7JcA@mail.gmail.com>
 <20150123083654.GB42409@kib.kiev.ua>
 <CAPyFy2AUdAWM+M0kgyH-NN64eVLRGnYA9qNFkca4c80LQW8Skg@mail.gmail.com>
Date: Fri, 23 Jan 2015 19:30:06 -0500
Message-ID: <CAFMmRNyVRPKW6fXNFksx+-+hHV_S8kLQ5yWKUy8Sz47=7URd9Q@mail.gmail.com>
Subject: Re: Sleeping thread held mutex in vm_pageout_oom()
From: Ryan Stone <rysto32@gmail.com>
To: Ed Maste <emaste@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: Konstantin Belousov <kostikbel@gmail.com>,
 "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org>
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Jan 2015 00:30:08 -0000

On Fri, Jan 23, 2015 at 10:24 AM, Ed Maste <emaste@freebsd.org> wrote:
> It does say that the braces "may be" left out though, and I much
> prefer the guideline as you state it.

That works for me.

The WITNESS_WARN() survived a buildworld, so I'll commit that once kib
gets the vm_pageout_oom() fix in