Date: Thu, 30 Mar 2017 07:48:09 +0200 From: Matthew Rezny <rezny@freebsd.org> To: Johannes M Dieterich <jmd@freebsd.org> Cc: Jan Beich <jbeich@freebsd.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, owner-ports-committers@freebsd.org Subject: Re: svn commit: r437215 - in head/graphics: gbm libEGL libGL libglapi Message-ID: <64898025.Nr8dtLiZcF@workstation.reztek> In-Reply-To: <6a245317c900f4cf092bcdf70c1798ee@freebsd.org> References: <201703291657.v2TGvrpM076369@repo.freebsd.org> <8tnn-5tcs-wny@FreeBSD.org> <6a245317c900f4cf092bcdf70c1798ee@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 29 March 2017 23:48:17 Johannes M Dieterich wrote:
> On 2017-03-29 23:36, Jan Beich wrote:
> > Matthew Rezny <rezny@freebsd.org> writes:
> >> On Wednesday 29 March 2017 19:51:55 Jan Beich wrote:
> >>> Matthew Rezny <rezny@FreeBSD.org> writes:
> >>> > - @${REINPLACE_CMD} -e 's|x86_64|amd64|' \
> >>> > + @${REINPLACE_CMD} -e 's|x86_64|amd64|' -e 's|\\S\*//|[:space:]*
//|'
> >>> > \
> >>>
> >>> [:space:] is invalid character class thus treated as a list of
> >>> characters.
> >>> \S corresponds to [^[:space:]], while \s to [[:space:]].
> >>>
> >>> $ man pcrepattern | col -b | fgrep -m1 \\S
> >>>
> >>> \S any character that is not a white space character
> >>>
> >>> This may break build given -march, etc. are no longer stripped.
> >>
> >> I wish that information had been presented when I said "I guess it
> >> should have
> >> been [:space:] instead of [:graph:] in the replacement." after you
> >> stated
> >> [:graph:] was plain incorrect, although it is what had been previously
> >> suggested to me and did seem to be working.
> >
> > I didn't focus on pointing out every mistake with the existing hack
> > because it was soon going away. Now that devel/libclc depends on llvm40
> > the original motivation to hold out on 17.* (bug 217016) before 2017Q2
> > has been weakened.
>
> Also, there is a review for 17.0.2 up by me:
> https://reviews.freebsd.org/D9469 which changes the default LLVM version
> to 4.0 as newer AMD GPUs need that and uses libudev-devd now. Comments
> welcome!
>
I had not noticed that your review was updated recently as it sat idle for
quite a while after the update to 13.0.x landed in ports. I'm curious about
the comment regarding a need for libudev. As far as I know, Mesa dropped the
dependence on udev in v13 and relies upon libdrm for all the direct hardware
interaction. Initially, I had some hope to use libudev-devd as a single
translation layer, but after reading through the libdrm code it became obvious
that would not be the case as the conditional udev code in libdrm is withing
Linux-specific code paths so no help to us. Thus, I implemented support for our
platform directly in libdrm in order to drop dependence on libdevq, which was
needed for no other purpose. Could you explain why Mesa 17 would need libudev-
devd for AMDGPU?
> Please note that after today's commits the patch will not apply cleanly
> anymore, I'll update.
>
Before you rush to update, let's make sure we are on the same page. I plan to
take this opportunity to restructure the Mesa ports as I mentioned in PR217016
so that we can provide correctly working options for Wayland and also DRI3 if
we cannot solve the issues with fallback to DRI2. Do you have any insight as
to why that fallback might not work on some systems, or may work for GLX but
fail for EGL? I only see an issue with EGL here and haven't yet dug into it.
> >> To be sure there is no misunderstanding now, would you consider this
> >> correct?
> >> @${REINPLACE_CMD} -e 's|x86_64|amd64|' -e 's|\\S\*//|[^[:space:]]*
> >> //|' \
> >
> > Not quite, adding extra space after [] is unnecessary.
> >
> > -e 's|\\S\*|[^[:space:]]*|' \
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?64898025.Nr8dtLiZcF>