From owner-freebsd-rc@freebsd.org Tue Oct 3 22:13:37 2017 Return-Path: Delivered-To: freebsd-rc@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5F424E26230 for ; Tue, 3 Oct 2017 22:13:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DF536648F for ; Tue, 3 Oct 2017 22:13:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v93MDb0V070112 for ; Tue, 3 Oct 2017 22:13:37 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-rc@FreeBSD.org Subject: [Bug 216115] service -e showing sendmail enabled when it is not Date: Tue, 03 Oct 2017 22:13:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 11.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jilles@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-rc@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Oct 2017 22:13:37 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D216115 Jilles Tjoelker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jilles@FreeBSD.org --- Comment #9 from Jilles Tjoelker --- The proposed patch basically executes status when executing any subcommand,= and then adds status and poll to the available subcommands when the daemon is running. This seems wrong. Although the if [ -n "$_pidcmd" ]; then part is definitely redundant, I thi= nk this condition should just be removed instead of changed. The idea is that _pidcmd is defined and status and poll are available iff a command or proce= ss name is defined (which may be done in various ways). What happens with /etc/rc.d/sendmail is that service(8)'s naive greps catch= the lines name=3D"sendmail_msp_queue" rcvar=3D"sendmail_msp_queue_enable" in addition to the intended lines name=3D"sendmail" rcvar=3D"sendmail_enable" and the msp_queue ones override the intended lines because they are last. Indenting the two msp_queue lines in /etc/rc.d/sendmail fixes the problem b= ut it is a rather ugly and obscure solution. --=20 You are receiving this mail because: You are the assignee for the bug.=