From owner-svn-ports-head@freebsd.org Fri Nov 6 07:22:43 2020 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A90852E4F57; Fri, 6 Nov 2020 07:22:43 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CSBg74Xq2z4krn; Fri, 6 Nov 2020 07:22:43 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from marvin.madpilot.net (host-87-20-130-1.retail.telecomitalia.it [87.20.130.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 0E1CF29504; Fri, 6 Nov 2020 07:22:42 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Subject: Re: svn commit: r554143 - head/devel/git To: Renato Botelho , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <202011051704.0A5H4Jf8010250@repo.freebsd.org> From: Guido Falsi Message-ID: Date: Fri, 6 Nov 2020 08:22:40 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <202011051704.0A5H4Jf8010250@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2020 07:22:43 -0000 On 05/11/20 18:04, Renato Botelho wrote: > Author: garga > Date: Thu Nov 5 17:04:19 2020 > New Revision: 554143 > URL: https://svnweb.freebsd.org/changeset/ports/554143 > > Log: > devel/git: Update to 2.29.2 and small tweaks > > - Update to 2.29.2 [1] > - Simplify logic to define COMMENT for each flavor > - Inspired in www/py-autobahn, save OPTIONS on a different file for each flavor > > PR: 250472 [1] > Submitted by: Yasuhiro KIMURA [1] > Sponsored by: Rubicon Communications, LLC (Netgate) > > Modified: > head/devel/git/Makefile > head/devel/git/distinfo > head/devel/git/pkg-plist > > Modified: head/devel/git/Makefile > ============================================================================== > --- head/devel/git/Makefile Thu Nov 5 16:51:30 2020 (r554142) > +++ head/devel/git/Makefile Thu Nov 5 17:04:19 2020 (r554143) > @@ -2,7 +2,7 @@ > # $FreeBSD$ [...] > @@ -76,6 +73,8 @@ OPTIONS_EXCLUDE= GUI SVN GITWEB CONTRIB P4 CVS PERL > .endif > > OPTIONS_SUB= yes > + > +OPTIONS_FILE= ${PORT_DBDIR}/${OPTIONS_NAME}/${FLAVOR}-options I'm not sure why, but this is not working as expected IMHO. I noticed that, when using "poudriere options" and building with "poudriere bulk" the options file is ignored. poudsriere option continuously brings up the git dialog4ports screen and asks options proposing the defaults. The option file is correctly written but never read. poudriere bulk ignores it and builds with default options. Also on the local machine running make config repeatedly in the port directory does the same: the dialog4ports sscreen comes up with default options each time and the options file is written but never read. Am I missing something? is something special required for this to actually work? -- Guido Falsi