Date: Fri, 7 Jul 2017 11:04:46 -0700 From: Richard Gallamore <ultima@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r445123 - in head/net-mgmt/ccnet-client: . files Message-ID: <a3c47650-7737-f6b9-db44-02daf65a4efd@FreeBSD.org> In-Reply-To: <20170707120151.GA57983@FreeBSD.org> References: <201707060221.v662LNM1037673@repo.freebsd.org> <20170707120151.GA57983@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --M6G4G9JE90v3IOLUDie8Dios7fwETsqxm Content-Type: multipart/mixed; boundary="lFIdgnDoKx4hVP4CtbosQiKpid8sro7sv"; protected-headers="v1" From: Richard Gallamore <ultima@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <a3c47650-7737-f6b9-db44-02daf65a4efd@FreeBSD.org> Subject: Re: svn commit: r445123 - in head/net-mgmt/ccnet-client: . files References: <201707060221.v662LNM1037673@repo.freebsd.org> <20170707120151.GA57983@FreeBSD.org> In-Reply-To: <20170707120151.GA57983@FreeBSD.org> --lFIdgnDoKx4hVP4CtbosQiKpid8sro7sv Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US My apologies, will add a more details of changes in the commit log in the future. The reasoning for the change=20 is in the porters handbook, 13.1.7. USES and USE_x. This section suggests that USES should start the section block then USE_x should follow. Agreed about USE_GITHUB being more distfile related and probably should be considered to be moved to that section block. A little off topic, in the beginning of the same chapter, the example Makefile has items out of order and I keep wondering to myself if this is on purpose. Anyways will be more detailed in commit log, thanks for the feedback! Richard Gallamore On 07/07/2017 05:01, Alexey Dokuchaev wrote: > On Thu, Jul 06, 2017 at 02:21:23AM +0000, Richard Gallamore wrote: >> New Revision: 445123 >> URL: https://svnweb.freebsd.org/changeset/ports/445123 >> >> Log: >> * Add patch to fix build for libressl >> * Removed --enable-ldap, not a valid configure arg >> =20 >> [...] >> @@ -21,19 +22,17 @@ LIB_DEPENDS=3D libsearpc.so:devel/libsearpc \ >> =20 >> CONFLICTS=3D ccnet-server-[0-9]* >> =20 >> -USE_GITHUB=3D yes >> -GH_ACCOUNT=3D haiwen >> -GH_PROJECT=3D ccnet >> - >> USES=3D autoreconf gettext libtool localbase pathfix pkgconfig \ >> python:-2.7 ssl >> USE_GNOME=3D glib20 >> USE_LDCONFIG=3D yes >> USE_OPENLDAP=3D yes >> +USE_GITHUB=3D yes >> +GH_ACCOUNT=3D haiwen >> +GH_PROJECT=3D ccnet > Please try to avoid these gratuitous changes. GitHub-related knobs are= > often grouped together and put closer to the top because they are more > related to obtaining the distfile (think MASTER_SITES) rather than the > configuring/building/etc. steps of software itself. > > In any case, this move should've been reflected in the commit log with > proper explanation. > > ./danfe --lFIdgnDoKx4hVP4CtbosQiKpid8sro7sv-- --M6G4G9JE90v3IOLUDie8Dios7fwETsqxm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEEy0bsZFuhj198rL2mO+r3F2iiCM8FAllfzUJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldENC NDZFQzY0NUJBMThGNUY3Q0FDQkRBNjNCRUFGNzE3NjhBMjA4Q0YACgkQO+r3F2ii CM/ZCwf/URB27lLB2/T+HlEyH89Ugr2tK9w+W1jYC9pJg6N3KNnvxkLpq2s/LxlH BbH21biBdIObmj5ciAYmATfGh1WQtG13AS6l/VdeDnozPlDbYgYv01XWHf/36m2K 3wp/+NqQNpMMJyYhMm9CBRB3qtPSinYzd3nXxEl9ymzPEpQojQ8vymtifK6bcKc4 6mPoPlZpDW0Ri9alNx3Xa0luFrOF1HNYKNXnkug37NpgImTFdoj97YlPpyKYj9Nn EEvst5DMAhngffHeixk7Cw7l8UvAtjSOkSrfyVHPH8WavEwvNkA5lyWkJO99ZKbU QfF9eB68sStdo8vyU2wUDSgs3poYkw== =RkvB -----END PGP SIGNATURE----- --M6G4G9JE90v3IOLUDie8Dios7fwETsqxm--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a3c47650-7737-f6b9-db44-02daf65a4efd>