From owner-svn-ports-all@freebsd.org Fri Jul 7 18:04:59 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3D171DA8A8A; Fri, 7 Jul 2017 18:04:59 +0000 (UTC) (envelope-from ultima1252@gmail.com) Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 119F8843F1; Fri, 7 Jul 2017 18:04:58 +0000 (UTC) (envelope-from ultima1252@gmail.com) Received: by mail-pf0-f195.google.com with SMTP id e199so5494831pfh.0; Fri, 07 Jul 2017 11:04:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=Zkzneuq/yjjUJbVVrNxvahtnsAPcZqNcvLXxP3bBB50=; b=rfNwhj5rHNA83gQiPAyuL2cCsmXYjOKL3dQ0NVl94Di6dFR7QLeTtSjEyuiySWtlU/ /NRqzbcDQ0wZpA0zZUJu+8HP9g5Ny8cTO06S7rLa0aSfl+TyEFI9lEEvi2QJvA0Qejqr 8/ytuXg78ZWHsyidqo3zfLFO5gnQUBXK9zZjhToRDUqBggW/O8B+hFcN1MPkofZCCBTl xop1j8P7e+rDVINGI3lEwSLX40NfelZ3+gLrxZ64o9uQ6Hb4H2emE7/zzooTRmBQLnq5 pQgr9Q8POdckc8ecXz6GuIicu5ZDMlBTMO7f15QD72L0IgvlK9HRths5BUzSl0lnsbc1 wQlg== X-Gm-Message-State: AIVw110QE8xoekFzijClLMk4px96LLS6qLLRjVLBk+T6XGdZmK3Fm9mN kKNE9y13CmHCaj8Y9vk= X-Received: by 10.101.88.197 with SMTP id e5mr2683366pgu.144.1499450692182; Fri, 07 Jul 2017 11:04:52 -0700 (PDT) Received: from ?IPv6:2601:646:c402:f051:a236:9fff:fe30:1726? ([2601:646:c402:f051:a236:9fff:fe30:1726]) by smtp.gmail.com with ESMTPSA id y2sm6103041pgy.60.2017.07.07.11.04.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Jul 2017 11:04:51 -0700 (PDT) Subject: Re: svn commit: r445123 - in head/net-mgmt/ccnet-client: . files To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201707060221.v662LNM1037673@repo.freebsd.org> <20170707120151.GA57983@FreeBSD.org> From: Richard Gallamore Message-ID: Date: Fri, 7 Jul 2017 11:04:46 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170707120151.GA57983@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="M6G4G9JE90v3IOLUDie8Dios7fwETsqxm" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jul 2017 18:04:59 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --M6G4G9JE90v3IOLUDie8Dios7fwETsqxm Content-Type: multipart/mixed; boundary="lFIdgnDoKx4hVP4CtbosQiKpid8sro7sv"; protected-headers="v1" From: Richard Gallamore To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: Subject: Re: svn commit: r445123 - in head/net-mgmt/ccnet-client: . files References: <201707060221.v662LNM1037673@repo.freebsd.org> <20170707120151.GA57983@FreeBSD.org> In-Reply-To: <20170707120151.GA57983@FreeBSD.org> --lFIdgnDoKx4hVP4CtbosQiKpid8sro7sv Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US My apologies, will add a more details of changes in the commit log in the future. The reasoning for the change=20 is in the porters handbook, 13.1.7. USES and USE_x. This section suggests that USES should start the section block then USE_x should follow. Agreed about USE_GITHUB being more distfile related and probably should be considered to be moved to that section block. A little off topic, in the beginning of the same chapter, the example Makefile has items out of order and I keep wondering to myself if this is on purpose. Anyways will be more detailed in commit log, thanks for the feedback! Richard Gallamore On 07/07/2017 05:01, Alexey Dokuchaev wrote: > On Thu, Jul 06, 2017 at 02:21:23AM +0000, Richard Gallamore wrote: >> New Revision: 445123 >> URL: https://svnweb.freebsd.org/changeset/ports/445123 >> >> Log: >> * Add patch to fix build for libressl >> * Removed --enable-ldap, not a valid configure arg >> =20 >> [...] >> @@ -21,19 +22,17 @@ LIB_DEPENDS=3D libsearpc.so:devel/libsearpc \ >> =20 >> CONFLICTS=3D ccnet-server-[0-9]* >> =20 >> -USE_GITHUB=3D yes >> -GH_ACCOUNT=3D haiwen >> -GH_PROJECT=3D ccnet >> - >> USES=3D autoreconf gettext libtool localbase pathfix pkgconfig \ >> python:-2.7 ssl >> USE_GNOME=3D glib20 >> USE_LDCONFIG=3D yes >> USE_OPENLDAP=3D yes >> +USE_GITHUB=3D yes >> +GH_ACCOUNT=3D haiwen >> +GH_PROJECT=3D ccnet > Please try to avoid these gratuitous changes. GitHub-related knobs are= > often grouped together and put closer to the top because they are more > related to obtaining the distfile (think MASTER_SITES) rather than the > configuring/building/etc. steps of software itself. > > In any case, this move should've been reflected in the commit log with > proper explanation. > > ./danfe --lFIdgnDoKx4hVP4CtbosQiKpid8sro7sv-- --M6G4G9JE90v3IOLUDie8Dios7fwETsqxm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEEy0bsZFuhj198rL2mO+r3F2iiCM8FAllfzUJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldENC NDZFQzY0NUJBMThGNUY3Q0FDQkRBNjNCRUFGNzE3NjhBMjA4Q0YACgkQO+r3F2ii CM/ZCwf/URB27lLB2/T+HlEyH89Ugr2tK9w+W1jYC9pJg6N3KNnvxkLpq2s/LxlH BbH21biBdIObmj5ciAYmATfGh1WQtG13AS6l/VdeDnozPlDbYgYv01XWHf/36m2K 3wp/+NqQNpMMJyYhMm9CBRB3qtPSinYzd3nXxEl9ymzPEpQojQ8vymtifK6bcKc4 6mPoPlZpDW0Ri9alNx3Xa0luFrOF1HNYKNXnkug37NpgImTFdoj97YlPpyKYj9Nn EEvst5DMAhngffHeixk7Cw7l8UvAtjSOkSrfyVHPH8WavEwvNkA5lyWkJO99ZKbU QfF9eB68sStdo8vyU2wUDSgs3poYkw== =RkvB -----END PGP SIGNATURE----- --M6G4G9JE90v3IOLUDie8Dios7fwETsqxm--