From nobody Sun Feb 2 16:37:55 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YmFfq55J4z5mPDN; Sun, 02 Feb 2025 16:37:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YmFfq3dy8z3cSC; Sun, 02 Feb 2025 16:37:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738514275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tgIpZqF+QpPgJ2aB38RxdAjqqGr2dF3cLGQzwxn/dbQ=; b=EGRRxIBHYnmE0BV/rN3dhYjBtV/9BM6hZOHNETkL3O8kzKu/MNAWWKDKsMA9tMBFVXLg88 8TNeDuScloyb48Wu5WdQeggxbaMV7aI+qH4KXpOKmbVoFtGym6w9P/+exa0QU1TNM90anE 1o1bbSuBGyS9onfnKP0F7SDbEKf01xof+09hEkDAtv1eG/Ie1TGeyBiPV9jUAKNSSjGGCl 3DbPygZAf35uHYhNu70QF0w7Wbbq7pIdhN4MHQfOr9kkbAtP4oSjMmTcwpZ0WnvciwRYHv fdOOneKzIJi9oRtebdEkTqS3AUvcjpvYb+Sc1Yi9EsJGXx/qxOXs+Y6StlMTAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738514275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tgIpZqF+QpPgJ2aB38RxdAjqqGr2dF3cLGQzwxn/dbQ=; b=uUBe5OpVll+TGTK84VbRGza+5oUXlvQ56B6TYytzjzlx+qE/Pi4RNsnnxBtcCEkKC7RALl dWpQTVNANe+9+pNH6Ga6jnRjtwnVPQieVs4kbO68rsXaIX7jg13Kd/pXj7ikzmqtxlNXmL 6abFrG5flJt4+WAXxzFs/knT4LNhBHWoQFplgyC17pP22PXokz7mB0T/ZdYgog0qaB8OMj IRpWbxgCTtl/0WXQlpwf7mg6jdy1DUyP+nXvKM57cfL6vroVpUfsWjKGA7k6Z/undo1Njx 7MCqs1XxFszyDW24vQHkG1ZIrTQjg7rP2Jx4qA/fAYGYq0MfrYkvy/e+4P5c/g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738514275; a=rsa-sha256; cv=none; b=MQOLNCNBfTGd6miaIAkS+LrCwYe0MYvYgnbkNAfRoYKxzGbVDlABu7JMfebzAdfI826Qp+ IWUwD7Ui33rMsk0yd6n3v5fddspoZXIn+W7ps/nvEu+eEyj0NS8DeJWqtxmpPDKYMKlyjR okmXuQOYtjQTIAF1jKTL0DJ8yQV6OzyXq4a+iVJ/wiTERVz73wsj0IGOVkmu9vo8840sbX btHG9TNoGI6UJ8O3//eg7C+XK3V+DGgBkvTbNJKkPitWqpmOqVfrKR7udRj1GZjWkSBc5d YOmuAGao5u6hpb62wGP2anhGUygBnh534POxD6nYZM6GDqkTiyG2fommmq3CgQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YmFfq2gJvzxSr; Sun, 02 Feb 2025 16:37:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 512GbtJw075579; Sun, 2 Feb 2025 16:37:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 512Gbt1K075576; Sun, 2 Feb 2025 16:37:55 GMT (envelope-from git) Date: Sun, 2 Feb 2025 16:37:55 GMT Message-Id: <202502021637.512Gbt1K075576@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: ead758a67a6b - main - pms: Fix always true condition List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ead758a67a6b584293cfe02cd6c5cbefb6a4926f Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=ead758a67a6b584293cfe02cd6c5cbefb6a4926f commit ead758a67a6b584293cfe02cd6c5cbefb6a4926f Author: Svyatoslav AuthorDate: 2025-02-02 16:35:51 +0000 Commit: Warner Losh CommitDate: 2025-02-02 16:35:51 +0000 pms: Fix always true condition Although this is vendor code, and apparently abandoned vendor code at that, this is clearly a mistake and always true. It's unclear how to contribute back to the upstream at this point, alas. PR: 217745 Reviewed by: imp --- sys/dev/pms/RefTisa/sallsdk/spc/sampirsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/pms/RefTisa/sallsdk/spc/sampirsp.c b/sys/dev/pms/RefTisa/sallsdk/spc/sampirsp.c index 541940c5fda8..6a45e954d315 100644 --- a/sys/dev/pms/RefTisa/sallsdk/spc/sampirsp.c +++ b/sys/dev/pms/RefTisa/sallsdk/spc/sampirsp.c @@ -7217,7 +7217,7 @@ GLOBAL bit32 mpiDekManagementRsp( agEvent.encryptOperation = OSSA_HW_ENCRYPT_DEK_INVALIDTE; } agEvent.status = status; - if (status == OSSA_MPI_ENC_ERR_ILLEGAL_DEK_PARAM || OSSA_MPI_ERR_DEK_MANAGEMENT_DEK_UNWRAP_FAIL) + if (status == OSSA_MPI_ENC_ERR_ILLEGAL_DEK_PARAM || status == OSSA_MPI_ERR_DEK_MANAGEMENT_DEK_UNWRAP_FAIL) { agEvent.eq = errorQualifier; }