From owner-cvs-src@FreeBSD.ORG Mon Jan 10 21:34:01 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A470B16A4CE; Mon, 10 Jan 2005 21:34:01 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2121843D2D; Mon, 10 Jan 2005 21:34:01 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.254.12] (g4.samsco.home [192.168.254.12]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id j0ALbRsk041426; Mon, 10 Jan 2005 14:37:28 -0700 (MST) (envelope-from scottl@freebsd.org) Message-ID: <41E2F4C6.1010000@freebsd.org> Date: Mon, 10 Jan 2005 14:33:58 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040514 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Simon L. Nielsen" References: <200501061745.j06Hj344034786@repoman.freebsd.org> <20050110184139.GE19624@funkthat.com> <20050110202344.GC777@zaphod.nitro.dk> <41E2E561.9000504@freebsd.org> <20050110205654.GF777@zaphod.nitro.dk> In-Reply-To: <20050110205654.GF777@zaphod.nitro.dk> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: John-Mark Gurney cc: src-committers@freebsd.org cc: Maksim Yevmenkin cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netgraph ng_base.c src/sys/sys kernel.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jan 2005 21:34:01 -0000 Simon L. Nielsen wrote: > On 2005.01.10 13:28:17 -0700, Scott Long wrote: > >>Simon L. Nielsen wrote: >> >> >>>On 2005.01.10 10:41:39 -0800, John-Mark Gurney wrote: >>> >>> >>>>So, to everone, MODULE_DEPEND only marks which modules are required >>>>for this module to work, it does not infulence startup ordering at >>>>all... >>> >>>So, should I commit this patch? >>> > > [...] > >>>@@ -69,3 +69,7 @@ >>>.An -nosplit >>>This manual page was written by >>>.An Alexander Langer Aq alex@FreeBSD.org . >>>+.Sh BUGS >>>+.Nm >>>+only marks which modules are required for the module to work, it does >>>+not influence start-up ordering. >> >>It also is used by the loader and by kldload to load the dependent >>modules. So it's more than just an informational tag, it actually does >>get used by the system. > > > I don't think the above says it's only informational, but I'm sure the > wording could be improved. Perhpaps somebody has a suggestion for > better describing the issue? > Well, I guess my point is that it's important to document exactly what MODULE_DEPEND does do, and well as what it doesn't do. It's not really a bug that it doesn't change SI_ORDER order, it's just a not a feature that it was ever intended to support. A second paragraph under DESCRIPTION that talks about this would probably be most appropriate. Something like: .Nm provides hints to the kernel .Xr loader 8 and to .Xr kldload 8 to ensure that the named dependency is loaded prior to the existing module. It does not change or dictate the order in which modules are initialized at runtime. Scott