Date: Wed, 9 Jan 2019 17:47:27 +0100 From: "Carlos Jacobo Puga Medina" <cjpm@gmx.es> To: "Carlos J. Puga Medina" <cpm@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r489815 - in head/www/iridium: . files Message-ID: <trinity-529dc127-837d-4f41-8bdf-ae56c98b9b33-1547052446990@3c-app-mailcom-bs01> In-Reply-To: <201901091638.x09GcGV1041910@repo.freebsd.org> References: <201901091638.x09GcGV1041910@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Enviar: mi=C3=A9rcoles 9 de enero de 2019 a las 17:38 > De: "Carlos J=2E Puga Medina" <cpm@FreeBSD=2Eorg> > Para: ports-committers@freebsd=2Eorg, svn-ports-all@freebsd=2Eorg, svn-p= orts-head@freebsd=2Eorg > Asunto: svn commit: r489815 - in head/www/iridium: =2E files > > Author: cpm > Date: Wed Jan 9 16:38:15 2019 > New Revision: 489815 > URL: https://svnweb=2Efreebsd=2Eorg/changeset/ports/489815 >=20 > Log: > - Add USES=3Dgl > - Enable jumbo build to improve compilation times > - Fix loading of the chromium binary on FreeBSD-HEAD > - Fix jumbo build with the SNDIO option enabled > - Add -Wl,-znotext for i386 > - Bump PORTREVISION Wow, I forgot to mention:=20 - Remove unnecessary patches after 10=2E4 EoL=2E > =20 > MFH: 2019Q1 >=20 > Added: > head/www/iridium/files/patch-build_config_compiler_BUILD=2Egn (conte= nts, props changed) > head/www/iridium/files/patch-build_linux_chrome=2Emap (contents, pro= ps changed) > head/www/iridium/files/patch-build_toolchain_gcc_toolchain=2Egni (co= ntents, props changed) > head/www/iridium/files/patch-mojo_public_c_system_thunks=2Ecc (conte= nts, props changed) > Deleted: > head/www/iridium/files/extra-patch-llvm-base > head/www/iridium/files/patch-chrome_browser_diagnostics_diagnostics__w= riter=2Ecc > Modified: > head/www/iridium/Makefile > head/www/iridium/files/patch-chrome_app_chrome__main__delegate=2Ecc > head/www/iridium/files/patch-chrome_browser_diagnostics_diagnostics__w= riter=2Eh >=20 > Modified: head/www/iridium/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/www/iridium/Makefile Wed Jan 9 16:28:18 2019 (r489814) > +++ head/www/iridium/Makefile Wed Jan 9 16:38:15 2019 (r489815) > @@ -3,7 +3,7 @@ > =20 > PORTNAME=3D iridium > PORTVERSION=3D 2018=2E5=2E67 > -PORTREVISION=3D 6 > +PORTREVISION=3D 7 > CATEGORIES=3D www > MASTER_SITES=3D https://downloads=2Eiridiumbrowser=2Ede/source/ > PKGNAMESUFFIX=3D -browser > @@ -21,6 +21,7 @@ BUILD_DEPENDS=3D gperf:devel/gperf \ > bash:shells/bash \ > flock:sysutils/flock \ > node:www/node \ > + ${LOCALBASE}/bin/ar:devel/binutils \ > ${LOCALBASE}/include/linux/videodev2=2Eh:multimedia/v4l_compat \ > ${LOCALBASE}/share/usbids/usb=2Eids:misc/usbids \ > ${PYTHON_PKGNAMEPREFIX}Jinja2>0:devel/py-Jinja2@${PY_FLAVOR} \ > @@ -61,7 +62,7 @@ RUN_DEPENDS=3D xdg-open:devel/xdg-utils \ > =20 > ONLY_FOR_ARCHS=3D amd64 i386 > =20 > -USES=3D bison desktop-file-utils gnome jpeg localbase:ldflags ninja \ > +USES=3D bison desktop-file-utils gl gnome jpeg localbase:ldflags ninja= \ > perl5 pkgconfig python:2=2E7,build shebangfix tar:xz > USE_GL=3D gl > USE_LDCONFIG=3D ${DATADIR} > @@ -86,6 +87,7 @@ GN_ARGS+=3D clang_use_chrome_plugins=3Dfalse \ > enable_remoting=3Dfalse \ > fieldtrial_testing_like_official_build=3Dtrue \ > is_clang=3Dtrue \ > + jumbo_file_merge_limit=3D8 \ > toolkit_views=3Dtrue \ > treat_warnings_as_errors=3Dfalse \ > use_allocator=3D"none" \ > @@ -94,6 +96,7 @@ GN_ARGS+=3D clang_use_chrome_plugins=3Dfalse \ > use_bundled_fontconfig=3Dfalse \ > use_custom_libcxx=3Dfalse \ > use_gnome_keyring=3Dfalse \ > + use_jumbo_build=3Dtrue \ > use_gtk3=3Dtrue \ > use_lld=3Dtrue \ > use_sysroot=3Dfalse \ > @@ -162,8 +165,8 @@ SNDIO_LIB_DEPENDS=3D libsndio=2Eso:audio/sndio > SNDIO_VARS=3D GN_ARGS+=3Duse_sndio=3Dtrue > SNDIO_VARS_OFF=3D GN_ARGS+=3Duse_sndio=3Dfalse > =20 > -BUILD_DEPENDS+=3D ${LOCALBASE}/bin/ar:devel/binutils > -EXTRA_PATCHES+=3D ${FILESDIR}/extra-patch-llvm-base > +# Allow relocations against read-only segments (override lld default) > +LDFLAGS_i386=3D -Wl,-znotext > =20 > # TODO: -isystem, would be just as ugly as this approach, but more reli= ably > # build would fail without C_INCLUDE_PATH/CPLUS_INCLUDE_PATH env var se= t=2E >=20 > Added: head/www/iridium/files/patch-build_config_compiler_BUILD=2Egn > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/www/iridium/files/patch-build_config_compiler_BUILD=2Egn Wed Ja= n 9 16:38:15 2019 (r489815) > @@ -0,0 +1,76 @@ > +--- build/config/compiler/BUILD=2Egn=2Eorig 2018-05-09 21:05:34=2E00000= 0000 +0200 > ++++ build/config/compiler/BUILD=2Egn 2019-01-07 22:08:08=2E301170000 +0= 100 > +@@ -51,7 +51,7 @@ > + # only two architectures that are currently checked in)=2E Turn this= off when > + # you are using a custom toolchain and need to control -B in cflags= =2E > + linux_use_bundled_binutils =3D > +- linux_use_bundled_binutils_override && is_linux && > ++ linux_use_bundled_binutils_override && (is_linux && !is_bsd) && > + (current_cpu =3D=3D "x64" || current_cpu =3D=3D "x86") > + binutils_path =3D rebase_path("//third_party/binutils/Linux_x64/Rele= ase/bin", > + root_build_dir) > +@@ -375,8 +375,6 @@ > + "-Wl,-z,relro", > + ] > + if (!using_sanitizer) { > +- ldflags +=3D [ "-Wl,-z,defs" ] > +- > + # Functions interposed by the sanitizers can make ld think > + # that some libraries aren't needed when they actually are, > + # http://crbug=2Ecom/234010=2E As workaround, disable --as-neede= d=2E > +@@ -467,7 +465,7 @@ > + # TODO(hans): Remove this once Clang generates better optimized debu= g info by > + # default=2E https://crbug=2Ecom/765793 > + if (is_clang && !is_nacl && current_toolchain =3D=3D host_toolchain = && > +- target_os !=3D "chromeos") { > ++ target_os !=3D "chromeos" && !is_bsd) { > + cflags +=3D [ > + "-Xclang", > + "-mllvm", > +@@ -708,7 +706,7 @@ > + cflags +=3D [ "-mtune=3D$arm_tune" ] > + } > + } else if (current_cpu =3D=3D "arm64") { > +- if (is_clang && !is_android && !is_nacl && !is_fuchsia) { > ++ if (is_clang && !is_android && !is_nacl && !is_fuchsia && !is_bs= d) { > + cflags +=3D [ "--target=3Daarch64-linux-gnu" ] > + ldflags +=3D [ "--target=3Daarch64-linux-gnu" ] > + } > +@@ -1387,10 +1385,6 @@ > +=20 > + # TODO(hans): https://crbug=2Ecom/766891 > + "-Wno-null-pointer-arithmetic", > +- > +- # Ignore warnings about MSVC optimization pragmas=2E > +- # TODO(thakis): Only for no_chromium_code? http://crbug=2Ecom/= 505314 > +- "-Wno-ignored-pragma-optimize", > + ] > + if (llvm_force_head_revision) { > + cflags +=3D [ > +@@ -2096,7 +2090,7 @@ > + # [1] crrev=2Ecom/a81d5ade0b043208e06ad71a38bcf9c348a1a52f > + cflags +=3D [ "-gdwarf-3" ] > + } > +- cflags +=3D [ "-g2" ] > ++ cflags +=3D [ "-g0" ] > + } > + if (use_debug_fission && !is_nacl) { > + cflags +=3D [ "-gsplit-dwarf" ] > +@@ -2110,7 +2104,7 @@ > + # DWARF info may be corrupt; offsets in a range list entry are in = different > + # sections" there=2E Maybe just a bug in nacl_switch_32=2ES=2E > + if (!is_mac && !is_ios && !is_nacl && target_cpu !=3D "x86" && > +- (use_gold || use_lld)) { > ++ (use_gold || use_lld) && !is_bsd) { > + if (is_clang) { > + # This flag enables the GNU-format pubnames and pubtypes secti= ons, > + # which lld needs in order to generate a correct GDB index=2E > +@@ -2207,7 +2201,7 @@ > + if (!is_win && fatal_linker_warnings && > + !(is_chromeos && current_cpu =3D=3D "arm") && > + !(is_android && use_order_profiling) && !is_mac && !is_ios && > +- current_os !=3D "aix") { > ++ current_os !=3D "aix" && !is_bsd) { > + # TODO(jochen): Enable this on chromeos on arm=2E http://crbug=2Ec= om/356580 > + # TODO(lizeb,pasko): Fix link errors when linking with order_profi= ling=3D1 > + # crbug=2Ecom/485542 >=20 > Added: head/www/iridium/files/patch-build_linux_chrome=2Emap > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/www/iridium/files/patch-build_linux_chrome=2Emap Wed Jan 9 16:= 38:15 2019 (r489815) > @@ -0,0 +1,29 @@ > +--- build/linux/chrome=2Emap=2Eorig 2019-01-07 21:40:23=2E691384000 +01= 00 > ++++ build/linux/chrome=2Emap 2019-01-07 21:43:11=2E729540000 +0100 > +@@ -1,4 +1,7 @@ > + { > ++local: > ++ *; > ++ > + global: > + __bss_start; > + __data_start; > +@@ -20,6 +23,10 @@ > + # Program entry point=2E > + _start; > +=20 > ++ # FreeBSD specific variables=2E > ++ __progname; > ++ environ; > ++ > + # Memory allocation symbols=2E We want chrome and any libraries to > + # share the same heap, so it is correct to export these symbols=2E > + calloc; > +@@ -81,7 +88,4 @@ > + localtime64; > + localtime64_r; > + localtime_r; > +- > +-local: > +- *; > + }; >=20 > Added: head/www/iridium/files/patch-build_toolchain_gcc_toolchain=2Egni > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/www/iridium/files/patch-build_toolchain_gcc_toolchain=2Egni Wed= Jan 9 16:38:15 2019 (r489815) > @@ -0,0 +1,45 @@ > +--- build/toolchain/gcc_toolchain=2Egni=2Eorig 2018-05-09 21:05:34=2E00= 0000000 +0200 > ++++ build/toolchain/gcc_toolchain=2Egni 2019-01-07 22:08:08=2E298662000= +0100 > +@@ -25,6 +25,11 @@ > + rebase_path("//build/toolchain/clang_static_analyzer_wrapper=2Epy"= , > + root_build_dir) + " --mode=3Dclang" > +=20 > ++declare_args() { > ++ extra_cxxflags =3D "" > ++ extra_ldflags =3D "" > ++} > ++ > + # This template defines a toolchain for something that works like gcc > + # (including clang)=2E > + # > +@@ -608,13 +613,23 @@ > + } > +=20 > + gcc_toolchain(target_name) { > +- prefix =3D rebase_path("$clang_base_path/bin", root_build_dir) > +- cc =3D "$prefix/clang" > +- cxx =3D "$prefix/clang++" > +- ld =3D cxx > +- readelf =3D "${toolprefix}readelf" > +- ar =3D "${prefix}/llvm-ar" > +- nm =3D "${toolprefix}nm" > ++ if (is_bsd) { > ++ prefix =3D "/usr/local/bin" > ++ cc =3D "cc" > ++ cxx =3D "c++" > ++ ld =3D cxx > ++ readelf =3D "readelf" > ++ ar =3D "${prefix}/ar" > ++ nm =3D "${toolprefix}nm" > ++ } else { > ++ prefix =3D rebase_path("$clang_base_path/bin", root_build_dir) > ++ cc =3D "$prefix/clang" > ++ cxx =3D "$prefix/clang++" > ++ ld =3D cxx > ++ readelf =3D "${toolprefix}readelf" > ++ ar =3D "${prefix}/llvm-ar" > ++ nm =3D "${toolprefix}nm" > ++ } > +=20 > + forward_variables_from(invoker, > + [ >=20 > Modified: head/www/iridium/files/patch-chrome_app_chrome__main__delegate= =2Ecc > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/www/iridium/files/patch-chrome_app_chrome__main__delegate=2Ecc = Wed Jan 9 16:28:18 2019 (r489814) > +++ head/www/iridium/files/patch-chrome_app_chrome__main__delegate=2Ecc = Wed Jan 9 16:38:15 2019 (r489815) > @@ -1,6 +1,6 @@ > ---- chrome/app/chrome_main_delegate=2Ecc=2Eorig 2018-02-24 16:25:09=2E0= 00000000 +0100 > -+++ chrome/app/chrome_main_delegate=2Ecc 2018-03-03 20:07:40=2E48496900= 0 +0100 > -@@ -98,7 +98,7 @@ > +--- chrome/app/chrome_main_delegate=2Ecc=2Eorig 2018-05-09 21:05:35=2E0= 00000000 +0200 > ++++ chrome/app/chrome_main_delegate=2Ecc 2019-01-07 21:51:11=2E92154300= 0 +0100 > +@@ -97,7 +97,7 @@ > #include "chrome/app/shutdown_signal_handlers_posix=2Eh" > #endif > =20 > @@ -9,7 +9,7 @@ > #include "components/nacl/common/nacl_paths=2Eh" > #include "components/nacl/zygote/nacl_fork_delegate_linux=2Eh" > #endif > -@@ -133,7 +133,7 @@ > +@@ -131,7 +131,7 @@ > #include "v8/include/v8=2Eh" > #endif > =20 > @@ -18,7 +18,7 @@ > #include "base/environment=2Eh" > #endif > =20 > -@@ -238,7 +238,7 @@ > +@@ -236,7 +236,7 @@ > =20 > #endif // defined(OS_WIN) > =20 > @@ -27,7 +27,7 @@ > void AdjustLinuxOOMScore(const std::string& process_type) { > // Browsers and zygotes should still be killable, but killed last=2E > const int kZygoteScore =3D 0; > -@@ -407,7 +407,7 @@ > +@@ -404,7 +404,7 @@ > std::string process_type =3D > command_line->GetSwitchValueASCII(switches::kProcessType); > =20 > @@ -36,7 +36,7 @@ > // On Linux, Chrome does not support running multiple copies under d= ifferent > // DISPLAYs, so the profile directory can be specified in the enviro= nment to > // support the virtual desktop use-case=2E > -@@ -581,7 +581,7 @@ > +@@ -576,7 +576,7 @@ > #if defined(OS_CHROMEOS) > chromeos::RegisterPathProvider(); > #endif > @@ -45,25 +45,7 @@ > nacl::RegisterPathProvider(); > #endif > =20 > -@@ -603,7 +603,7 @@ > - std::string format_str =3D > - command_line=2EGetSwitchValueASCII(switches::kDiagnosticsFor= mat); > - if (format_str =3D=3D "machine") { > -- format =3D diagnostics::DiagnosticsWriter::MACHINE; > -+ format =3D diagnostics::DiagnosticsWriter::THEMACHINE; > - } else if (format_str =3D=3D "log") { > - format =3D diagnostics::DiagnosticsWriter::LOG; > - } else { > -@@ -653,7 +653,7 @@ > - std::string format_str =3D > - command_line=2EGetSwitchValueASCII(switches::kDiagnosticsFor= mat); > - if (format_str =3D=3D "machine") { > -- format =3D diagnostics::DiagnosticsWriter::MACHINE; > -+ format =3D diagnostics::DiagnosticsWriter::THEMACHINE; > - } else if (format_str =3D=3D "human") { > - format =3D diagnostics::DiagnosticsWriter::HUMAN; > - } else { > -@@ -915,7 +915,7 @@ > +@@ -893,7 +893,7 @@ > InitializePDF(); > #endif > =20 > @@ -72,7 +54,7 @@ > // Zygote needs to call InitCrashReporter() in RunZygote()=2E > if (process_type !=3D switches::kZygoteProcess) { > #if defined(OS_ANDROID) > -@@ -931,7 +931,7 @@ > +@@ -909,7 +909,7 @@ > breakpad::InitCrashReporter(process_type); > #endif // defined(OS_ANDROID) > } > @@ -81,7 +63,7 @@ > =20 > // After all the platform Breakpads have been initialized, store the= command > // line for crash reporting=2E > -@@ -941,7 +941,7 @@ > +@@ -919,7 +919,7 @@ > void ChromeMainDelegate::SandboxInitialized(const std::string& process= _type) { > // Note: If you are adding a new process type below, be sure to adju= st the > // AdjustLinuxOOMScore function too=2E >=20 > Modified: head/www/iridium/files/patch-chrome_browser_diagnostics_diagno= stics__writer=2Eh > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/www/iridium/files/patch-chrome_browser_diagnostics_diagnostics_= _writer=2Eh Wed Jan 9 16:28:18 2019 (r489814) > +++ head/www/iridium/files/patch-chrome_browser_diagnostics_diagnostics_= _writer=2Eh Wed Jan 9 16:38:15 2019 (r489815) > @@ -1,11 +1,11 @@ > ---- chrome/browser/diagnostics/diagnostics_writer=2Eh=2Eorig 2017-06-05= 19:03:02 UTC > -+++ chrome/browser/diagnostics/diagnostics_writer=2Eh > -@@ -19,7 +19,7 @@ class DiagnosticsWriter : public DiagnosticsModel::Ob= s > +--- chrome/browser/diagnostics/diagnostics_writer=2Eh=2Eorig 2018-05-09= 21:05:37=2E000000000 +0200 > ++++ chrome/browser/diagnostics/diagnostics_writer=2Eh 2019-01-07 21:53:= 10=2E249123000 +0100 > +@@ -15,6 +15,8 @@ > + // Console base class used internally=2E > + class SimpleConsole; > + > ++#undef MACHINE > ++ > + class DiagnosticsWriter : public DiagnosticsModel::Observer { > public: > // The type of formatting done by this writer=2E > - enum FormatType { > -- MACHINE, > -+ THEMACHINE, > - LOG, > - HUMAN > - }; >=20 > Added: head/www/iridium/files/patch-mojo_public_c_system_thunks=2Ecc > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/www/iridium/files/patch-mojo_public_c_system_thunks=2Ecc Wed Ja= n 9 16:38:15 2019 (r489815) > @@ -0,0 +1,29 @@ > +--- mojo/public/c/system/thunks=2Ecc=2Eorig 2019-01-09 11:00:07=2E79449= 3000 +0100 > ++++ mojo/public/c/system/thunks=2Ecc 2019-01-09 11:03:08=2E369317000 +0= 100 > +@@ -14,7 +14,7 @@ > + #include "build/build_config=2Eh" > + #include "mojo/public/c/system/core=2Eh" > +=20 > +-#if defined(OS_CHROMEOS) || defined(OS_LINUX) > ++#if defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_BSD) > + #include "base/environment=2Eh" > + #include "base/files/file_path=2Eh" > + #include "base/optional=2Eh" > +@@ -38,7 +38,7 @@ > + typedef void (*MojoGetSystemThunksFunction)(MojoSystemThunks* thunks= ); > +=20 > + CoreLibraryInitializer() { > +-#if defined(OS_CHROMEOS) || defined(OS_LINUX) > ++#if defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_BSD) > + auto environment =3D base::Environment::Create(); > +=20 > + base::FilePath library_path; > +@@ -80,7 +80,7 @@ > + ~CoreLibraryInitializer() =3D default; > +=20 > + private: > +-#if defined(OS_CHROMEOS) || defined(OS_LINUX) > ++#if defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_BSD) > + base::Optional<base::ScopedNativeLibrary> library_; > + #endif > +=20 >=20 >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?trinity-529dc127-837d-4f41-8bdf-ae56c98b9b33-1547052446990>