Date: Fri, 20 Sep 2002 19:41:10 +0900 From: Hajimu UMEMOTO <ume@mahoroba.org> To: John Baldwin <jhb@FreeBSD.org> Cc: "Jacques A. Vidrine" <nectar@FreeBSD.org>, re@FreeBSD.org, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Hajimu UMEMOTO <ume@mahoroba.org> Subject: Re: cvs commit: src/lib/libc/net getaddrinfo.c gethostbydns.c Message-ID: <ygeznudt03d.wl%ume@mahoroba.org> In-Reply-To: <XFMail.20020919164100.jhb@FreeBSD.org> References: <20020919182649.GG45529@hellblazer.nectar.cc> <XFMail.20020919164100.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
>>>>> On Thu, 19 Sep 2002 16:41:00 -0400 (EDT)
>>>>> John Baldwin <jhb@FreeBSD.org> said:
>> Enlarge answer buffer upto 64K
>> unless this, EDNS0 query becomes totally broken.
>
> I guess I missed your commit. Sorry!
jhb> Humm, log message for 1.19 reads:
jhb> revision 1.19
jhb> date: 2002/09/14 17:28:40; author: ume; state: Exp; lines: +2 -0
jhb> Limit UDP payload size for EDNS0 to 0xffff, not use lower 16bit value.
jhb> Obtained from: KAME
jhb> That doesn't seem to be enlarging the buffer from reading that
jhb> log message. Oh, I think I see. Yes, approved.
This change itself doesn't enlarge any buffer. EDNS0 passes receive
buffer size to a server, and the field is 2 bytes. So, the maximum
size that can be handled is 64K - 1.
Since the size is calculated from sizeof(), without masking buffer
size, wrong buffer size (actually 0 byte in case of 64K) is sent to a
server.
In any way, sorry for my unclear commit log.
Sincerely,
--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@mahoroba.org ume@bisd.hitachi.co.jp ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ygeznudt03d.wl%ume>