From owner-cvs-all Fri Sep 20 3:41:18 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6BE9237B401; Fri, 20 Sep 2002 03:41:16 -0700 (PDT) Received: from cheer.mahoroba.org (flets20-060.kamome.or.jp [218.45.20.60]) by mx1.FreeBSD.org (Postfix) with ESMTP id C95A943E7B; Fri, 20 Sep 2002 03:41:14 -0700 (PDT) (envelope-from ume@mahoroba.org) Received: from lyrics.mahoroba.org (IDENT:wfNEkncDzYGRJkLEUSguRKTOniDxwPOeZBRoyi6Q0MybJaspAGaxaXLtqwH58b50@lyrics.mahoroba.org [IPv6:2001:200:301:0:280:88ff:fe03:4841]) (user=ume mech=CRAM-MD5 bits=0) by cheer.mahoroba.org (8.12.6/8.12.6) with ESMTP/inet6 id g8KAfBxA058393 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Fri, 20 Sep 2002 19:41:12 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Fri, 20 Sep 2002 19:41:10 +0900 Message-ID: From: Hajimu UMEMOTO To: John Baldwin Cc: "Jacques A. Vidrine" , re@FreeBSD.org, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Hajimu UMEMOTO Subject: Re: cvs commit: src/lib/libc/net getaddrinfo.c gethostbydns.c In-Reply-To: References: <20020919182649.GG45529@hellblazer.nectar.cc> User-Agent: xcite1.38> Wanderlust/2.9.15 (Unchained Melody) SEMI/1.14.4 (Hosorogi) FLIM/1.14.4 (=?ISO-8859-4?Q?Kashiharajing=FE-mae?=) APEL/10.3 Emacs/21.2 (i386--freebsd) MULE/5.0 (=?ISO-2022-JP?B?GyRCOC1MWhsoQg==?=) X-Operating-System: FreeBSD 5.0-CURRENT MIME-Version: 1.0 (generated by SEMI 1.14.4 - "Hosorogi") Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: by AMaViS-perl11-milter (http://amavis.org/) Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi, >>>>> On Thu, 19 Sep 2002 16:41:00 -0400 (EDT) >>>>> John Baldwin said: >> Enlarge answer buffer upto 64K >> unless this, EDNS0 query becomes totally broken. > > I guess I missed your commit. Sorry! jhb> Humm, log message for 1.19 reads: jhb> revision 1.19 jhb> date: 2002/09/14 17:28:40; author: ume; state: Exp; lines: +2 -0 jhb> Limit UDP payload size for EDNS0 to 0xffff, not use lower 16bit value. jhb> Obtained from: KAME jhb> That doesn't seem to be enlarging the buffer from reading that jhb> log message. Oh, I think I see. Yes, approved. This change itself doesn't enlarge any buffer. EDNS0 passes receive buffer size to a server, and the field is 2 bytes. So, the maximum size that can be handled is 64K - 1. Since the size is calculated from sizeof(), without masking buffer size, wrong buffer size (actually 0 byte in case of 64K) is sent to a server. In any way, sorry for my unclear commit log. Sincerely, -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@bisd.hitachi.co.jp ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message