From owner-cvs-src@FreeBSD.ORG Sun Dec 3 07:59:15 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 87AA616A40F; Sun, 3 Dec 2006 07:59:15 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6E56043CB0; Sun, 3 Dec 2006 07:58:47 +0000 (GMT) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kB37xCSe010765; Sun, 3 Dec 2006 07:59:12 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from mjacob@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kB37xC3Q010764; Sun, 3 Dec 2006 07:59:12 GMT (envelope-from mjacob) Message-Id: <200612030759.kB37xC3Q010764@repoman.freebsd.org> From: Matt Jacob Date: Sun, 3 Dec 2006 07:59:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mpt mpt_cam.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Dec 2006 07:59:15 -0000 mjacob 2006-12-03 07:59:12 UTC FreeBSD src repository Modified files: sys/dev/mpt mpt_cam.c Log: Fix a massive couple of botches here: the NVRAM settings read wasn't flagging the SYNC mode was enabled. The temp values for offset and sync period were uint8_t, but were being assigned and shifted from a uint32_t value. This didn't show up in testing because a random number of 1030 cards set a bit that says "honor BIOS negotiation", which means this whole code path was skipped. This should clear up at least some of the negotation issues that have been seen. Revision Changes Path 1.43 +15 -23 src/sys/dev/mpt/mpt_cam.c