From owner-svn-src-all@freebsd.org Thu Feb 23 17:32:25 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 37B43CEBFC5; Thu, 23 Feb 2017 17:32:25 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D53BB190E; Thu, 23 Feb 2017 17:32:24 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wr0-x244.google.com with SMTP id z61so4644370wrc.3; Thu, 23 Feb 2017 09:32:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=f2VMB1oMmJ7UhCmZNL8czgD+eFYaWwGL6Sj1YJ6hxJs=; b=hKxvbCWojkg5Dn7B3XAwdwp9F3bSKD6nINToD049WoIpcMc77nirITLymFqxkBZDfN etCAjrmRzrVsr/tHmRak5mgbAoI+SEF86eNKHQSz6JqF3nFc3QInd5YNNMKchkelT+m5 YoAdbVRV7wDfQ/N114W0I5XQ4C5/Q0OX4fZdoCPQDI4aSAaINhKE4fKNJIx7na74zqet 4efnAsC9oc/CyOWF3SCYYAUtLCTQQDcGTWn7OTcxvMGLmx3EaOHuupM0F/MaRGrBFuQU Hg7PcDd6TLaov8ncHvk1Gs3UAANlUB1N7UNaBLvCBJfwtCKx6qHmSOVeJtXpN7sq7+R5 QLKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=f2VMB1oMmJ7UhCmZNL8czgD+eFYaWwGL6Sj1YJ6hxJs=; b=N/uOOut6NHkqcHahUaOFPQDV3//JIFP8ly33Sru2rwUNvibKwHmpNmnh0hSS/BJFBq KHWa3HpxvwlpkAey3Ir1sX/fYio/MDOEIagB4qwBT3SnAmVSg/4ZdR3u+ZzaV4q2EzfK BPTU3fZVynl92Ot78iTKbvZ5rvse3gseNX77Z8zzF3SdwEip3x6o/RfppfJFQsy0FwHi hiFnwdASsG0kjtJ/Cx13pOkD4pbQr4i9AWBNWf8S3XDFXsvPJ5P2gVzVHDbAo+A2uEld g+kcDMn/lVPh0QaMzKAn4UaV9CYBCa8c/lWlLZlD9iu2Ir3UwruZP1haqiSGGclIsbaO XBcQ== X-Gm-Message-State: AMke39lmPkSPqeRkTfR4ixFjS3rb5aZa/+KmQATwq/jhTprNUH8CtN52fo/3q2iFP0XotQ== X-Received: by 10.223.177.142 with SMTP id q14mr28805544wra.194.1487871141204; Thu, 23 Feb 2017 09:32:21 -0800 (PST) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by smtp.gmail.com with ESMTPSA id z80sm6920852wrc.24.2017.02.23.09.32.20 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 23 Feb 2017 09:32:20 -0800 (PST) Date: Thu, 23 Feb 2017 18:32:18 +0100 From: Mateusz Guzik To: "Pedro F. Giffuni" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314142 - head/sys/dev/ce Message-ID: <20170223173218.GB5744@dft-labs.eu> References: <201702231530.v1NFULwx024028@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <201702231530.v1NFULwx024028@repo.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2017 17:32:25 -0000 On Thu, Feb 23, 2017 at 03:30:21PM +0000, Pedro F. Giffuni wrote: > Author: pfg > Date: Thu Feb 23 15:30:21 2017 > New Revision: 314142 > URL: https://svnweb.freebsd.org/changeset/base/314142 > > Log: > dev/ce: double assignment. > > The code is not operational right now so just comment away an obviously > useless assignment. Fix some typos while here. > > > - /* XXXRIK: This function should be for comleteness, but for now I > - * don't use it. So I just start to write and didn't finished it yet. > - * It and it is VERY BUGGY!!! Do not use it. If you really > - * need it ask me to fix it or rewrite it by your self. > + /* XXXRIK: This function should be for completeness, but for now I > + * don't use it. I just started to write and haven't finished it yet. > + * It is VERY BUGGY!!! Do not use it. If you really need > + * it ask me to fix it or rewrite it by yourself. > * Note: most buggy part of it in ce_on_config_stop! > */ Please don't fix typos etc. unless they seriouslyl harm readability. Changes of this sort make it harder to svn blame. -- Mateusz Guzik