From owner-svn-ports-all@freebsd.org Thu Oct 8 10:35:05 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 946F43FC6E0 for ; Thu, 8 Oct 2020 10:35:05 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C6SJS66Mnz3c7q for ; Thu, 8 Oct 2020 10:35:04 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by mail-wm1-x343.google.com with SMTP id d4so5887919wmd.5 for ; Thu, 08 Oct 2020 03:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FQRekRU9JU5CqAcsnxV/HP9O5TvgzIJwm50B3xj+ITw=; b=jOLNgNkE39psFKIa0vpncqHqfbGhrHhKvLIih9WBIkJYTl7s9t97iIYzKT96Yg97DU o8DNOUlf8Out1zbM7T9x5e4cCSg2jhMk6yMxWSZh2PnbVnbjdhKJcGDGpPkVO7u80Zey NY1DMJfm3bAAnYKsnL/eR8orjmknppNl0wVdLzoRbLn6DLA8Z291bvZVogicIoqqU4h3 +YuLAurRp8IASCZuVpvo7im0+eI7eMoS3GTNGSHZHMxsCrd+QWv7TQwOKoGMyDQpMe2J 2PWLrTFWpGhNxPeHxRa/+HjqFMl8MJg8xNZG1I9guaocBpUJWHa9Bi2rJfkTQ7pWSsDK XZNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FQRekRU9JU5CqAcsnxV/HP9O5TvgzIJwm50B3xj+ITw=; b=N/tMFgPC4uSSlcFaU9yoSnJusk+lUuw1Jimnzw9uH6791xEsGZBNvPVYbF8wQ96aHF TD/aHRHBnD6QZCzABzZWAnwTMnXd9f/nJtvypOHi/HMZ+Ueiu64ShKaXLsIQdMVgxC+Q P6lW/AcV3fn5Z1RM0a5eosGBZ+yK3uXNsHE7w5h0zVtHBq0ohkqsfVIwjKx1Gm99v9Mm RbdxmCxfyew/1OmMh2MIbX/pkNVn3sMV9Hhw3Yl/kP68Sl5d/z0F/jTvi9lSWIIZOF9k /o5zlytS27/896uQCMUp8MLQzGxyYJ7Il+InmidWy63JPNtNhC/obczQ9ahJnDLDevJG 936Q== X-Gm-Message-State: AOAM531BkMgDvCN+bLwqCB0fncN0+vys4pFfVJ3Yq+NRIgCfonG7pqwO SRROkjXhzBBKP2dMbOE4Uz8p52zNc6Toh+wq9tMSpw== X-Google-Smtp-Source: ABdhPJwV5AbHvADNquuuRywRR5UigUfiAiXB9fTT7teLMLV55XWu9tQlR00aY49gSEISjoYW4QGyI+O/WEut3vL7/4Q= X-Received: by 2002:a1c:b7c6:: with SMTP id h189mr8566276wmf.154.1602153303250; Thu, 08 Oct 2020 03:35:03 -0700 (PDT) MIME-Version: 1.0 References: <202010071306.097D6JOj080863@repo.freebsd.org> <20201008102448.GA35539@KGPE-D16> In-Reply-To: <20201008102448.GA35539@KGPE-D16> From: Adam Weinberger Date: Thu, 8 Oct 2020 04:34:47 -0600 Message-ID: Subject: Re: svn commit: r551634 - head/databases/postgresql13-server To: Piotr Kubaj Cc: ports-committers , svn-ports-all , svn-ports-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4C6SJS66Mnz3c7q X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=adamw-org.20150623.gappssmtp.com header.s=20150623 header.b=jOLNgNkE; dmarc=none; spf=pass (mx1.freebsd.org: domain of adamw@adamw.org designates 2a00:1450:4864:20::343 as permitted sender) smtp.mailfrom=adamw@adamw.org X-Spamd-Result: default: False [-2.97 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.01)[-1.011]; R_DKIM_ALLOW(-0.20)[adamw-org.20150623.gappssmtp.com:s=20150623]; FREEFALL_USER(0.00)[adamw]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; RCVD_TLS_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-ports-all@freebsd.org]; DMARC_NA(0.00)[adamw.org]; NEURAL_HAM_LONG(-0.99)[-0.993]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[adamw-org.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.47)[-0.469]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::343:from]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[svn-ports-all] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2020 10:35:05 -0000 On Thu, Oct 8, 2020 at 4:24 AM Piotr Kubaj wrote: > > It was previously committed in https://svnweb.freebsd.org/ports?view=revision&revision=527871 and it seemed to work. Or is it that just no one noticed it? > > I'm trying to understand why this issue appeared and how to fix it without reverting to the previous (also broken) behaviour. The problem happens because of the extra level of indirection. The ${CHOSEN_COMPILER_TYPE} causes it to be evaluated too late, overwriting PORT_OPTIONS. As to why it wasn't happening before, I'm not sure. Why not just exclude it on gcc archs instead? OPTIONS_DEFINE= ... LLVM OPTIONS_EXCLUDE_fooarch= LLVM I can certainly appreciate the clever approach you're taking here, but it's apparently too clever for options.mk. # Adam > On 20-10-08 04:11:05, Adam Weinberger wrote: > > On Wed, Oct 7, 2020 at 7:06 AM Piotr Kubaj wrote: > > > > > > Author: pkubaj > > > Date: Wed Oct 7 13:06:19 2020 > > > New Revision: 551634 > > > URL: https://svnweb.freebsd.org/changeset/ports/551634 > > > > > > Log: > > > databases/postgresql13-server: fix build on GCC architectures > > > > > > Add the previously removed disabling of LLVM when it's not in base. > > > > > > > +OPTIONS_DEFAULT+= ${OPTIONS_DEFAULT_${CHOSEN_COMPILER_TYPE}} > > > +OPTIONS_DEFAULT_clang= LLVM > > > > This forces the LLVM option on for all clang users, and prevents it > > from ever getting turned off. Please, turn the LLVM forcing off. -- Adam Weinberger adamw@adamw.org https://www.adamw.org