From owner-freebsd-ports@FreeBSD.ORG  Mon May 14 05:20:29 2007
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: freebsd-ports@freebsd.org
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 599FD16A406
	for <freebsd-ports@freebsd.org>; Mon, 14 May 2007 05:20:29 +0000 (UTC)
	(envelope-from LoN_Kamikaze@gmx.de)
Received: from mail.gmx.net (mail.gmx.net [213.165.64.20])
	by mx1.freebsd.org (Postfix) with SMTP id 9D22213C45D
	for <freebsd-ports@freebsd.org>; Mon, 14 May 2007 05:20:28 +0000 (UTC)
	(envelope-from LoN_Kamikaze@gmx.de)
Received: (qmail invoked by alias); 14 May 2007 05:20:27 -0000
Received: from nat-wh-1.rz.uni-karlsruhe.de (EHLO mobileKamikaze.norad)
	[129.13.72.169]
	by mail.gmx.net (mp049) with SMTP; 14 May 2007 07:20:27 +0200
X-Authenticated: #5465401
X-Provags-ID: V01U2FsdGVkX1/+LRMSds7+pUUS3S07yT1Z5Hg1jgOz64C9gCkXao
	oGJORh6CJFr45p
Message-ID: <4647F182.6000402@gmx.de>
Date: Mon, 14 May 2007 07:20:02 +0200
From: "[LoN]Kamikaze" <LoN_Kamikaze@gmx.de>
User-Agent: Thunderbird 2.0.0.0 (X11/20070506)
MIME-Version: 1.0
To: Stephen Montgomery-Smith <stephen@math.missouri.edu>
References: <464597C6.3030406@gmx.de>	<20070512174011.GA22526@xor.obsecurity.org>	<4645FF71.60100@gmx.de>	<20070512175824.GA23103@xor.obsecurity.org>	<20070512133054.B5588@math.missouri.edu>	<4646193E.5040503@gmx.de>	<464665D5.1090509@math.missouri.edu>	<464676CC.2000203@math.missouri.edu>	<46469BF5.9030603@math.missouri.edu>	<1179058696.13237.3.camel@ikaros.oook.cz>	<20070513101332.L82202@math.missouri.edu>
	<46479215.1080401@math.missouri.edu>
	<4647C4FB.9050607@math.missouri.edu>
In-Reply-To: <4647C4FB.9050607@math.missouri.edu>
X-Enigmail-Version: 0.95.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Y-GMX-Trusted: 0
Cc: Pav Lucistnik <pav@freebsd.org>, freebsd-ports@freebsd.org,
	Kris Kennaway <kris@obsecurity.org>
Subject: Re: Time to abandon recursive pulling of dependencies?
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 May 2007 05:20:29 -0000

Stephen Montgomery-Smith wrote:
> Basically I think we are stuck on making "make package-depends" go any
> faster.
> 
> However I do think that the modifications I made to pkg_create go a very
> significant way to solving the problem of registration taking so very long.
> 
> Stephen
> 

You are right about invoking make being the problem. However, I was able to
increase the performance of package-depends by 20 to 30 percent, by avoiding
recursive make calls and moving the recursion into the stack of the shell
invocation.

With my changes there's less than 10% overhead over the sum of make calls. I.e.
 for 56 seconds of make calls (x11/xorg on my system) there are only 4 more
seconds of processing, instead of 15 to 20 seconds.

The original make package-depends does some things I don't understand. Once
I've figured them out I will post my little patch here.