From owner-freebsd-bugs  Fri Sep 26 23:10:03 1997
Return-Path: <owner-freebsd-bugs>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id XAA00672
          for bugs-outgoing; Fri, 26 Sep 1997 23:10:03 -0700 (PDT)
Received: (from gnats@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id XAA00666;
          Fri, 26 Sep 1997 23:10:02 -0700 (PDT)
Resent-Date: Fri, 26 Sep 1997 23:10:02 -0700 (PDT)
Resent-Message-Id: <199709270610.XAA00666@hub.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@FreeBSD.ORG, jack@diamond.xtalwind.net
Received: from zeus.xtalwind.net (xtal36.xtalwind.net [205.160.242.87])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id XAA00312
          for <FreeBSD-gnats-submit@freebsd.org>; Fri, 26 Sep 1997 23:03:48 -0700 (PDT)
Received: (from jack@localhost)
	by zeus.xtalwind.net (8.8.7/8.8.5) id CAA06931;
	Sat, 27 Sep 1997 02:03:43 -0400 (EDT)
Message-Id: <199709270603.CAA06931@zeus.xtalwind.net>
Date: Sat, 27 Sep 1997 02:03:43 -0400 (EDT)
From: Jack <jack@zeus.xtalwind.net>
Reply-To: jack@diamond.xtalwind.net
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: misc/4636: sysinstall upgrade overwrites /etc network files before backing them up
Sender: owner-freebsd-bugs@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         4636
>Category:       misc
>Synopsis:       sysinstall upgrade overwrites /etc network files before backing them up
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 26 23:10:01 PDT 1997
>Last-Modified:
>Originator:     Jack
>Organization:
>Release:        FreeBSD 2.2-STABLE i386
>Environment:

	

>Description:

	Upgrade install overwrites /etc/hosts, /etc/resolv.conf, and /etc/ppp/ppp.conf, /etc/ppp/ppp.linkup during ppp install, before backing up /etc 

>How-To-Repeat:

	Choose upgrade from the sysinstall menu

>Fix:
	
	Backup all /etc files before writing.


*** installUpgrade.c.orig	Sat Sep 27 01:32:30 1997
--- installUpgrade.c	Sat Sep 27 01:33:57 1997
***************
*** 252,271 ****
  	systemCreateHoloshell();
      }
  
- media:
-     if (!mediaVerify())
- 	return DITEM_FAILURE | DITEM_RESTORE;
- 
-     if (!mediaDevice->init(mediaDevice)) {
- 	if (!msgYesNo("Couldn't initialize the media.  Would you like\n"
- 		   "to adjust your media selection and try again?")) {
- 	    mediaDevice = NULL;
- 	    goto media;
- 	}
- 	else
- 	    return DITEM_FAILURE | DITEM_REDRAW;
-     }
-     
      saved_etc = NULL;
      if (extractingBin) {
  	while (!saved_etc) {
--- 252,257 ----
***************
*** 300,305 ****
--- 286,305 ----
  	}
      }
  
+ media:
+     if (!mediaVerify())
+ 	return DITEM_FAILURE | DITEM_RESTORE;
+ 
+     if (!mediaDevice->init(mediaDevice)) {
+ 	if (!msgYesNo("Couldn't initialize the media.  Would you like\n"
+ 		   "to adjust your media selection and try again?")) {
+ 	    mediaDevice = NULL;
+ 	    goto media;
+ 	}
+ 	else
+ 	    return DITEM_FAILURE | DITEM_REDRAW;
+     }
+     
      msgNotify("Beginning extraction of distributions..");
      if (DITEM_STATUS(distExtractAll(self)) == DITEM_FAILURE) {
  	msgConfirm("Hmmmm.  We couldn't even extract the bin distribution.  This upgrade\n"

>Audit-Trail:
>Unformatted: