From owner-svn-src-all@FreeBSD.ORG Sun Apr 19 20:24:09 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 36C411065670; Sun, 19 Apr 2009 20:24:09 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from vlakno.cz (77-93-215-190.static.masterinter.net [77.93.215.190]) by mx1.freebsd.org (Postfix) with ESMTP id E39628FC15; Sun, 19 Apr 2009 20:24:08 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from localhost (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id B3F0B9CB0EA; Sun, 19 Apr 2009 22:22:55 +0200 (CEST) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by localhost (lev.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X+vPs0uswFlz; Sun, 19 Apr 2009 22:22:53 +0200 (CEST) Received: from vlk.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 7B87A9CB10F; Sun, 19 Apr 2009 22:22:53 +0200 (CEST) Received: (from rdivacky@localhost) by vlk.vlakno.cz (8.14.3/8.14.3/Submit) id n3JKMrEM029699; Sun, 19 Apr 2009 22:22:53 +0200 (CEST) (envelope-from rdivacky) Date: Sun, 19 Apr 2009 22:22:53 +0200 From: Roman Divacky To: Dmitry Chagin Message-ID: <20090419202253.GA28306@freebsd.org> References: <200904191348.n3JDmhVH010871@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200904191348.n3JDmhVH010871@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r191269 - head/sys/compat/linux X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Apr 2009 20:24:09 -0000 On Sun, Apr 19, 2009 at 01:48:43PM +0000, Dmitry Chagin wrote: > Author: dchagin > Date: Sun Apr 19 13:48:42 2009 > New Revision: 191269 > URL: http://svn.freebsd.org/changeset/base/191269 > > Log: > Remove support for FUTEX_REQUEUE operation. > Glibc does not use this operation since 2.3.3 version (Jun 2004), > as it is racy and replaced by FUTEX_CMP_REQUEUE operation. > Glibc versions prior to 2.3.3 fall back to FUTEX_WAKE when > FUTEX_REQUEUE returned EINVAL. > > Any application directly using FUTEX_REQUEUE without return > value checking are definitely broken. > > Limit quantity of messages per process about unsupported > operation. > > Approved by: kib (mentor) > MFC after: 1 month > > Modified: > head/sys/compat/linux/linux_emul.c > head/sys/compat/linux/linux_emul.h > head/sys/compat/linux/linux_futex.c > > Modified: head/sys/compat/linux/linux_emul.c > ============================================================================== > --- head/sys/compat/linux/linux_emul.c Sun Apr 19 12:41:37 2009 (r191268) > +++ head/sys/compat/linux/linux_emul.c Sun Apr 19 13:48:42 2009 (r191269) > @@ -86,6 +86,7 @@ linux_proc_init(struct thread *td, pid_t > em = malloc(sizeof *em, M_LINUX, M_WAITOK | M_ZERO); > em->pid = child; > em->pdeath_signal = 0; > + em->used_requeue = 0; > em->robust_futexes = NULL; > if (flags & LINUX_CLONE_THREAD) { > /* handled later in the code */ > > Modified: head/sys/compat/linux/linux_emul.h > ============================================================================== > --- head/sys/compat/linux/linux_emul.h Sun Apr 19 12:41:37 2009 (r191268) > +++ head/sys/compat/linux/linux_emul.h Sun Apr 19 13:48:42 2009 (r191269) > @@ -51,6 +51,7 @@ struct linux_emuldata { > struct linux_emuldata_shared *shared; > > int pdeath_signal; /* parent death signal */ > + int used_requeue; /* uses deprecated futex op */ what is the point of this variable? it's only set and never read