From owner-cvs-all@FreeBSD.ORG Sat May 10 11:08:24 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ACBD237B401; Sat, 10 May 2003 11:08:24 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3EBAA43FBF; Sat, 10 May 2003 11:08:24 -0700 (PDT) (envelope-from bmilekic@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h4AI8O0U089822; Sat, 10 May 2003 11:08:24 -0700 (PDT) (envelope-from bmilekic@repoman.freebsd.org) Received: (from bmilekic@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h4AI8Nfe089821; Sat, 10 May 2003 11:08:23 -0700 (PDT) Message-Id: <200305101808.h4AI8Nfe089821@repoman.freebsd.org> From: Bosko Milekic Date: Sat, 10 May 2003 11:08:23 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern subr_mbuf.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 May 2003 18:08:25 -0000 bmilekic 2003/05/10 11:08:23 PDT FreeBSD src repository Modified files: sys/kern subr_mbuf.c Log: Make m_freem() just use m_free() instead of duplicating the code. The reason for the duplication was that m_freem() was meant to eventually be optimized to hold the lock of the cache being freed to as long as possible across frees but the difficulty of implementing said optimization right now is too high, given that in some cases (see MAC and non-cluster external buffers), we need to call into other subsytems, something not permissible when the cache lock is held. This change minimizes code duplication while keeping at least the atomic mbuf+cluster free optimization. Suggested by: luigi Revision Changes Path 1.48 +2 -32 src/sys/kern/subr_mbuf.c