From owner-cvs-all@FreeBSD.ORG  Mon Aug  8 19:56:55 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 795F816A41F;
	Mon,  8 Aug 2005 19:56:55 +0000 (GMT)
	(envelope-from truckman@FreeBSD.org)
Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 184F043D48;
	Mon,  8 Aug 2005 19:56:55 +0000 (GMT)
	(envelope-from truckman@FreeBSD.org)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
	by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id j78Jui1l095716;
	Mon, 8 Aug 2005 12:56:48 -0700 (PDT)
	(envelope-from truckman@FreeBSD.org)
Message-Id: <200508081956.j78Jui1l095716@gw.catspoiler.org>
Date: Mon, 8 Aug 2005 12:56:44 -0700 (PDT)
From: Don Lewis <truckman@FreeBSD.org>
To: csjp@FreeBSD.org
In-Reply-To: <200508081854.j78IsaOp043271@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_sysctl.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Aug 2005 19:56:55 -0000

On  8 Aug, Christian S.J. Peron wrote:
> csjp        2005-08-08 18:54:35 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/kern             kern_sysctl.c 
>   Log:
>   Check to see if we wired the user-supplied buffers in SYSCTL_OUT, if
>   the buffer has not been wired and we are holding any non-sleep-able locks,
>   drop a witness warning. If the buffer has not been wired, it is possible
>   that the writing of the data can sleep, especially if the page is not in
>   memory. This can result in a number of different locking issues, including
>   dead locks.

Thanks.

I think SYSCTL_IN() should also check for locks.  We don't have a
function to wire the buffer in this direction.