From owner-svn-src-all@FreeBSD.ORG Thu May 8 23:00:11 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4ECEFE9; Thu, 8 May 2014 23:00:11 +0000 (UTC) Received: from mail-we0-x236.google.com (mail-we0-x236.google.com [IPv6:2a00:1450:400c:c03::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4A202EB0; Thu, 8 May 2014 23:00:10 +0000 (UTC) Received: by mail-we0-f182.google.com with SMTP id t60so3142397wes.41 for ; Thu, 08 May 2014 16:00:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=lmCcLaGMkE8sZRUOIFRXV4r/8ys+T2YB8hX2pngbTvk=; b=pjBefbacrqFLKptvhIkkqIiQofsPxuTOluYHnr4dPTN5t0hHlGCRCFEjHhsNpyDOtA P1ca3D2w0nDlVs/xNwQzSno9SbHZlJc62o6+2TIk6VBfBvSHpmmCQQodjtuqaTCeHtgn BQSoUWb577jncOXFMfkEfElUI3RIAnQe+o/B3f6XWiIyMFmK7tVrU+4OoH7f8p9B3YVw 2Avi5LtwPTinH1MMjGrvSCjN+7h8QsdEYzt317IZdQDlCowa3dohANmquqkYh148bsfz NOlWojBG0DcDhjPxRo8v8cHjctNXs0Yl20dTnccY7pF3FnwiWdmnVcIBAp/bqdV31sea z2Fw== MIME-Version: 1.0 X-Received: by 10.180.100.234 with SMTP id fb10mr419049wib.26.1399590008370; Thu, 08 May 2014 16:00:08 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.194.168.130 with HTTP; Thu, 8 May 2014 16:00:08 -0700 (PDT) In-Reply-To: References: <201405062206.s46M6dxW060155@svn.freebsd.org> <20140507113345.B923@besplex.bde.org> Date: Thu, 8 May 2014 17:00:08 -0600 X-Google-Sender-Auth: ckIcfCKu5IloQMwR9tWfum3f6t0 Message-ID: Subject: Re: svn commit: r265472 - head/bin/dd From: Alan Somers To: Dmitry Morozovsky Content-Type: text/plain; charset=UTF-8 Cc: "src-committers@freebsd.org" , Alan Somers , "svn-src-all@freebsd.org" , trociny@freebsd.org, Bruce Evans , "svn-src-head@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 May 2014 23:00:11 -0000 On Thu, May 8, 2014 at 4:55 PM, Dmitry Morozovsky wrote: > On Wed, 7 May 2014, Alan Somers wrote: > > [snip] > >> Even if nanosecond resolution isn't useful, monotonicity is. Nobody >> should be using a nonmonotonic clock just to measure durations. I >> started an audit of all of FreeBSD to look for other programs that use >> gettimeofday to measure durations. I haven't finished, but I've >> already found a lot, including xz, ping, hastd, fetch, systat, powerd, >> and others. I don't have time to fix them, though. Would you be >> interested, or do you know anyone else who would? > > From your list, hastd seems to be the most dangerous point to me. > > Adding trociny@ as one of the most active hastd-related committers so the issue > would not be lost in the areas... In hastd's case, the problematic comparison is only used to print debugging info. It happens twice, in primary.c lines 1978 and 2039. > > -- > Sincerely, > D.Marck [DM5020, MCK-RIPE, DM3-RIPN] > [ FreeBSD committer: marck@FreeBSD.org ] > ------------------------------------------------------------------------ > *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** > ------------------------------------------------------------------------