Date: 7 Mar 2004 23:31:56 -0000 From: divZero <freebsd-dr@durchnull.de> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/63904: Maintainer update: x11-wm/treewm - fixes "menu item commands are lower-cased" Message-ID: <20040307233156.37342.qmail@durchnull.ath.cx> Resent-Message-ID: <200403072340.i27NeAIM013796@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 63904
>Category: ports
>Synopsis: Maintainer update: x11-wm/treewm - fixes "menu item commands are lower-cased"
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: maintainer-update
>Submitter-Id: current-users
>Arrival-Date: Sun Mar 07 15:40:10 PST 2004
>Closed-Date:
>Last-Modified:
>Originator: Rudolf Polzer
>Release: FreeBSD 5.2.1-RELEASE i386
>Organization:
>Environment:
System: FreeBSD katsuragi.durchnull.ath.cx 5.2.1-RELEASE FreeBSD 5.2.1-RELEASE #7: Thu Feb 26 21:54:57 CET 2004 root@katsuragi.durchnull.ath.cx:/usr/src/sys/i386/compile/DIV0_KERNEL i386
>Description:
Menu item values (eg commands) are converted to lower case for no apparent
reason, making it impossible to call programs like Eterm from the menu.
Behavior of treewm is changed/corrected using a simple patch.
>How-To-Repeat:
Insert in your .treewm in the menu section:
Test = !xmessage "Hello World!"
The message will contain "hello world!" in lower case letters.
This is obviously a bug.
>Fix:
Appliying this diff to x11-wm/treewm should fix it.
--- treewm.diff begins here ---
diff -ruN /usr/ports/x11-wm/treewm/Makefile treewm/Makefile
--- /usr/ports/x11-wm/treewm/Makefile Thu Feb 5 06:45:48 2004
+++ treewm/Makefile Mon Mar 8 00:23:39 2004
@@ -7,7 +7,7 @@
PORTNAME= treewm
PORTVERSION= 0.4.5
-PORTREVISION= 1
+PORTREVISION= 2
CATEGORIES= x11-wm
MASTER_SITES= ${MASTER_SITE_SOURCEFORGE}
MASTER_SITE_SUBDIR= ${PORTNAME}
diff -ruN /usr/ports/x11-wm/treewm/files/patch-menuinfo.cc treewm/files/patch-menuinfo.cc
--- /usr/ports/x11-wm/treewm/files/patch-menuinfo.cc Thu Jan 1 01:00:00 1970
+++ treewm/files/patch-menuinfo.cc Mon Mar 8 00:23:57 2004
@@ -0,0 +1,12 @@
+diff -ru treewm-0.4.5.orig/src/menuinfo.cc treewm-0.4.5/src/menuinfo.cc
+--- src/menuinfo.cc Mon Mar 8 00:20:42 2004
++++ src/menuinfo.cc Mon Mar 8 00:22:37 2004
+@@ -21,7 +21,7 @@
+ MenuItemList *actions=0,*last=0;
+ for (Entry *e=s->fe;e;e=e->next)
+ if (e->tag) {
+- lower(e->value);
++ // lower(e->value); // why? (RP)
+ if (last) {
+ last->next = new MenuItemList;
+ last = last->next;
--- treewm.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040307233156.37342.qmail>