From owner-svn-ports-all@freebsd.org Thu Feb 4 08:18:17 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D5793A9B746 for ; Thu, 4 Feb 2016 08:18:17 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-vk0-x230.google.com (mail-vk0-x230.google.com [IPv6:2607:f8b0:400c:c05::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9F042AE for ; Thu, 4 Feb 2016 08:18:17 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: by mail-vk0-x230.google.com with SMTP id e64so32164823vkg.0 for ; Thu, 04 Feb 2016 00:18:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sunpoet-net.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=+GLgBRh7HgHDaUi5EYEKXIPSqzVjZBW/EDXMXPmeWkg=; b=rBDrBtI0tRb7im6ywgY6Ez2Nt6Uzj1UaaXkKs9xN6cKT3eTKY1SoAoNx5uHN14EtpL IHeoZ50eSzOiiBy9znYNthma13XI9Iki3Nog9GZMcPgPAzktfa+YcDKoihY+pxkn+Inp /hhTJ+O4fpNbvoi1QX6NlgnMbj9vxIahCXyO5uPAPvUvgVMc389/8KbvdjjvUEx67wYB /JrDtG4rbLAARvA1P0DyUnRh9nosXn1rXYSWXHmRblipVJEEIhTy0OzK/BlKLNh2z0Ok 2aDPxK3lkBSNhqaWQAU9AmdLBy0BSRryA4bSaSJk/v3SXHcAfFPUWAbOcTlZdveR2dzH CHSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=+GLgBRh7HgHDaUi5EYEKXIPSqzVjZBW/EDXMXPmeWkg=; b=ZsWK5xmBjY/w7Y0VVFSdLikKfc+WMjzQVPKn9p6GQWjYwAcwXidVCDXVyFXhGYDVGr MNJBxROn3OC7r2Ya22ck+Aqug6M4y3KOiroc2HCiteczADcAvWiFC61htqxV+7lHUxBP GQ7RVbm6l0BqtpRAUNMgZAJyz7ycXtZ/JY+G1YLy0Org1zQx7hzRnTFxqnfj3Y6sk4aJ y+Dppuxj8E2qjuWpefcCXnWRmJRihzbjL0R79XiHFpiMMfqKmU3k/q88Y/pULSpE2+Na rIOkrGezJC/+w1r5lOtWLEdzcERxQI/I9N1q7f4ZtdfVL/gyisGx0MT03y6z2kOXN3H5 BfpA== X-Gm-Message-State: AG10YOSQwzwtwT/NihjAoX6+6RkT46XGaNAL8EXeccGOcGuACnYBd82j7o6f8V0wRw28nWLW6tTxsHZ164qnuA== X-Received: by 10.31.52.195 with SMTP id b186mr4259827vka.39.1454573896552; Thu, 04 Feb 2016 00:18:16 -0800 (PST) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.31.189.4 with HTTP; Thu, 4 Feb 2016 00:17:37 -0800 (PST) In-Reply-To: <56B2EA50.2070205@FreeBSD.org> References: <201602032054.u13KsXim088211@repo.freebsd.org> <56B2EA50.2070205@FreeBSD.org> From: Sunpoet Po-Chuan Hsieh Date: Thu, 4 Feb 2016 16:17:37 +0800 X-Google-Sender-Auth: xQq4krKbY8v6Qls-euiQ06wDnN0 Message-ID: Subject: Re: svn commit: r407978 - head/dns/py-py3dns To: Kubilay Kocak Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Ruslan Mahmatkhanov Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Feb 2016 08:18:17 -0000 On Thu, Feb 4, 2016 at 2:06 PM, Kubilay Kocak wrote: > On 4/02/2016 7:54 AM, Sunpoet Po-Chuan Hsieh wrote: > > Author: sunpoet > > Date: Wed Feb 3 20:54:33 2016 > > New Revision: 407978 > > URL: https://svnweb.freebsd.org/changeset/ports/407978 > > > > Log: > > - Sort knobs > > - Remove incorrect and outdated PYTHON_REL check > > - Do not silence test message > > > > Modified: > > head/dns/py-py3dns/Makefile > > > > Modified: head/dns/py-py3dns/Makefile > > > ============================================================================== > > --- head/dns/py-py3dns/Makefile Wed Feb 3 20:54:28 2016 > (r407977) > > +++ head/dns/py-py3dns/Makefile Wed Feb 3 20:54:33 2016 > (r407978) > > @@ -17,20 +17,11 @@ LICENSE_PERMS= dist-mirror dist-sell pkg > > > > TEST_DEPENDS= > ${PYTHON_PKGNAMEPREFIX}pytest>=0:${PORTSDIR}/devel/py-pytest > > > > -USES= python:3.3+ > > -USE_PYTHON= autoplist distutils > > - > > NO_ARCH= yes > > - > > -.include > > - > > -.if ${PYTHON_REL} == 3300 > > -RUN_DEPENDS+= > ${PYTHON_PKGNAMEPREFIX}ipaddress>=0:${PORTSDIR}/net/py-ipaddress > > -.elif ${PYTHON_REL} <= 3200 > > -RUN_DEPENDS+= > ${PYTHON_PKGNAMEPREFIX}ipaddr>=0:${PORTSDIR}/devel/py-ipaddr > > -.endif > > +USE_PYTHON= autoplist distutils > > +USES= python:3.3+ > > Removing the 3300 check breaks the port, which is what r407821 and > r407820 fixed: > > https://svnweb.freebsd.org/changeset/ports/407821 > https://svnweb.freebsd.org/changeset/ports/407820 > > This causes a regression on 3.3 > > I'm also -1 on removing declarations of which python versions a package > supports, whether or not we have them in the tree. > > If a package supports 3.2+, we remove information, and make the > dependency declaration incorrect, by changing it to 3.3+. > > Dependencies (particularly for python ports) are declarative, not > imperative, with the framework then deriving which lang/pythonXY ports > match, or are suitable. USES=python3.3+ was done by rm@ for removing Python 3.2 support. Correct me if I'm wrong. I removed PYTHON_REL check for its logical error. It should be "PYTHON_REL < 3300" for Python 3.2.x. Please note that: - PYTHON_REL == 3300: It is true only for Python 3.3.0 which was replaced by 3.3.1 on May, 2013 (r318353). - PYTHON_REL <= 3200: It is true only for Python 3.2.0 which was replaced by 3.2.1 on Apr, 2012 (r294647). Now Python 3.2 was gone. Regards, sunpoet > > do-test: > > - @cd ${WRKSRC} && ${PYTHON_CMD} -m pytest > > + cd ${WRKSRC}/ && ${PYTHON_CMD} -m pytest > > > > -.include > > +.include > > >