From owner-freebsd-current@FreeBSD.ORG Sat Aug 16 16:41:24 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 67A4E106567C for ; Sat, 16 Aug 2008 16:41:24 +0000 (UTC) (envelope-from rohit.trip@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.229]) by mx1.freebsd.org (Postfix) with ESMTP id 3303B8FC1C for ; Sat, 16 Aug 2008 16:41:24 +0000 (UTC) (envelope-from rohit.trip@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so2239780rvf.43 for ; Sat, 16 Aug 2008 09:41:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=f4OfKJQ+0phvDTplI6e4jaCFceAzuq3H4/h6WETuZac=; b=PelAYgF2FOVQTY+RnTEWyGdX7kwy0/Q/+3JKP2SXhpCCdQEcWs7y6k6Oou0IwffJnw YN1iWvgpX+3kLCOPADIJsRw7Go+kjMGr1eIDcxXt0UwcyMsxM0XRrDtC2sxuxDnNEOlm 9aV4lC4emZb35mbkafcAYqNdTygZg0QDZjkO0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=A7cFU79rsZiOcig60dc6897Es2EE9u1TBmo9gIR2KU9N37NqrGgYEForjrSCRzdbxn znkY47aOS4i3TNtV9XqGJiijPLd4DqHbIQJvl4rSG4yGk3wEA5VPfoP90YI/FH7cSMkV 9CDshuu0IM36C6+1/5wd5w3kk65ZR8jRdPxn4= Received: by 10.140.172.21 with SMTP id u21mr2222308rve.262.1218904883719; Sat, 16 Aug 2008 09:41:23 -0700 (PDT) Received: by 10.141.42.5 with HTTP; Sat, 16 Aug 2008 09:41:23 -0700 (PDT) Message-ID: <33615c8e0808160941p47d56e8anc0d666b34a8fbf41@mail.gmail.com> Date: Sat, 16 Aug 2008 12:41:23 -0400 From: "Rohit Tripathi" To: freebsd-current@freebsd.org In-Reply-To: <33615c8e0808160935r377566a2k3df1d256526f56f@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <33615c8e0808160935r377566a2k3df1d256526f56f@mail.gmail.com> Subject: Re: uninitialized "width" in st_parse.c ? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Aug 2008 16:41:24 -0000 Jumped the gun here, width need not be initialized: static char * number(char *cp, int *n) { char *next; *n = (int)strtol(cp, &next, 10); if (next == cp) expected("number", "", cp); return (next); } On Sat, Aug 16, 2008 at 12:35 PM, Rohit Tripathi wrote: > I found a build error under cddl/contrib/opensolaris/tools/ctf/cvt and > saw that width (line 779) was declared but not initialized. Is this > intentional? After setting it to 64 the build proceeded fine. > > -Rohit >