Date: Wed, 15 Jul 2015 10:47:21 +0000 From: "wma_semihalf.com (Wojciech Macek)" <phabric-noreply@FreeBSD.org> To: freebsd-arm@freebsd.org Subject: [Differential] [Commented On] D3093: ARMv8 locore.S cleanup and TCR register update Message-ID: <7c48c367946946db0109fa5f94d00c59@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-qvctvfcls3krqccl2a3p-req@FreeBSD.org> References: <differential-rev-PHID-DREV-qvctvfcls3krqccl2a3p-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
wma_semihalf.com added inline comments. INLINE COMMENTS sys/arm64/arm64/locore.S:48-52 You're right, I'll remove it prior submitting. sys/arm64/arm64/locore.S:191 It's the part of locore fixes described in the patch summary > - secondary stack calculation is modified to provide > stack_top = secondary_stacks + (cpu_id)*PAGE_SIZE*KSTACK_PAGES > because on ARMv8 the stack grows into lower memory addresses Please let me know if I should split this patch into two (include+stack and TCR reg) or leave as a one. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D3093 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: wma_semihalf.com, zbb, emaste, andrew Cc: imp, andrew, freebsd-arm-list, emaste
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7c48c367946946db0109fa5f94d00c59>