Date: Sun, 19 Jul 2015 10:17:50 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Zbigniew Bodek <zbb@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285627 - in head/sys: arm/arm arm/at91 arm/cavium/cns11xx arm/samsung/s3c2xx0 arm/xscale/i80321 arm/xscale/i8134x arm/xscale/ixp425 arm/xscale/pxa arm64/arm64 ddb i386/i386 powerpc/boo... Message-ID: <C0F44DA0-1D7A-4B33-8DE1-217229CCA4CD@FreeBSD.org> In-Reply-To: <201507161046.t6GAkrEt028784@repo.freebsd.org> References: <201507161046.t6GAkrEt028784@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 16 Jul 2015, at 10:46 , Zbigniew Bodek <zbb@freebsd.org> wrote: >=20 > Author: zbb > Date: Thu Jul 16 10:46:52 2015 > New Revision: 285627 > URL: https://svnweb.freebsd.org/changeset/base/285627 >=20 > Log: > Fix KSTACK_PAGES issue when the default value was changed in KERNCONF >=20 > If KSTACK_PAGES was changed to anything alse than the default, > the value from param.h was taken instead in some places and > the value from KENRCONF in some others. This resulted in > inconsistency which caused corruption in SMP envorinment. >=20 > Ensure all places where KSTACK_PAGES are used the opt_kstack_pages.h > is included. >=20 > The file opt_kstack_pages.h could not be included in param.h > because was breaking the toolchain compilation. >=20 > Reviewed by: kib > Obtained from: Semihalf > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D3094 Broke i386 (and pc98) LINT kernels: i386 LINT kernel failed, check _.i386.LINT for details i386 LINT-NOINET6 kernel failed, check _.i386.LINT-NOINET6 for details i386 LINT-NOINET kernel failed, check _.i386.LINT-NOINET for details pc98 LINT kernel failed, check _.pc98.LINT for details i386 LINT-NOIP kernel failed, check _.i386.LINT-NOIP for details i386 LINT-VIMAGE kernel failed, check _.i386.LINT-VIMAGE for details -------------------------------------------------------------- >>> stage 3.1: making dependencies -------------------------------------------------------------- In file included from = /scratch/tmp/bz/head.svn/sys/i386/i386/locore.s:57: ./assym.s:20:9: warning: 'KSTACK_PAGES' macro redefined = [-Wmacro-redefined] #define KSTACK_PAGES 0x3 ^ ./opt_kstack_pages.h:1:9: note: previous definition is here #define KSTACK_PAGES 3 ^ 1 warning generated. -------------------------------------------------------------- >>> stage 3.2: building everything -------------------------------------------------------------- In file included from = /scratch/tmp/bz/head.svn/sys/i386/i386/locore.s:57: ./assym.s:20:9: error: 'KSTACK_PAGES' macro redefined = [-Werror,-Wmacro-redefined] #define KSTACK_PAGES 0x3 ^ ./opt_kstack_pages.h:1:9: note: previous definition is here #define KSTACK_PAGES 3 ^ 1 error generated. --- locore.o --- *** [locore.o] Error code 1 bmake: stopped in = /storage/head/obj/i386.i386/scratch/tmp/bz/head.svn/sys/LINT =E2=80=94=20 Bjoern A. Zeeb Charles Haddon Spurgeon: "Friendship is one of the sweetest joys of life. Many might have failed beneath the bitterness of their trial had they not found a friend."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C0F44DA0-1D7A-4B33-8DE1-217229CCA4CD>