From owner-cvs-all Mon Apr 20 13:02:57 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA00805 for cvs-all-outgoing; Mon, 20 Apr 1998 13:02:57 -0700 (PDT) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from awfulhak.org (awfulhak.force9.co.uk [195.166.136.63]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id UAA00467; Mon, 20 Apr 1998 20:01:30 GMT (envelope-from brian@Awfulhak.org) Received: from gate.lan.awfulhak.org (localhost [127.0.0.1]) by awfulhak.org (8.8.8/8.8.8) with ESMTP id VAA14681; Mon, 20 Apr 1998 21:00:07 +0100 (BST) (envelope-from brian@gate.lan.awfulhak.org) Message-Id: <199804202000.VAA14681@awfulhak.org> X-Mailer: exmh version 2.0.1 12/23/97 To: Bruce Evans cc: brian@FreeBSD.ORG, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/ppp bundle.c fsm.c id.c ipcp.c lcp.c log.h lqr.c modem.c prompt.h sig.c slcompress.c timer.c In-reply-to: Your message of "Mon, 20 Apr 1998 15:04:24 +1000." <199804200504.PAA05579@godzilla.zeta.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 20 Apr 1998 21:00:07 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > >brian 1998/04/19 16:09:15 PDT > > > > Modified files: (Branch: MP) > > usr.sbin/ppp bundle.c fsm.c id.c ipcp.c lcp.c log.h > > lqr.c modem.c prompt.h sig.c slcompress.c > > timer.c > > Log: > > o Use __attribute__ (#ifdef __GNUC__) to type-check > > LogPrintf() and prompt_Printf(), and fix the bits > > identified as being wrong as a result. > > Ifdefing the use of __attribute__ is unnecessary because > already defines away __attribute__ (#if __GNUC__ < 2). > > Defining away __attribute__ is not quite right. Cases where __attribute__ > is used to change the semantics just become wrong if __attribute__ is > defined away. We currently avoid this problem by only using __attribute__ > for non-semantic things, but I want to use it to define nonstandard types > (see and the error output for building ncal as part of > `make world'). So should be included from my .h files ? It seems prone to error if I expect the .c to include it before the .h with __attribute__. > Bruce Cheers. -- Brian , , Don't _EVER_ lose your sense of humour.... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message