From owner-svn-src-all@freebsd.org Sat Jan 13 23:29:03 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2C888E5C404; Sat, 13 Jan 2018 23:29:03 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from d.mail.sonic.net (d.mail.sonic.net [64.142.111.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 174D67DC0A; Sat, 13 Jan 2018 23:29:02 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from comporellon.tachypleus.net (cpe-75-82-218-62.socal.res.rr.com [75.82.218.62]) (authenticated bits=0) by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPSA id w0DNT0Z7026221 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 13 Jan 2018 15:29:01 -0800 Subject: Re: svn commit: r327950 - in head/sys/powerpc: aim include powerpc ps3 To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201801132314.w0DNEra5002692@repo.freebsd.org> <20180113232441.GV1684@kib.kiev.ua> From: Nathan Whitehorn Message-ID: <010d0153-8931-a3c2-db21-dfcbaf848fc0@freebsd.org> Date: Sat, 13 Jan 2018 15:28:59 -0800 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180113232441.GV1684@kib.kiev.ua> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Sonic-CAuth: UmFuZG9tSVbXA+BLLZigOJRHWfOciRD1qWnBea3ivbeu37VDmTNKWd6NmXii/IMAku+B1kvN5NSbWIYwwAg5sW3o3SCH6Ar5dTfnp4UCecE= X-Sonic-ID: C;ai+XiLn45xGegeBQ9eIpJw== M;WBgaibn45xGegeBQ9eIpJw== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jan 2018 23:29:03 -0000 On 01/13/18 15:24, Konstantin Belousov wrote: > On Sat, Jan 13, 2018 at 11:14:53PM +0000, Nathan Whitehorn wrote: >> +/* >> + * We (usually) have a direct map of all physical memory. All >> + * uses of this macro must be gated by a check on hw_direct_map! >> + * The location of the direct map may not be 1:1 in future, so use >> + * of the macro is recommended; it may also grow an assert that hw_direct_map >> + * is set. >> + */ >> +#define PHYS_TO_DMAP(x) x >> +#define DMAP_TO_PHYS(x) x > Take a look at the sys/vm/vm_page.c:vm_page_free_prep() function. > I think the checks in there should work as designed, unless I'm missing something. Am I? -Nathan