From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Jan 17 11:20:21 2009 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 67533106568C for ; Sat, 17 Jan 2009 11:20:21 +0000 (UTC) (envelope-from akriventsov@masterhost.ru) Received: from csmtp-2.masterhost.ru (csmtp1.masterhost.ru [83.222.22.203]) by mx1.freebsd.org (Postfix) with SMTP id 82F908FC16 for ; Sat, 17 Jan 2009 11:20:19 +0000 (UTC) (envelope-from akriventsov@masterhost.ru) Received: (qmail 24064 invoked from network); 17 Jan 2009 10:53:36 -0000 Received: from unknown (HELO ?127.0.0.1?) (akriventsov@masterhost.ru@87.242.97.4) by csmtp1.masterhost.ru with SMTP; 17 Jan 2009 10:53:37 -0000 Message-ID: <4971B8B0.2020102@masterhost.ru> Date: Sat, 17 Jan 2009 13:53:36 +0300 From: Alexander Kriventsov Organization: .masterhost User-Agent: Thunderbird 2.0.0.18 (Windows/20081105) MIME-Version: 1.0 To: freebsd-ports-bugs@FreeBSD.org References: <200901171000.n0HA05Q1088116@freefall.freebsd.org> In-Reply-To: <200901171000.n0HA05Q1088116@freefall.freebsd.org> Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: Re: ports/130647: uninitialized value warning if you call running without an existing pid file X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: akriventsov@masterhost.ru List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Jan 2009 11:20:24 -0000 Sorry, correct patch is diff -r -u -B -N p5-File-Pid.orig/Makefile p5-File-Pid/Makefile --- p5-File-Pid.orig/Makefile 2008-04-17 14:25:25.000000000 +0000 +++ p5-File-Pid/Makefile 2009-01-17 10:48:03.613381790 +0000 @@ -7,6 +7,7 @@ PORTNAME= File-Pid PORTVERSION= 1.01 +PORTREVISION= 1 CATEGORIES= devel perl5 MASTER_SITES= CPAN PKGNAMEPREFIX= p5- @@ -21,4 +22,7 @@ MAN3= File::Pid.3 +post-patch: + ${RM} ${WRKSRC}/lib/File/Pid.pm.orig + .include diff -r -u -B -N p5-File-Pid.orig/files/patch-lib-File-Pid.pm p5-File-Pid/files/patch-lib-File-Pid.pm --- p5-File-Pid.orig/files/patch-lib-File-Pid.pm 1970-01-01 00:00:00.000000000 +0000 +++ p5-File-Pid/files/patch-lib-File-Pid.pm 2009-01-17 10:11:50.058553176 +0000 @@ -0,0 +1,11 @@ +--- lib/File/Pid.pm 2009-01-17 09:44:31.653906918 +0000 ++++ lib/File/Pid.pm 2009-01-17 09:44:01.397399415 +0000 +@@ -119,7 +119,7 @@ + + sub running { + my $self = shift; +- my $pid = $self->_get_pid_from_file; ++ my $pid = $self->_get_pid_from_file or return undef; + + return kill(0, $pid) + ? $pid -- Best Regards, Alexander Kriventsov .masterhost