From owner-cvs-src-old@FreeBSD.ORG Mon Jun 8 21:42:44 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DDA781065866 for ; Mon, 8 Jun 2009 21:42:44 +0000 (UTC) (envelope-from brian@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id CA9778FC17 for ; Mon, 8 Jun 2009 21:42:44 +0000 (UTC) (envelope-from brian@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n58LgiEh033360 for ; Mon, 8 Jun 2009 21:42:44 GMT (envelope-from brian@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n58Lgi2l033359 for cvs-src-old@freebsd.org; Mon, 8 Jun 2009 21:42:44 GMT (envelope-from brian@repoman.freebsd.org) Message-Id: <200906082142.n58Lgi2l033359@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to brian@repoman.freebsd.org using -f From: Brian Somers Date: Mon, 8 Jun 2009 21:42:30 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/dhclient dhclient.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jun 2009 21:42:45 -0000 brian 2009-06-08 21:42:30 UTC FreeBSD src repository Modified files: sbin/dhclient dhclient.c Log: SVN rev 193765 on 2009-06-08 21:42:30Z by brian Fix an off by one error when we limit append/prepend text sizes based on our internal buffer sizes. When we 'append', assume we're appending to text. Some MS dhcp servers will give us a string with the length including the trailing NUL. when we 'append domain-name', we get something like "search x.y\000 z" in resolv.conf :( MFC after: 1 week Security: A buffer overflow (by one NUL byte) was possible. Revision Changes Path 1.26 +15 -5 src/sbin/dhclient/dhclient.c