From owner-freebsd-gnome@FreeBSD.ORG Fri Feb 9 05:35:03 2007 Return-Path: X-Original-To: gnome@freebsd.org Delivered-To: freebsd-gnome@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 935E816A403 for ; Fri, 9 Feb 2007 05:35:03 +0000 (UTC) (envelope-from lofi@freebsd.org) Received: from mail-in-02.arcor-online.net (mail-in-02.arcor-online.net [151.189.21.42]) by mx1.freebsd.org (Postfix) with ESMTP id 11DE213C474 for ; Fri, 9 Feb 2007 05:35:03 +0000 (UTC) (envelope-from lofi@freebsd.org) Received: from mail-in-12-z2.arcor-online.net (mail-in-12-z2.arcor-online.net [151.189.8.29]) by mail-in-02.arcor-online.net (Postfix) with ESMTP id CAFB82D8298 for ; Fri, 9 Feb 2007 06:35:01 +0100 (CET) Received: from mail-in-03.arcor-online.net (mail-in-03.arcor-online.net [151.189.21.43]) by mail-in-12-z2.arcor-online.net (Postfix) with ESMTP id BC9C42793FC for ; Fri, 9 Feb 2007 06:35:01 +0100 (CET) Received: from lofi.dyndns.org (dslb-084-061-147-188.pools.arcor-ip.net [84.61.147.188]) by mail-in-03.arcor-online.net (Postfix) with ESMTP id 7A5AE275289 for ; Fri, 9 Feb 2007 06:35:01 +0100 (CET) Received: from kiste.my.domain (root@kiste.my.domain [192.168.8.2]) by lofi.dyndns.org (8.13.8/8.13.3) with ESMTP id l195YvZh086199 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 9 Feb 2007 06:34:57 +0100 (CET) (envelope-from lofi@freebsd.org) Received: from kiste.my.domain (lofi@localhost [127.0.0.1]) by kiste.my.domain (8.13.6/8.13.4) with ESMTP id l195Yubj001834 for ; Fri, 9 Feb 2007 06:34:56 +0100 (CET) (envelope-from lofi@freebsd.org) Received: from localhost (localhost [[UNIX: localhost]]) by kiste.my.domain (8.13.6/8.13.4/Submit) id l195YuGh001832 for gnome@freebsd.org; Fri, 9 Feb 2007 06:34:56 +0100 (CET) (envelope-from lofi@freebsd.org) X-Authentication-Warning: kiste.my.domain: lofi set sender to lofi@freebsd.org using -f From: Michael Nottebrock To: gnome@freebsd.org Date: Fri, 9 Feb 2007 06:34:52 +0100 User-Agent: KMail/1.9.5 X-Face: g:jG2\O{-yqD1x?DG2lU1)(v%xffR"p8Nz(w/*)YEUO\Hn%mGi&-!+rq$&r64,fuP~; bw\ ^QdX@v~HEAi?NaE8SU]}.oeYSjN84Fe{M(ahZ.(i+lxyP; pr)2[%mGbkY'RmM>+mg3Y$ip 1@Z>[EUaE7tjJ=1DRs~:!uSd""d~:/Er3rpQA%ze|bp>S MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1465408.CPW0nNF1jM"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200702090634.56455.lofi@freebsd.org> X-Virus-Scanned: by amavisd-new Cc: Subject: HAL on FreeBSD 5.5 redux X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2007 05:35:03 -0000 --nextPart1465408.CPW0nNF1jM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline While regression testing a few new patches for KDE's media kioslave, I foun= d=20 out that the FreeBSD 5.5 fix for cdroms as committed to ports doesn't=20 actually work - because of this code: /* Better to assert here than panic the machine. */ /* XXX Should this be a conditional? How likely is this? */ assert(cdrom->channel >=3D 0); assert(cdrom->device >=3D 0 && cdrom->device < 2); I don't know what this is supposed to do (avoid using both atapicam & atapi= cd=20 devices?), but it does prevent detection of any cdrom volumes here when=20 atapicam is disabled. I have two cd/dvd writers (acd0 and acd1) in this=20 machine.=20 I didn't notice this earlier because I skipped hal-0.5.8-20061224, but I di= d=20 go back to it now and can confirm that that version doesn't work either=20 unless those lines are removed. Cheers, =2D-=20 ,_, | Michael Nottebrock | lofi@freebsd.org (/^ ^\) | FreeBSD - The Power to Serve | http://www.freebsd.org \u/ | K Desktop Environment on FreeBSD | http://freebsd.kde.org --nextPart1465408.CPW0nNF1jM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQBFzAgAXhc68WspdLARAlSlAKCMBEl2iQKgMccqqgGJoDfGzfP8vACgq89p Ob4YTQe67Saal5kjm9da3u8= =RLJA -----END PGP SIGNATURE----- --nextPart1465408.CPW0nNF1jM--