From nobody Mon Jul 7 17:26:22 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bbWPV5FHKz60lBd; Mon, 07 Jul 2025 17:26:38 +0000 (UTC) (envelope-from rionda@gmail.com) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bbWPV34VTz3gDq; Mon, 07 Jul 2025 17:26:38 +0000 (UTC) (envelope-from rionda@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-x72b.google.com with SMTP id af79cd13be357-7d7f2600c17so217451885a.0; Mon, 07 Jul 2025 10:26:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751909197; x=1752513997; darn=freebsd.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=Pb4yEwnT4g5FCnSOXIP8RjpIViJLGGLdBKeIpY9MVo8=; b=Ubqf4S46MK39SMecRhFI46Ghx9MiZPdfKvKd9MpfSVAcfCKFoonG9dUD2sdFhXp9nW 8ZfYQ17Zn07Ly7DTkqbVstolHDLDJXXe3fKgAFSZpJWv5Hg6zEstaodBk4Ojk0917syo eUJOhYluQhAYCCkMrlrvqPgjcKxAqhj1Q5wklpcBlU2kc2+PztPGS5eyxTCWYV8BpoBD xqN9ICkcVNkaKqLhckEmFZ6QutlRdKfs8yUqQdOPkj/HZdRvT0JjzH9M/qTHc/IHb4/r fm9rBf28ZfOMcmJ/Pj5Te0RNua0FnSp/q7+RxQFB+34omVHLdazFIjr3FUQ7Dy9UCJPg QcvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751909197; x=1752513997; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Pb4yEwnT4g5FCnSOXIP8RjpIViJLGGLdBKeIpY9MVo8=; b=Y1xMVNImZQ1mjv6/hmQ1llReMgeFVaoRwu8Mp08AgpsLDNLADTPDe+lsBNTf74DMjt qd+T6m3Y7LkMDNWUhOnACD1XuBjgi4uOW2m6qBhZH4AXfDBp21FWQGVGDPqe2Em2j7qP AKEhK+k8nHSlL+t6+FaM/7LBxNH5TkmwQ1rwlIcy/69iG26hbxSa1GHWdNb5sTOgueGp woFKk8OpuKOCYNz+vwUTE5edXDcb3H2/UwcCV2xAn7gEbAL6wZJ3H5W4WF/iZAwUdrid HAWive+BaCT5H3kNKr1zPIOOlHcXXCOqRxKFXWxEGUxcYBhvIhXYelr0cBqIQYBnoIOD ZAvw== X-Forwarded-Encrypted: i=1; AJvYcCUZ4NU2I9UfzOc/c4pTHV/JLuaMFVXNZfzrBCnRdN/EYk46ct85zpC/oANsvGyAgs8I5JTiMCIcFUnRsU92nUTVRaxjqLE=@freebsd.org, AJvYcCVrKl3PIZrauVP9nlNW+pzoXmb+CaN3kG+C1yizzY9aceQv/PlmIqSSI+O++sQIbt3KFiaERB6KIY3D8F5Cs69U76Uv@freebsd.org X-Gm-Message-State: AOJu0YwjO4VX8mQGKen6Je0AHPSwIvaE9KpKyNrXBYADhAFsdMplBj/D h4r3kFSZ4AS0PRWHn544o4xDb3/DdrkOn4k3kvom4VdANg3Sbfl70H/oEHHT7Q== X-Gm-Gg: ASbGncspBgmEPLcIaZ2y1QNr8eRQ71zTF3knVbS452uKgWYttvyhkS7Tq/PN2RenVcN t3c3nC6GXymcmEa7ZPn2npyksmWvWsJxbJxo81L8Iz5dkd0Zg8ctHI6rq0E/e44TEgpCT1nITZM 0IZssted/eysbzhkM/XL+PUuczSv6+QsBCORAhqsFKh1bDOlSmr6OklDpSlW6A/+Uas+r1FP35Y 5e7uSf0JCK2zHsXW3MntkRuC1wzpuBIVlLwoQZkdv5WFzlm9Dveu+oprTtjZZggONO9dHQn7IwE 5rAkbvtMf7KcrIQCwryIZfHVCKkhfy3ku863iJaC7YL5RaxbETCz5OAE8IQV6F+CLPmGHcg+9bs oUpacAjQ9PNWEhw1tfl+ysg== X-Google-Smtp-Source: AGHT+IEjde+iIoRzeS61V2219AArRqdEj+uQPpRAiIiyNAabuiiC2PD+J/WVNZy38QpVvgnYw2+lvw== X-Received: by 2002:a05:620a:444c:b0:7d4:219:50d4 with SMTP id af79cd13be357-7d9ebaa4c91mr28818185a.34.1751909196517; Mon, 07 Jul 2025 10:26:36 -0700 (PDT) Received: from smtpclient.apple ([2607:fb91:daf:87b6:c1f9:c0be:2d0d:a56f]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d5dbe8f87fsm630718385a.80.2025.07.07.10.26.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Jul 2025 10:26:33 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6.1.11\)) Subject: Re: git: f8a8bb7bade9 - main - pfctl: Improve duplicate table name warning From: Matteo Riondato In-Reply-To: <202507071507.567F7n8Q016403@gitrepo.freebsd.org> Date: Mon, 7 Jul 2025 13:26:22 -0400 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <81D328A4-8A6C-44DA-861B-D3C067986CBE@FreeBSD.org> References: <202507071507.567F7n8Q016403@gitrepo.freebsd.org> To: Kristof Provost X-Mailer: Apple Mail (2.3731.700.6.1.11) X-Rspamd-Queue-Id: 4bbWPV34VTz3gDq X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] > On Jul 7, 2025, at 11:07 AM, Kristof Provost wrote: >=20 > The branch main has been updated by kp: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Df8a8bb7bade9575c549cbc94500ba706= b712c650 >=20 > commit f8a8bb7bade9575c549cbc94500ba706b712c650 > Author: Kristof Provost > AuthorDate: 2025-07-01 10:02:03 +0000 > Commit: Kristof Provost > CommitDate: 2025-07-07 15:06:48 +0000 >=20 > pfctl: Improve duplicate table name warning >=20 > When creating tables inside anchors, pfctl warned about namespace > collisions with global tables, but only in certain cases and with > limited information sometimes leaving users clueless. >=20 > Deferring the check to process_tabledefs() where tables are = eventually > created, both anchor and table name are known which allows for = checking > all existing anchors. >=20 > With this, warn on all duplicates even in dry-runs (`-n') and print > quoted names so they can be copied to fix configurations right = away. >=20 > No functional change in parsing or ruleset production. Based only on the commit message, this may fix PR #262295. Thanks, Matteo