From owner-svn-src-all@freebsd.org Fri Apr 15 21:45:48 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7C41CAED1AD; Fri, 15 Apr 2016 21:45:48 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0E7101462; Fri, 15 Apr 2016 21:45:47 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from localhost (localhost [127.0.0.1]) by woozle.rinet.ru (8.14.5/8.14.5) with ESMTP id u3FLjdTY023439; Sat, 16 Apr 2016 00:45:39 +0300 (MSK) (envelope-from marck@rinet.ru) Date: Sat, 16 Apr 2016 00:45:39 +0300 (MSK) From: Dmitry Morozovsky To: Warner Losh cc: Ronald Klop , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Warner Losh Subject: Re: svn commit: r298011 - head/sys/cam/ata In-Reply-To: <65ACB63B-ACDF-4552-BDA9-40FB028EB0D6@bsdimp.com> Message-ID: References: <201604142213.u3EMDklN061064@repo.freebsd.org> <65ACB63B-ACDF-4552-BDA9-40FB028EB0D6@bsdimp.com> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-NCC-RegID: ru.rinet X-OpenPGP-Key-ID: 6B691B03 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (woozle.rinet.ru [0.0.0.0]); Sat, 16 Apr 2016 00:45:40 +0300 (MSK) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2016 21:45:48 -0000 On Fri, 15 Apr 2016, Warner Losh wrote: > A shorter timeout dramatically cuts the length of time that the > queue has to be frozen for error recovery. This allows one, > in theory, to recover the system more quickly after a drive > goes off into the weeds. May be make some more generic changes? Could we detect SSD vs spinning disk vs unknown and set timeouts accordigly to the nature of the underlying device? > > Warner > > > > On Apr 15, 2016, at 9:23 AM, Ronald Klop wrote: > > > > Hello, > > > > Out of curiosity, what are these big problems? Broken device or other things (timeouts/triggers/full queues) going on in the kernel? > > > > Regards, > > Ronald. > > > > > > On Fri, 15 Apr 2016 00:13:46 +0200, Warner Losh wrote: > > > >> Author: imp > >> Date: Thu Apr 14 22:13:46 2016 > >> New Revision: 298011 > >> URL: https://svnweb.freebsd.org/changeset/base/298011 > >> erLog: > >> Add a comment about why the timeout for flush was lowered to 5s. > >> > >> Modified: > >> head/sys/cam/ata/ata_da.c > >> > >> Modified: head/sys/cam/ata/ata_da.c > >> ============================================================================== > >> --- head/sys/cam/ata/ata_da.c Thu Apr 14 22:13:44 2016 (r298010) > >> +++ head/sys/cam/ata/ata_da.c Thu Apr 14 22:13:46 2016 (r298011) > >> @@ -912,6 +912,11 @@ adadump(void *arg, void *virtual, vm_off > >> if (softc->flags & ADA_FLAG_CAN_FLUSHCACHE) { > >> xpt_setup_ccb(&ccb.ccb_h, periph->path, CAM_PRIORITY_NORMAL); > >> + /* > >> + * Tell the drive to flush its intenral cache. if we > >> + * can't flush in 5s we have big problems. No need to > >> + * wait the default 60s to detect problems. > >> + */ > >> ccb.ccb_h.ccb_state = ADA_CCB_DUMP; > >> cam_fill_ataio(&ccb.ataio, > >> 0, > >> _______________________________________________ > >> svn-src-all@freebsd.org mailing list > >> https://lists.freebsd.org/mailman/listinfo/svn-src-all > >> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > > -- Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] [ FreeBSD committer: marck@FreeBSD.org ] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------