From owner-svn-ports-all@freebsd.org  Thu Aug 16 10:16:03 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C9A8A10851FC;
 Thu, 16 Aug 2018 10:16:03 +0000 (UTC)
 (envelope-from meta@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 7CEFD7A9C0;
 Thu, 16 Aug 2018 10:16:03 +0000 (UTC)
 (envelope-from meta@FreeBSD.org)
Received: from icepick.vmeta.jp (unknown
 [IPv6:2405:6586:2280:1200:98f9:fc46:5676:d60e])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 (Authenticated sender: meta/mail)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 2F8621C7BC;
 Thu, 16 Aug 2018 10:16:02 +0000 (UTC)
 (envelope-from meta@FreeBSD.org)
Date: Thu, 16 Aug 2018 19:15:58 +0900
From: Koichiro Iwao <meta@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r477306 - in head: audio
 audio/pulseaudio-module-xrdp net/xrdp
Message-ID: <20180816101557.bd7q67be7coslnni@icepick.vmeta.jp>
References: <201808160151.w7G1p4A9025211@repo.freebsd.org>
 <20180816090702.ahk7s6da4e4sxqve@atuin.in.mat.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20180816090702.ahk7s6da4e4sxqve@atuin.in.mat.cc>
X-Operating-System: FreeBSD 11.2-STABLE amd64
User-Agent: NeoMutt/20180716
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Aug 2018 10:16:04 -0000

On Thu, Aug 16, 2018 at 11:07:02AM +0200, Mathieu Arnold wrote:
> On Thu, Aug 16, 2018 at 01:51:04AM +0000, Koichiro Iwao wrote:
> > +PORTNAME=	pulseaudio-module-xrdp
> > +PORTVERSION=	0.0.20180808
> 
> This is not the way to handle software that do not define versions.
> Please read this to learn how to handle this in the future:
> 
> https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex4

If the upstream really have the version like 0.0.YYYYmmdd, it it OK?

-- 
meta <meta@FreeBSD.org>