From owner-svn-src-head@FreeBSD.ORG Mon Mar 8 22:26:10 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 839E81065675; Mon, 8 Mar 2010 22:26:10 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 53CBD8FC1E; Mon, 8 Mar 2010 22:26:10 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 0684A46B09; Mon, 8 Mar 2010 17:26:10 -0500 (EST) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 4DB7E8A025; Mon, 8 Mar 2010 17:26:09 -0500 (EST) From: John Baldwin To: "Jung-uk Kim" Date: Mon, 8 Mar 2010 17:25:59 -0500 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) References: <201003081940.o28JeVG1088074@svn.freebsd.org> <201003081611.42854.jhb@freebsd.org> <201003081712.00635.jkim@FreeBSD.org> In-Reply-To: <201003081712.00635.jkim@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201003081725.59267.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 08 Mar 2010 17:26:09 -0500 (EST) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r204877 - head/sys/modules/acpi/acpi X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Mar 2010 22:26:10 -0000 On Monday 08 March 2010 5:11:42 pm Jung-uk Kim wrote: > On Monday 08 March 2010 04:11 pm, John Baldwin wrote: > > On Monday 08 March 2010 2:40:31 pm Jung-uk Kim wrote: > > > Author: jkim > > > Date: Mon Mar 8 19:40:31 2010 > > > New Revision: 204877 > > > URL: http://svn.freebsd.org/changeset/base/204877 > > > > > > Log: > > > Enable ACPI module build on amd64. Although we strongly > > > recommend building it into kernel, there is no need to prevent it > > > from building at all. > > > > (Oops, ignore previous spurious reply). > > > > Please revert this. The MADT parser on amd64 is slightly different > > from i386 and will not work when acpi is loaded as a module. If > > anything, I would prefer we make acpi not be a module on i386. > > There are several things that would be far less invasive to > > implement via #ifdef DEV_ACPI than by defining runtime kobj > > interfaces to the ACPI driver. > > madt.c itself is not very different but I understand what you are > trying to explain here. In fact, I tested it before committing and > the trick was adding mptable in place of acpi. It worked fine > although it may not be ideal. I can back out > sys/modules/acpi/Makefile change if you agree, however. It is different enough. Specifically, the amd64 one sets a "better" value for mp_maxid than i386, but it can only do this because it can run before SI_SUB_KLD since it is never invoked as a module. I still think that we should probably be moving away from acpi.ko rather than towards for other reasons. -- John Baldwin