From owner-freebsd-net@FreeBSD.ORG  Wed Dec 24 03:05:54 2008
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D446F1065674
	for <net@freebsd.org>; Wed, 24 Dec 2008 03:05:54 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id C15628FC14
	for <net@freebsd.org>; Wed, 24 Dec 2008 03:05:54 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id AAB861A3C3A; Tue, 23 Dec 2008 19:05:54 -0800 (PST)
Date: Tue, 23 Dec 2008 19:05:54 -0800
From: Alfred Perlstein <alfred@freebsd.org>
To: Doug Barton <dougb@FreeBSD.org>
Message-ID: <20081224030554.GX18389@elvis.mu.org>
References: <20081223001216.GH18389@elvis.mu.org>
	<alpine.BSF.2.00.0812231145340.1179@ync.qbhto.arg>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.BSF.2.00.0812231145340.1179@ync.qbhto.arg>
User-Agent: Mutt/1.4.2.3i
Cc: net@freebsd.org
Subject: Re: ipv6 bugfix, need review.
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Dec 2008 03:05:54 -0000

* Doug Barton <dougb@FreeBSD.org> [081223 11:46] wrote:
> On Mon, 22 Dec 2008, Alfred Perlstein wrote:
> 
> >Hey guys, we found a bug at Juniper and it resolves an issue
> >for us.  I've been asked to forward this to FreeBSD, I honestly
> >am not that clear on the issue so I'm hoping someone can step
> >up to review this.
> >
> >Synopsis is:
> >
> > The traffic class byte is set to 0x00000000 in the header of some
> > BGP packets sent between interfaces that have IPv6 addresses,
> > instead of the correct setting 0xc0 (INTERNETCONTROL).
> >
> >Fix is small and attached.  One thing I am wondering, do we
> >need to check "if (inp)" ?  I don't think so.
> 
> How about adding an assert to the patch to prove this theory? :)
> 
> I'll test it on my home box (which has IPv6) as soon as I'm done with the 
> stuff I'm working on atm.
> 
> 
> hth,
> 
> Doug

Thanks Doug, will do.

Please let me know results.  do you know how to test if this is
actually being excersized?  I guess you could add a sysctl that
gets incremented each time this codepath is hit to test?


-- 
- Alfred Perlstein