Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 1 Apr 2007 06:48:39 +1000 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        Robert Watson <rwatson@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/kern vfs_lookup.c
Message-ID:  <20070401064404.B9096@besplex.bde.org>
In-Reply-To: <200703311608.l2VG8oNE086672@repoman.freebsd.org>
References:  <200703311608.l2VG8oNE086672@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 31 Mar 2007, Robert Watson wrote:

> rwatson     2007-03-31 16:08:50 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/kern             vfs_lookup.c
>  Log:
>  Rather than ignoring any error return from getnewvnode() in nameiinit(),
>  explicitly test and panic.  This should not ever happen, but if it does,
>  this is a preferred failure mode to a NULL pointer dereference in kernel.

No, a null pointer dereference is far preferable since it takes less code
and is easier to debug.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070401064404.B9096>