From owner-cvs-src@FreeBSD.ORG Tue Sep 12 15:25:18 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CD6E416A47B; Tue, 12 Sep 2006 15:25:18 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id DDF6E43D45; Tue, 12 Sep 2006 15:25:17 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k8CFP9qe026766; Tue, 12 Sep 2006 11:25:10 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Ion-Mihai Tetcu Date: Tue, 12 Sep 2006 10:20:34 -0400 User-Agent: KMail/1.9.1 References: <200609112220.k8BMKbfG009489@repoman.freebsd.org> <20060912140105.22e7c9e3@it.buh.tecnik93.com> In-Reply-To: <20060912140105.22e7c9e3@it.buh.tecnik93.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200609121020.34783.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 12 Sep 2006 11:25:10 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/1871/Tue Sep 12 09:28:18 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/smbus smbus.c src/sys/kern bus_if.m X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2006 15:25:19 -0000 On Tuesday 12 September 2006 07:01, Ion-Mihai Tetcu wrote: > On Mon, 11 Sep 2006 22:20:37 +0000 (UTC) > John Baldwin wrote: > > > jhb 2006-09-11 22:20:37 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/smbus smbus.c > > sys/kern bus_if.m > > Log: > > - Revert making bus_generic_add_child() the default for > > BUS_ADD_CHILD(). Instead, we want busses to explicitly specify an > > add_child routine if they want to support identify routines, but by > > default disallow having outside drivers add devices. > > - Give smbus(4) an explicit bus_add_child() method. > > Might it have anything with this ? > > ===> i2c/controllers/viapm (all) > cc -O2 -pipe -DVIAPM_BASE_ADDR=0x6000 -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -std=c99 -nostdinc -I- -DHAVE_KERNEL_OPTION_HEADERS -include /usr/obj/usr/src/sys/ORION_U_P_O/opt_global.h -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common -g -I/usr/obj/usr/src/sys/ORION_U_P_O -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -fformat-extensions -c /usr/src/sys/modules/i2c/controllers/viapm/../../../../pci/viapm.c > In file included from /usr/src/sys/modules/i2c/controllers/viapm/../../../../pci/viapm.c:54: > @/dev/smbus/smbus.h:34: error: field `lock' has incomplete type > *** Error code 1 No, it would be the earlier commit. It compiled locally. I'll fix. -- John Baldwin