From nobody Sun Sep 10 11:51:43 2023 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rk7Vk1XSyz4sLsD for ; Sun, 10 Sep 2023 11:51:58 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rk7Vj5Y9mz4LXg for ; Sun, 10 Sep 2023 11:51:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-9a63b2793ecso437676566b.2 for ; Sun, 10 Sep 2023 04:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1694346716; x=1694951516; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1NWeWAfcSymsvvyk6ucufpv40BJ1XHQxginjnWDH6DQ=; b=R2oWC9UHJqu2Ce5s0ZKGvhmEis1Nm1QfqSbKIFUlAaHmsyKek92J3T0lMMo7nqBpxT qo1oi3ymCjzWsBRRQU9ZTJuIMsbqtZ9V6mAl9GQBnzs6pdQAOQWidRppMmn0rN9YoF7e Kto5piABQFjII274L1MiyocPr4oDJCdgNxUMw92K5LWOd1qk7NdcS3xweM1ecM7aBpVq p7L6Wtz4K7gkMw8LSlt/JQp3fWLTsCa6bNB3q9oZYDOLthjtMhBs89wc34GGg4j8+5FP vfRNw/UsBitXulpnnCOH1lEm69Fym7xkzPYB2B3mmeV1tg+vtQvRMqOPAv2uxlsGrh6V kAbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694346716; x=1694951516; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1NWeWAfcSymsvvyk6ucufpv40BJ1XHQxginjnWDH6DQ=; b=Z4L/ghhAisolCtGzULC95VvMHx9tf75EGqkdSO1eEoVlHUm+QO8AoQNGDCHq0+CMOO H9ckrMPXPJOoAmpWt7AHk9ess9d+/KKC+CPMPhEV0Jup9ygM4JkEcYudwiUMirJ4/BcR myXVVLNjZD3M+QB02gx/9OxHs2C0acLzPmOM4EEzdyZ9rx7HyKmS7iQRuPSfciONM43P TYAr/hViL3a0UEDHgG4z+ck+85F9AlpyAKm1Vh8pit14R3imw/Apn1luDUP3CeUgUjEa QgT8BpUJKVvKhsILkBmwP7S+ZMTOUuV7Pc3rx3bdHMKfP9Juo6lTJiwg0EEEDO9jPY5w 4p/A== X-Gm-Message-State: AOJu0Yzgz52bO0e/UW8gIp3I403gucg1LU1JKsnsfGypqfGqjVCGJBcE mRCFoV5tawGoLvxid3HFFlgfHyoRU0N1jLEJfZ5gTTqiCzut6F1D X-Google-Smtp-Source: AGHT+IFhBq3w+dotpLvVedCbYQvQWUluvOKRyDSv0XsPg6j5unZm/2WH31vK6ZdxufC9RRop5nX0oc2Fi81eSRsWzOo= X-Received: by 2002:a17:907:a071:b0:9aa:17c1:c41e with SMTP id ia17-20020a170907a07100b009aa17c1c41emr2540668ejc.29.1694346715137; Sun, 10 Sep 2023 04:51:55 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: <30a59ac0-28fd-f6ed-505c-9ef6d8e84fc3@tsoft.com> <86edj7qnia.fsf@ltc.des.no> In-Reply-To: From: Warner Losh Date: Sun, 10 Sep 2023 05:51:43 -0600 Message-ID: Subject: Re: sed in CURRENT fails in textproc/jq To: Robert Clausecker Cc: FreeBSD Current Content-Type: multipart/alternative; boundary="000000000000151a540604ffd64c" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4Rk7Vj5Y9mz4LXg --000000000000151a540604ffd64c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Sep 9, 2023, 10:51 PM Robert Clausecker wrote: > Greetings, > > I apologise for the inconvenience. The issue seems to boil down to > various places calling > > memchr(buf, c, SIZE_MAX); > > which causes an overflow when my newly written memchr() computes buf + > len to find the end of the buffer. A patch to alleviate this issue can > be found here: > > > http://fuz.su/~fuz/freebsd/0001-lib-libc-amd64-string-memchr.S-fix-behavi= our-with-ov.patch > > Please check if it does the trick for you. If yes, I'll go ahead and > push it tomorrow-ish. > There are half a dozen or do kyua tests that are likely failing because of this or other reasons related to strings. When you push this fix you'll get the list. They are hidden among about 80 or so networking tests that fail. I plan on disabling those tests soon If no one fixes them. Warner > > Yours, > Robert Clausecker > > Am Sat, Sep 09, 2023 at 07:12:29PM +0200 schrieb Dag-Erling Sm=C3=B8rgrav= : > > Antoine Brodin writes: > > > Yuri writes: > > > > Either something has changed in sed(1) in CURRENT, or sed just fail= s > > > > during the configure stage of textproc/jq: > > > > > > > > sed: No error: 0 > > > > checking for sys/cygwin.h... eval: ${+...}: Bad substitution > > > This seems to be a recent issue (less than 5 days). > > > Hundreds of configure scripts now fail to run on 15-current due to > > > this sed failure: [...] > > > > Try adding ARCHLEVEL=3Dscalar to CONFIGURE_ENV on one of these. If tha= t > > helps, yell at fuz@ :) > > > > DES > > -- > > Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org > > > > -- > () ascii ribbon campaign - for an 8-bit clean world > /\ - against html email - against proprietary attachments > > --000000000000151a540604ffd64c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sat, Sep 9, 2023, 10:51 PM Robert Clausecker <fuz@fuz.su> wrote:
Greetings,

I apologise for the inconvenience.=C2=A0 The issue seems to boil down to various places calling

=C2=A0 =C2=A0 memchr(buf, c, SIZE_MAX);

which causes an overflow when my newly written memchr() computes buf +
len to find the end of the buffer.=C2=A0 A patch to alleviate this issue ca= n
be found here:

=C2=A0 =C2=A0 http://fuz.su/~fuz/freebsd/0001-lib-libc-amd64-string-memchr= .S-fix-behaviour-with-ov.patch

Please check if it does the trick for you.=C2=A0 If yes, I'll go ahead = and
push it tomorrow-ish.


There are half a dozen or = do kyua tests that are likely failing because of this or other reasons rela= ted to strings.=C2=A0 When you push this fix you'll get the list. They = are hidden among about 80 or so networking tests that fail. I plan on disab= ling those tests soon If no one fixes them.

Warner=C2=A0

Yours,
Robert Clausecker

Am Sat, Sep 09, 2023 at 07:12:29PM +0200 schrieb Dag-Erling Sm=C3=B8rgrav:<= br> > Antoine Brodin <antoine@freebsd.org> writes:
> > Yuri <yuri@freebsd.org> writes:
> > > Either something has changed in sed(1) in CURRENT, or sed ju= st fails
> > > during the configure stage of textproc/jq:
> > >
> > > sed: No error: 0
> > > checking for sys/cygwin.h... eval: ${+...}: Bad substitution=
> > This seems to be a recent issue (less than 5 days).
> > Hundreds of configure scripts now fail to run on 15-current due t= o
> > this sed failure: [...]
>
> Try adding ARCHLEVEL=3Dscalar to CONFIGURE_ENV on one of these.=C2=A0 = If that
> helps, yell at fuz@ :)
>
> DES
> --
> Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org
>

--
()=C2=A0 ascii ribbon campaign - for an 8-bit clean world
/\=C2=A0 - against html email=C2=A0 - against proprietary attachments

--000000000000151a540604ffd64c--