From owner-cvs-ports@FreeBSD.ORG  Mon Jun 12 07:42:32 2006
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
X-Original-To: cvs-ports@FreeBSD.org
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1A7F316A41F;
	Mon, 12 Jun 2006 07:42:32 +0000 (UTC)
	(envelope-from sumikawa@alaxala.net)
Received: from pc1.alaxala.net (pc1.alaxala.net [203.178.142.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7AD3643D6B;
	Mon, 12 Jun 2006 07:42:29 +0000 (GMT)
	(envelope-from sumikawa@alaxala.net)
Received: from localhost (localhost [127.0.0.1])
	by pc1.alaxala.net (Postfix) with ESMTP id C3143B8EF;
	Mon, 12 Jun 2006 16:41:22 +0900 (JST)
Received: from pc1.alaxala.net ([127.0.0.1])
	by localhost (pc1.alaxala.net [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 73478-08; Mon, 12 Jun 2006 16:41:15 +0900 (JST)
Received: from localhost (pc2.alaxala.net [203.178.142.163])
	by pc1.alaxala.net (Postfix) with ESMTP id 3FC2EB834;
	Mon, 12 Jun 2006 16:41:15 +0900 (JST)
Date: Mon, 12 Jun 2006 16:22:36 +0900 (JST)
Message-Id: <20060612.162236.185148692.sumikawa@alaxala.net>
To: dougb@FreeBSD.org
From: Munechika SUMIKAWA / =?iso-2022-jp?B?GyRCM1FAbj0hNmEbKEI=?=
	<sumikawa@alaxala.net>
In-Reply-To: <44868860.1020706@FreeBSD.org>
References: <200606070733.k577XaTm091050@repoman.freebsd.org>
	<44868860.1020706@FreeBSD.org>
X-Mailer: Mew version 5.0.53 on Emacs 22.0.50 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: amavisd-new at alaxala.net
Cc: vivek@khera.org, sumikawa@FreeBSD.org, cvs-all@FreeBSD.org,
	ports-committers@FreeBSD.org, sumikawa@alaxala.net, cvs-ports@FreeBSD.org
Subject: Re: cvs commit: ports/security/racoon2 Makefile pkg-plist
 ports/security/racoon2/files patch-samples-Makefile.in
 patch-samples-rc.d-iked.in
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Jun 2006 07:42:32 -0000

> One problem, one suggestion. :)  First, what you really want to do is change
> rcvar:
> 
> rcvar=`set_rcvar`
> 
> Which will work on both FreeBSD and NetBSD. In FreeBSD you would be better
> off deleting the required_vars line (which I don't think is useful in NetBSD
> either, but I wouldn't swear to it).

I guess you are talking about the below change.

--- samples/rc.d-iked.in.orig   Fri Oct 28 15:33:16 2005
+++ samples/rc.d-iked.in        Wed Jun  7 16:03:18 2006
@@ -17,7 +17,7 @@
 rcvar=$name
 command="@sbindir@/${name}"
 extra_commands="reload"
-required_vars="spmd"
+required_vars="spmd_enable"
 pidfile="/var/run/${name}.pid"
 required_files="@sysconfdir@/racoon2.conf"
 reload_cmd="iked_reload"

What I wanted to do here is to confirm if spmd is starting up before
iked starts.  Because spmd is central daemon of raccon2 system and
iked can't start if spmd is not started.

> If I were you, I'd suggest both of these changes upstream.

Agreed.

-- Sumikawa