Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 25 Jan 2018 21:19:38 +0000 (UTC)
From:      Jan Beich <jbeich@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r459962 - head/www/waterfox/files
Message-ID:  <201801252119.w0PLJcDA087452@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jbeich
Date: Thu Jan 25 21:19:37 2018
New Revision: 459962
URL: https://svnweb.freebsd.org/changeset/ports/459962

Log:
  www/waterfox: unbreak with Rust 1.23
  
  error: unused import: `std::ascii::AsciiExt`
    --> servo/components/style/gecko_string_cache/mod.rs:16:5
     |
  16 | use std::ascii::AsciiExt;
     |     ^^^^^^^^^^^^^^^^^^^^
     |
  note: lint level defined here
    --> servo/components/style/lib.rs:26:9
     |
  26 | #![deny(warnings)]
     |         ^^^^^^^^
     = note: #[deny(unused_imports)] implied by #[deny(warnings)]
  
  https://users.rust-lang.org/t/psa-dealing-with-warning-unused-import-std-ascii-asciiext-in-today-s-nightly/13726
  
  Obtained from:	upstream

Added:
  head/www/waterfox/files/patch-servo19128   (contents, props changed)
  head/www/waterfox/files/patch-servo19162   (contents, props changed)

Added: head/www/waterfox/files/patch-servo19128
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/www/waterfox/files/patch-servo19128	Thu Jan 25 21:19:37 2018	(r459962)
@@ -0,0 +1,295 @@
+commit a6f7082122e9
+Author: Simon Sapin <simon.sapin@exyr.org>
+Date:   Thu Nov 9 10:00:38 2017 -0600
+
+    servo: Merge #19128 - Upgrade to rustc 1.23.0-nightly (02004ef78 2017-11-08) (from servo:asciiext); r=nox
+    
+    This fixes some new warnings, some of which (in `style`) are treated as errors. See https://users.rust-lang.org/t/psa-dealing-with-warning-unused-import-std-ascii-asciiext-in-today-s-nightly/13726
+    
+    Source-Repo: https://github.com/servo/servo
+    Source-Revision: c46c9dc019ffe5447297140c22cd8b6ee95a9f5f
+    
+    --HG--
+    extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
+    extra : subtree_revision : 49e4a180cd0d8ecdd48cd6896dc16b580f564e10
+---
+ servo/components/gfx/font.rs                          | 1 -
+ servo/components/net/fetch/cors_cache.rs              | 1 -
+ servo/components/net/fetch/methods.rs                 | 1 -
+ servo/components/net/http_loader.rs                   | 1 -
+ servo/components/net/websocket_loader.rs              | 1 -
+ servo/components/net_traits/response.rs               | 1 -
+ servo/components/script/dom/bindings/str.rs           | 1 -
+ servo/components/script/dom/blob.rs                   | 1 -
+ servo/components/script/dom/cssstyledeclaration.rs    | 1 -
+ servo/components/script/dom/document.rs               | 1 -
+ servo/components/script/dom/element.rs                | 1 -
+ servo/components/script/dom/htmlelement.rs            | 1 -
+ servo/components/script/dom/htmllinkelement.rs        | 1 -
+ servo/components/script/dom/htmlmetaelement.rs        | 1 -
+ servo/components/script/dom/htmlscriptelement.rs      | 1 -
+ servo/components/script/dom/macros.rs                 | 1 -
+ servo/components/script/dom/namednodemap.rs           | 1 -
+ servo/components/script/dom/serviceworkercontainer.rs | 1 -
+ servo/components/script/dom/servoparser/async_html.rs | 1 -
+ servo/components/script/dom/servoparser/mod.rs        | 1 -
+ servo/components/script/dom/textdecoder.rs            | 1 -
+ servo/components/script/dom/websocket.rs              | 1 -
+ servo/components/script/dom/window.rs                 | 1 -
+ servo/components/script/dom/xmlhttprequest.rs         | 1 -
+ servo/components/style/servo/selector_parser.rs       | 1 -
+ servo/rust-toolchain                                  | 2 +-
+ 26 files changed, 1 insertion(+), 26 deletions(-)
+
+diff --git servo/components/gfx/font.rs servo/components/gfx/font.rs
+index 357f61a2d7ab..acf98e6f9e9a 100644
+--- servo/components/gfx/font.rs
++++ servo/components/gfx/font.rs
+@@ -10,7 +10,6 @@ use platform::font::{FontHandle, FontTable};
+ use platform::font_context::FontContextHandle;
+ use platform::font_template::FontTemplateData;
+ use smallvec::SmallVec;
+-use std::ascii::AsciiExt;
+ use std::borrow::ToOwned;
+ use std::cell::RefCell;
+ use std::collections::HashMap;
+diff --git servo/components/net/fetch/cors_cache.rs servo/components/net/fetch/cors_cache.rs
+index 6c30782453d5..8962dd2c9985 100644
+--- servo/components/net/fetch/cors_cache.rs
++++ servo/components/net/fetch/cors_cache.rs
+@@ -12,7 +12,6 @@
+ use hyper::method::Method;
+ use net_traits::request::{CredentialsMode, Origin, Request};
+ use servo_url::ServoUrl;
+-use std::ascii::AsciiExt;
+ use time::{self, Timespec};
+ 
+ /// Union type for CORS cache entries
+diff --git servo/components/net/websocket_loader.rs servo/components/net/websocket_loader.rs
+index 71178bbc7d93..f2d36b4fdae9 100644
+--- servo/components/net/websocket_loader.rs
++++ servo/components/net/websocket_loader.rs
+@@ -19,7 +19,6 @@ use net_traits::{CookieSource, MessageData, NetworkError, WebSocketCommunicate,
+ use net_traits::{WebSocketDomAction, WebSocketNetworkEvent};
+ use net_traits::request::{Destination, Type};
+ use servo_url::ServoUrl;
+-use std::ascii::AsciiExt;
+ use std::io::{self, Write};
+ use std::net::TcpStream;
+ use std::sync::{Arc, Mutex};
+diff --git servo/components/net_traits/response.rs servo/components/net_traits/response.rs
+index 74525a85f07b..a7699d8ad911 100644
+--- servo/components/net_traits/response.rs
++++ servo/components/net_traits/response.rs
+@@ -9,7 +9,6 @@ use hyper::header::{AccessControlExposeHeaders, ContentType, Headers};
+ use hyper::status::StatusCode;
+ use hyper_serde::Serde;
+ use servo_url::ServoUrl;
+-use std::ascii::AsciiExt;
+ use std::sync::{Arc, Mutex};
+ 
+ /// [Response type](https://fetch.spec.whatwg.org/#concept-response-type)
+diff --git servo/components/script/dom/bindings/str.rs servo/components/script/dom/bindings/str.rs
+index 761acab30682..e2c91a1f5061 100644
+--- servo/components/script/dom/bindings/str.rs
++++ servo/components/script/dom/bindings/str.rs
+@@ -7,7 +7,6 @@
+ use cssparser::CowRcStr;
+ use html5ever::{LocalName, Namespace};
+ use servo_atoms::Atom;
+-use std::ascii::AsciiExt;
+ use std::borrow::{Borrow, Cow, ToOwned};
+ use std::fmt;
+ use std::hash::{Hash, Hasher};
+diff --git servo/components/script/dom/cssstyledeclaration.rs servo/components/script/dom/cssstyledeclaration.rs
+index 0732c9af9e45..c70f081922bf 100644
+--- servo/components/script/dom/cssstyledeclaration.rs
++++ servo/components/script/dom/cssstyledeclaration.rs
+@@ -16,7 +16,6 @@ use dom::window::Window;
+ use dom_struct::dom_struct;
+ use servo_arc::Arc;
+ use servo_url::ServoUrl;
+-use std::ascii::AsciiExt;
+ use style::attr::AttrValue;
+ use style::properties::{Importance, PropertyDeclarationBlock, PropertyId, LonghandId, ShorthandId};
+ use style::properties::{parse_one_declaration_into, parse_style_attribute, SourcePropertyDeclaration};
+diff --git servo/components/script/dom/document.rs servo/components/script/dom/document.rs
+index 90ea06fbe7b4..4fe244b47b74 100644
+--- servo/components/script/dom/document.rs
++++ servo/components/script/dom/document.rs
+@@ -122,7 +122,6 @@ use servo_arc::Arc;
+ use servo_atoms::Atom;
+ use servo_config::prefs::PREFS;
+ use servo_url::{ImmutableOrigin, MutableOrigin, ServoUrl};
+-use std::ascii::AsciiExt;
+ use std::borrow::ToOwned;
+ use std::cell::{Cell, Ref, RefMut};
+ use std::collections::{HashMap, HashSet, VecDeque};
+diff --git servo/components/script/dom/element.rs servo/components/script/dom/element.rs
+index 59db577c4eb3..ea7567020b97 100644
+--- servo/components/script/dom/element.rs
++++ servo/components/script/dom/element.rs
+@@ -95,7 +95,6 @@ use selectors::matching::{RelevantLinkStatus, matches_selector_list};
+ use selectors::sink::Push;
+ use servo_arc::Arc;
+ use servo_atoms::Atom;
+-use std::ascii::AsciiExt;
+ use std::borrow::Cow;
+ use std::cell::{Cell, Ref};
+ use std::convert::TryFrom;
+diff --git servo/components/script/dom/htmlelement.rs servo/components/script/dom/htmlelement.rs
+index 59846595166a..eb1f1022c8b7 100644
+--- servo/components/script/dom/htmlelement.rs
++++ servo/components/script/dom/htmlelement.rs
+@@ -31,7 +31,6 @@ use dom::nodelist::NodeList;
+ use dom::virtualmethods::VirtualMethods;
+ use dom_struct::dom_struct;
+ use html5ever::{LocalName, Prefix};
+-use std::ascii::AsciiExt;
+ use std::borrow::ToOwned;
+ use std::default::Default;
+ use std::rc::Rc;
+diff --git servo/components/script/dom/htmllinkelement.rs servo/components/script/dom/htmllinkelement.rs
+index 8175da5c913c..5da65a49d34d 100644
+--- servo/components/script/dom/htmllinkelement.rs
++++ servo/components/script/dom/htmllinkelement.rs
+@@ -27,7 +27,6 @@ use net_traits::ReferrerPolicy;
+ use script_layout_interface::message::Msg;
+ use script_traits::{MozBrowserEvent, ScriptMsg as ConstellationMsg};
+ use servo_arc::Arc;
+-use std::ascii::AsciiExt;
+ use std::borrow::ToOwned;
+ use std::cell::Cell;
+ use std::default::Default;
+diff --git servo/components/script/dom/htmlmetaelement.rs servo/components/script/dom/htmlmetaelement.rs
+index 9370675eb6bd..dc3ee9aa12de 100644
+--- servo/components/script/dom/htmlmetaelement.rs
++++ servo/components/script/dom/htmlmetaelement.rs
+@@ -22,7 +22,6 @@ use html5ever::{LocalName, Prefix};
+ use parking_lot::RwLock;
+ use servo_arc::Arc;
+ use servo_config::prefs::PREFS;
+-use std::ascii::AsciiExt;
+ use std::sync::atomic::AtomicBool;
+ use style::attr::AttrValue;
+ use style::media_queries::MediaList;
+diff --git servo/components/script/dom/htmlscriptelement.rs servo/components/script/dom/htmlscriptelement.rs
+index ea0cc4c25e8e..f5f758060525 100644
+--- servo/components/script/dom/htmlscriptelement.rs
++++ servo/components/script/dom/htmlscriptelement.rs
+@@ -36,7 +36,6 @@ use network_listener::{NetworkListener, PreInvoke};
+ use servo_atoms::Atom;
+ use servo_config::opts;
+ use servo_url::ServoUrl;
+-use std::ascii::AsciiExt;
+ use std::cell::Cell;
+ use std::fs::File;
+ use std::io::{Read, Write};
+diff --git servo/components/script/dom/macros.rs servo/components/script/dom/macros.rs
+index a1bb30657252..9cd5fb9a8dc5 100644
+--- servo/components/script/dom/macros.rs
++++ servo/components/script/dom/macros.rs
+@@ -149,7 +149,6 @@ macro_rules! make_enumerated_getter(
+         fn $attr(&self) -> DOMString {
+             use dom::bindings::inheritance::Castable;
+             use dom::element::Element;
+-            use std::ascii::AsciiExt;
+             let element = self.upcast::<Element>();
+             let mut val = element.get_string_attribute(&local_name!($htmlname));
+             val.make_ascii_lowercase();
+diff --git servo/components/script/dom/namednodemap.rs servo/components/script/dom/namednodemap.rs
+index 9d92bf11c2d2..4f1b13a999e8 100644
+--- servo/components/script/dom/namednodemap.rs
++++ servo/components/script/dom/namednodemap.rs
+@@ -15,7 +15,6 @@ use dom::element::Element;
+ use dom::window::Window;
+ use dom_struct::dom_struct;
+ use html5ever::LocalName;
+-use std::ascii::AsciiExt;
+ 
+ #[dom_struct]
+ pub struct NamedNodeMap {
+diff --git servo/components/script/dom/serviceworkercontainer.rs servo/components/script/dom/serviceworkercontainer.rs
+index ba2e327409f1..3a0ed0fcb253 100644
+--- servo/components/script/dom/serviceworkercontainer.rs
++++ servo/components/script/dom/serviceworkercontainer.rs
+@@ -16,7 +16,6 @@ use dom::serviceworker::ServiceWorker;
+ use dom_struct::dom_struct;
+ use script_thread::ScriptThread;
+ use serviceworkerjob::{Job, JobType};
+-use std::ascii::AsciiExt;
+ use std::default::Default;
+ use std::rc::Rc;
+ 
+diff --git servo/components/script/dom/servoparser/async_html.rs servo/components/script/dom/servoparser/async_html.rs
+index 59411fda1c73..f9e3bf48c378 100644
+--- servo/components/script/dom/servoparser/async_html.rs
++++ servo/components/script/dom/servoparser/async_html.rs
+@@ -27,7 +27,6 @@ use html5ever::tokenizer::{Tokenizer as HtmlTokenizer, TokenizerOpts, TokenizerR
+ use html5ever::tree_builder::{ElementFlags, NodeOrText as HtmlNodeOrText, NextParserState, QuirksMode, TreeSink};
+ use html5ever::tree_builder::{TreeBuilder, TreeBuilderOpts};
+ use servo_url::ServoUrl;
+-use std::ascii::AsciiExt;
+ use std::borrow::Cow;
+ use std::cell::Cell;
+ use std::collections::HashMap;
+diff --git servo/components/script/dom/servoparser/mod.rs servo/components/script/dom/servoparser/mod.rs
+index 6a5a723111da..bb8b066c2439 100644
+--- servo/components/script/dom/servoparser/mod.rs
++++ servo/components/script/dom/servoparser/mod.rs
+@@ -46,7 +46,6 @@ use script_traits::DocumentActivity;
+ use servo_config::prefs::PREFS;
+ use servo_config::resource_files::read_resource_file;
+ use servo_url::ServoUrl;
+-use std::ascii::AsciiExt;
+ use std::borrow::Cow;
+ use std::cell::Cell;
+ use std::mem;
+diff --git servo/components/script/dom/websocket.rs servo/components/script/dom/websocket.rs
+index b533789e6118..80febbe72fe4 100644
+--- servo/components/script/dom/websocket.rs
++++ servo/components/script/dom/websocket.rs
+@@ -34,7 +34,6 @@ use script_runtime::CommonScriptMsg;
+ use script_runtime::ScriptThreadEventCategory::WebSocketEvent;
+ use script_thread::{Runnable, RunnableWrapper};
+ use servo_url::ServoUrl;
+-use std::ascii::AsciiExt;
+ use std::borrow::ToOwned;
+ use std::cell::Cell;
+ use std::ptr;
+diff --git servo/components/script/dom/window.rs servo/components/script/dom/window.rs
+index 3c87e5f6b0b4..d10d2131dc5a 100644
+--- servo/components/script/dom/window.rs
++++ servo/components/script/dom/window.rs
+@@ -88,7 +88,6 @@ use servo_config::opts;
+ use servo_config::prefs::PREFS;
+ use servo_geometry::{f32_rect_to_au_rect, max_rect};
+ use servo_url::{Host, MutableOrigin, ImmutableOrigin, ServoUrl};
+-use std::ascii::AsciiExt;
+ use std::borrow::ToOwned;
+ use std::cell::Cell;
+ use std::collections::{HashMap, HashSet};
+diff --git servo/components/script/dom/xmlhttprequest.rs servo/components/script/dom/xmlhttprequest.rs
+index 6ed2dda1851f..e8902f6133c5 100644
+--- servo/components/script/dom/xmlhttprequest.rs
++++ servo/components/script/dom/xmlhttprequest.rs
+@@ -63,7 +63,6 @@ use script_traits::DocumentActivity;
+ use servo_atoms::Atom;
+ use servo_config::prefs::PREFS;
+ use servo_url::ServoUrl;
+-use std::ascii::AsciiExt;
+ use std::borrow::ToOwned;
+ use std::cell::Cell;
+ use std::default::Default;
+diff --git servo/components/style/servo/selector_parser.rs servo/components/style/servo/selector_parser.rs
+index 95ef6b0169f5..d205c4ee1170 100644
+--- servo/components/style/servo/selector_parser.rs
++++ servo/components/style/servo/selector_parser.rs
+@@ -21,7 +21,6 @@ use selectors::Element;
+ use selectors::attr::{AttrSelectorOperation, NamespaceConstraint, CaseSensitivity};
+ use selectors::parser::{SelectorMethods, SelectorParseError};
+ use selectors::visitor::SelectorVisitor;
+-use std::ascii::AsciiExt;
+ use std::fmt;
+ use std::fmt::Debug;
+ use std::mem;

Added: head/www/waterfox/files/patch-servo19162
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/www/waterfox/files/patch-servo19162	Thu Jan 25 21:19:37 2018	(r459962)
@@ -0,0 +1,331 @@
+commit cf341df19ad7
+Author: Simon Sapin <simon.sapin@exyr.org>
+Date:   Thu Nov 9 06:49:29 2017 -0600
+
+    servo: Merge #19162 - Allow unused imports for AsciiExt in style code (from emilio:ascii-ext); r=emilio
+    
+    See #19128, this part is cherry-picked so Gecko can build with rust nightly.
+    
+    Source-Repo: https://github.com/servo/servo
+    Source-Revision: e7a654dd13f589e127193267bcb576ffd661c11d
+    
+    --HG--
+    extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
+    extra : subtree_revision : 0ee67ddf598b1ea99e92f6a285a960f86b1cb971
+---
+ servo/components/selectors/attr.rs                                  | 2 +-
+ servo/components/selectors/parser.rs                                | 2 +-
+ servo/components/style/attr.rs                                      | 2 +-
+ servo/components/style/counter_style/mod.rs                         | 2 +-
+ servo/components/style/custom_properties.rs                         | 2 +-
+ servo/components/style/gecko/generated/pseudo_element_definition.rs | 4 ++--
+ servo/components/style/gecko/pseudo_element_definition.mako.rs      | 4 ++--
+ servo/components/style/gecko_string_cache/mod.rs                    | 2 +-
+ servo/components/style/properties/longhand/font.mako.rs             | 2 +-
+ servo/components/style/properties/longhand/pointing.mako.rs         | 2 +-
+ servo/components/style/str.rs                                       | 2 +-
+ servo/components/style/stylesheets/viewport_rule.rs                 | 2 +-
+ servo/components/style/values/mod.rs                                | 2 +-
+ servo/components/style/values/specified/align.rs                    | 2 +-
+ servo/components/style/values/specified/angle.rs                    | 2 +-
+ servo/components/style/values/specified/calc.rs                     | 2 +-
+ servo/components/style/values/specified/grid.rs                     | 2 +-
+ servo/components/style/values/specified/length.rs                   | 2 +-
+ servo/components/style/values/specified/mod.rs                      | 2 +-
+ servo/components/style/values/specified/percentage.rs               | 2 +-
+ servo/components/style/values/specified/text.rs                     | 2 +-
+ servo/components/style/values/specified/time.rs                     | 2 +-
+ servo/components/style_traits/viewport.rs                           | 2 +-
+ 23 files changed, 25 insertions(+), 25 deletions(-)
+
+diff --git servo/components/selectors/attr.rs servo/components/selectors/attr.rs
+index b71be2cca73b..577b52eb26ab 100644
+--- servo/components/selectors/attr.rs
++++ servo/components/selectors/attr.rs
+@@ -4,7 +4,7 @@
+ 
+ use cssparser::ToCss;
+ use parser::SelectorImpl;
+-use std::ascii::AsciiExt;
++#[allow(unused_imports)] use std::ascii::AsciiExt;
+ use std::fmt;
+ 
+ #[derive(Eq, PartialEq, Clone)]
+diff --git servo/components/selectors/parser.rs servo/components/selectors/parser.rs
+index 490399ce38ce..a6c58179e110 100644
+--- servo/components/selectors/parser.rs
++++ servo/components/selectors/parser.rs
+@@ -13,7 +13,7 @@ use precomputed_hash::PrecomputedHash;
+ use servo_arc::ThinArc;
+ use sink::Push;
+ use smallvec::SmallVec;
+-use std::ascii::AsciiExt;
++#[allow(unused_imports)] use std::ascii::AsciiExt;
+ use std::borrow::{Borrow, Cow};
+ use std::fmt::{self, Display, Debug, Write};
+ use std::iter::Rev;
+diff --git servo/components/style/attr.rs servo/components/style/attr.rs
+index 9861c4360f98..e34d03f01823 100644
+--- servo/components/style/attr.rs
++++ servo/components/style/attr.rs
+@@ -16,7 +16,7 @@ use selectors::attr::AttrSelectorOperation;
+ use servo_arc::Arc;
+ use servo_url::ServoUrl;
+ use shared_lock::Locked;
+-use std::ascii::AsciiExt;
++#[allow(unused_imports)] use std::ascii::AsciiExt;
+ use std::str::FromStr;
+ use str::{HTML_SPACE_CHARACTERS, read_exponent, read_fraction};
+ use str::{read_numbers, split_commas, split_html_space_chars};
+diff --git servo/components/style/counter_style/mod.rs servo/components/style/counter_style/mod.rs
+index 1eb47fedf516..6b55364bca96 100644
+--- servo/components/style/counter_style/mod.rs
++++ servo/components/style/counter_style/mod.rs
+@@ -15,7 +15,7 @@ use error_reporting::ContextualParseError;
+ use parser::{ParserContext, log_css_error, Parse};
+ use selectors::parser::SelectorParseError;
+ use shared_lock::{SharedRwLockReadGuard, ToCssWithGuard};
+-use std::ascii::AsciiExt;
++#[allow(unused_imports)] use std::ascii::AsciiExt;
+ use std::borrow::Cow;
+ use std::fmt;
+ use std::ops::Range;
+diff --git servo/components/style/custom_properties.rs servo/components/style/custom_properties.rs
+index cb9e39561846..787dfaadf82c 100644
+--- servo/components/style/custom_properties.rs
++++ servo/components/style/custom_properties.rs
+@@ -12,7 +12,7 @@ use parser::ParserContext;
+ use properties::{CSSWideKeyword, DeclaredValue};
+ use selectors::parser::SelectorParseError;
+ use servo_arc::Arc;
+-use std::ascii::AsciiExt;
++#[allow(unused_imports)] use std::ascii::AsciiExt;
+ use std::borrow::Cow;
+ use std::collections::{HashMap, hash_map, HashSet};
+ use std::fmt;
+diff --git servo/components/style/gecko/generated/pseudo_element_definition.rs servo/components/style/gecko/generated/pseudo_element_definition.rs
+index 46da69d1e9b6..1cb2bf9f3e1d 100644
+--- servo/components/style/gecko/generated/pseudo_element_definition.rs
++++ servo/components/style/gecko/generated/pseudo_element_definition.rs
+@@ -1182,7 +1182,7 @@ impl PseudoElement {
+     /// Returns `None` if the pseudo-element is not recognised.
+     #[inline]
+     pub fn from_slice(s: &str, in_ua_stylesheet: bool) -> Option<Self> {
+-        use std::ascii::AsciiExt;
++        #[allow(unused_imports)] use std::ascii::AsciiExt;
+ 
+         // We don't need to support tree pseudos because functional
+         // pseudo-elements needs arguments, and thus should be created
+@@ -1552,7 +1552,7 @@ impl PseudoElement {
+     /// Returns `None` if the pseudo-element is not recognized.
+     #[inline]
+     pub fn tree_pseudo_element(name: &str, args: Box<[String]>) -> Option<Self> {
+-        use std::ascii::AsciiExt;
++        #[allow(unused_imports)] use std::ascii::AsciiExt;
+         debug_assert!(name.starts_with("-moz-tree-"));
+         let tree_part = &name[10..];
+             if tree_part.eq_ignore_ascii_case("column") {
+diff --git servo/components/style/gecko/pseudo_element_definition.mako.rs servo/components/style/gecko/pseudo_element_definition.mako.rs
+index e4a5025314b6..d676cb9f0491 100644
+--- servo/components/style/gecko/pseudo_element_definition.mako.rs
++++ servo/components/style/gecko/pseudo_element_definition.mako.rs
+@@ -171,7 +171,7 @@ impl PseudoElement {
+     /// Returns `None` if the pseudo-element is not recognised.
+     #[inline]
+     pub fn from_slice(s: &str, in_ua_stylesheet: bool) -> Option<Self> {
+-        use std::ascii::AsciiExt;
++        #[allow(unused_imports)] use std::ascii::AsciiExt;
+ 
+         // We don't need to support tree pseudos because functional
+         // pseudo-elements needs arguments, and thus should be created
+@@ -193,7 +193,7 @@ impl PseudoElement {
+     /// Returns `None` if the pseudo-element is not recognized.
+     #[inline]
+     pub fn tree_pseudo_element(name: &str, args: Box<[String]>) -> Option<Self> {
+-        use std::ascii::AsciiExt;
++        #[allow(unused_imports)] use std::ascii::AsciiExt;
+         debug_assert!(name.starts_with("-moz-tree-"));
+         let tree_part = &name[10..];
+         % for pseudo in TREE_PSEUDOS:
+diff --git servo/components/style/gecko_string_cache/mod.rs servo/components/style/gecko_string_cache/mod.rs
+index fed06fbeec5d..726bbc8631ca 100644
+--- servo/components/style/gecko_string_cache/mod.rs
++++ servo/components/style/gecko_string_cache/mod.rs
+@@ -13,7 +13,7 @@ use gecko_bindings::bindings::Gecko_ReleaseAtom;
+ use gecko_bindings::structs::nsIAtom;
+ use nsstring::{nsAString, nsString};
+ use precomputed_hash::PrecomputedHash;
+-use std::ascii::AsciiExt;
++#[allow(unused_imports)] use std::ascii::AsciiExt;
+ use std::borrow::{Cow, Borrow};
+ use std::char::{self, DecodeUtf16};
+ use std::fmt::{self, Write};
+diff --git servo/components/style/media_queries.rs servo/components/style/media_queries.rs
+index 5f71ddf974fb..6667f16f3585 100644
+--- servo/components/style/media_queries.rs
++++ servo/components/style/media_queries.rs
+@@ -12,7 +12,7 @@ use cssparser::{Delimiter, Parser, Token, ParserInput};
+ use parser::ParserContext;
+ use selectors::parser::SelectorParseError;
+ use serialize_comma_separated_list;
+-use std::ascii::AsciiExt;
++#[allow(unused_imports)] use std::ascii::AsciiExt;
+ use std::fmt;
+ use style_traits::{ToCss, ParseError, StyleParseError};
+ 
+diff --git servo/components/style/properties/longhand/font.mako.rs servo/components/style/properties/longhand/font.mako.rs
+index f6b78a917498..093c6c1009e7 100644
+--- servo/components/style/properties/longhand/font.mako.rs
++++ servo/components/style/properties/longhand/font.mako.rs
+@@ -2096,7 +2096,7 @@ https://drafts.csswg.org/css-fonts-4/#low-level-font-variation-settings-control-
+ 
+         #[inline]
+         fn to_computed_value(&self, _context: &Context) -> computed_value::T {
+-            use std::ascii::AsciiExt;
++            #[allow(unused_imports)] use std::ascii::AsciiExt;
+             match *self {
+                 SpecifiedValue::Normal => computed_value::T(0),
+                 SpecifiedValue::Override(ref lang) => {
+diff --git servo/components/style/properties/longhand/pointing.mako.rs servo/components/style/properties/longhand/pointing.mako.rs
+index 9e7923889b17..132e62501647 100644
+--- servo/components/style/properties/longhand/pointing.mako.rs
++++ servo/components/style/properties/longhand/pointing.mako.rs
+@@ -93,7 +93,7 @@
+     impl Parse for computed_value::Keyword {
+         fn parse<'i, 't>(_context: &ParserContext, input: &mut Parser<'i, 't>)
+                          -> Result<computed_value::Keyword, ParseError<'i>> {
+-            use std::ascii::AsciiExt;
++            #[allow(unused_imports)] use std::ascii::AsciiExt;
+             use style_traits::cursor::Cursor;
+             let ident = input.expect_ident()?;
+             if ident.eq_ignore_ascii_case("auto") {
+diff --git servo/components/style/str.rs servo/components/style/str.rs
+index 92febb408249..e4ba90d6435e 100644
+--- servo/components/style/str.rs
++++ servo/components/style/str.rs
+@@ -7,7 +7,7 @@
+ #![deny(missing_docs)]
+ 
+ use num_traits::ToPrimitive;
+-use std::ascii::AsciiExt;
++#[allow(unused_imports)] use std::ascii::AsciiExt;
+ use std::convert::AsRef;
+ use std::iter::{Filter, Peekable};
+ use std::str::Split;
+diff --git servo/components/style/stylesheets/viewport_rule.rs servo/components/style/stylesheets/viewport_rule.rs
+index 7d3339a92148..ad57415cbc90 100644
+--- servo/components/style/stylesheets/viewport_rule.rs
++++ servo/components/style/stylesheets/viewport_rule.rs
+@@ -19,7 +19,7 @@ use parser::{Parse, ParserContext, log_css_error};
+ use properties::StyleBuilder;
+ use selectors::parser::SelectorParseError;
+ use shared_lock::{SharedRwLockReadGuard, ToCssWithGuard};
+-use std::ascii::AsciiExt;
++#[allow(unused_imports)] use std::ascii::AsciiExt;
+ use std::borrow::Cow;
+ use std::fmt;
+ use std::iter::Enumerate;
+diff --git servo/components/style/values/mod.rs servo/components/style/values/mod.rs
+index 616aa5cb4852..0ea4759ff23e 100644
+--- servo/components/style/values/mod.rs
++++ servo/components/style/values/mod.rs
+@@ -12,7 +12,7 @@ use Atom;
+ pub use cssparser::{RGBA, Token, Parser, serialize_identifier, BasicParseError, CowRcStr};
+ use parser::{Parse, ParserContext};
+ use selectors::parser::SelectorParseError;
+-use std::ascii::AsciiExt;
++#[allow(unused_imports)] use std::ascii::AsciiExt;
+ use std::fmt::{self, Debug};
+ use std::hash;
+ use style_traits::{ToCss, ParseError, StyleParseError};
+diff --git servo/components/style/values/specified/align.rs servo/components/style/values/specified/align.rs
+index dc7fd43ed941..10da78904e2b 100644
+--- servo/components/style/values/specified/align.rs
++++ servo/components/style/values/specified/align.rs
+@@ -10,7 +10,7 @@ use cssparser::Parser;
+ use gecko_bindings::structs;
+ use parser::{Parse, ParserContext};
+ use selectors::parser::SelectorParseError;
+-use std::ascii::AsciiExt;
++#[allow(unused_imports)] use std::ascii::AsciiExt;
+ use std::fmt;
+ use style_traits::{ToCss, ParseError, StyleParseError};
+ 
+diff --git servo/components/style/values/specified/calc.rs servo/components/style/values/specified/calc.rs
+index 66b94b20ad01..58d12fe0147e 100644
+--- servo/components/style/values/specified/calc.rs
++++ servo/components/style/values/specified/calc.rs
+@@ -9,7 +9,7 @@
+ use app_units::Au;
+ use cssparser::{Parser, Token, BasicParseError};
+ use parser::ParserContext;
+-use std::ascii::AsciiExt;
++#[allow(unused_imports)] use std::ascii::AsciiExt;
+ use std::fmt;
+ use style_traits::{HasViewportPercentage, ToCss, ParseError, StyleParseError};
+ use style_traits::values::specified::AllowedLengthType;
+diff --git servo/components/style/values/specified/grid.rs servo/components/style/values/specified/grid.rs
+index beb1459e76dc..927b8c912935 100644
+--- servo/components/style/values/specified/grid.rs
++++ servo/components/style/values/specified/grid.rs
+@@ -7,7 +7,7 @@
+ 
+ use cssparser::{Parser, Token, BasicParseError};
+ use parser::{Parse, ParserContext};
+-use std::ascii::AsciiExt;
++#[allow(unused_imports)] use std::ascii::AsciiExt;
+ use std::mem;
+ use style_traits::{HasViewportPercentage, ParseError, StyleParseError};
+ use values::{CSSFloat, CustomIdent};
+diff --git servo/components/style/values/specified/length.rs servo/components/style/values/specified/length.rs
+index bf4b83b52932..2514b2aaca89 100644
+--- servo/components/style/values/specified/length.rs
++++ servo/components/style/values/specified/length.rs
+@@ -12,7 +12,7 @@ use euclid::Size2D;
+ use font_metrics::FontMetricsQueryResult;
+ use parser::{Parse, ParserContext};
+ use std::{cmp, fmt, mem};
+-use std::ascii::AsciiExt;
++#[allow(unused_imports)] use std::ascii::AsciiExt;
+ use std::ops::Mul;
+ use style_traits::{HasViewportPercentage, ToCss, ParseError, StyleParseError};
+ use style_traits::values::specified::{AllowedLengthType, AllowedNumericType};
+diff --git servo/components/style/values/specified/mod.rs servo/components/style/values/specified/mod.rs
+index 7c51c3868f8a..8fbdc827829a 100644
+--- servo/components/style/values/specified/mod.rs
++++ servo/components/style/values/specified/mod.rs
+@@ -11,7 +11,7 @@ use context::QuirksMode;
+ use cssparser::{Parser, Token, serialize_identifier, BasicParseError};
+ use parser::{ParserContext, Parse};
+ use self::url::SpecifiedUrl;
+-use std::ascii::AsciiExt;
++#[allow(unused_imports)] use std::ascii::AsciiExt;
+ use std::f32;
+ use std::fmt;
+ use style_traits::{ToCss, ParseError, StyleParseError};
+diff --git servo/components/style/values/specified/text.rs servo/components/style/values/specified/text.rs
+index 2c0395128c64..c3248a7bc45d 100644
+--- servo/components/style/values/specified/text.rs
++++ servo/components/style/values/specified/text.rs
+@@ -7,7 +7,7 @@
+ use cssparser::Parser;
+ use parser::{Parse, ParserContext};
+ use selectors::parser::SelectorParseError;
+-use std::ascii::AsciiExt;
++#[allow(unused_imports)] use std::ascii::AsciiExt;
+ use style_traits::ParseError;
+ use values::computed::{Context, ToComputedValue};
+ use values::computed::text::LineHeight as ComputedLineHeight;
+diff --git servo/components/style_traits/viewport.rs servo/components/style_traits/viewport.rs
+index 01d9b541ac34..e25ff9ba9e71 100644
+--- servo/components/style_traits/viewport.rs
++++ servo/components/style_traits/viewport.rs
+@@ -7,7 +7,7 @@
+ use {CSSPixel, PinchZoomFactor, ParseError};
+ use cssparser::{Parser, ToCss, ParseError as CssParseError, BasicParseError};
+ use euclid::TypedSize2D;
+-use std::ascii::AsciiExt;
++#[allow(unused_imports)] use std::ascii::AsciiExt;
+ use std::fmt;
+ 
+ define_css_keyword_enum!(UserZoom:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201801252119.w0PLJcDA087452>