From owner-cvs-all@FreeBSD.ORG  Thu Feb 26 18:46:49 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C7A0616A4CE
	for <cvs-all@FreeBSD.org>; Thu, 26 Feb 2004 18:46:49 -0800 (PST)
Received: from mailhub1.midco.net (mailhub1.midco.net [24.220.0.32])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7368B43D2F
	for <cvs-all@FreeBSD.org>; Thu, 26 Feb 2004 18:46:49 -0800 (PST)
	(envelope-from pmes@bis.midco.net)
Received: (qmail 18757 invoked by uid 0); 27 Feb 2004 02:46:49 -0000
Received: from host-195-219-220-24.midco.net (HELO bis.midco.net)
	([24.220.219.195])          (envelope-sender <pmes@bis.midco.net>)
	by lvs-pop.midco.net (qmail-ldap-1.03) with SMTP
	for <kris@obsecurity.org>; 27 Feb 2004 02:46:49 -0000
Message-ID: <403EAF98.7080009@bis.midco.net>
Date: Thu, 26 Feb 2004 20:46:48 -0600
From: Peter Schultz <pmes@bis.midco.net>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7a) Gecko/20040226
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Kris Kennaway <kris@obsecurity.org>
References: <200402251000.i1PA0nGn056196@repoman.freebsd.org>
	<403E0B90.9040106@bis.midco.net> <20040226203351.GB5915@xor.obsecurity.org>
	<403EA170.9080100@bis.midco.net> <20040227015101.GA10403@xor.obsecurity.org>
In-Reply-To: <20040227015101.GA10403@xor.obsecurity.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: jkoshy@FreeBSD.org
cc: ports-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: cvs-ports@FreeBSD.org
Subject: Re: cvs commit: ports/graphics/xaos Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Feb 2004 02:46:49 -0000

Kris Kennaway wrote:
> On Thu, Feb 26, 2004 at 07:46:24PM -0600, Peter Schultz wrote:
> 
> 
>>>>+ .if defined(WITH_THREADS)
>>>>+ CONFIGURE_ARGS+= --with-pthread=yes
>>>>+ .endif
>>>>+ 
>>>
>>>
>>>And does this do the right thing with PTHREAD_{CFLAGS,LIBS} on 4.x and 5.x?
>>>
>>>Kris
>>
>>I'm not sure, I copied the functionality from the textproc/libxml2 
>>Makefile.  I'm only assuming it "Just Works".  What should I be looking 
>>out for?
> 
> 
> Set PTHREAD_LIBS='-DNOP -lpthread' PTHREAD_CFLAGS='-DNOP2' or similar
> and verify that they're showing up correctly in the build log.
> 

I'm not getting the point of this.  If I `make -DWITH_THREADS' after 
this patch, xaos is built and linked properly:

cc -DHAVE_SYS_PARAM_H  -I/usr/local/include  -pipe -O6 -fstrength-reduce 
-ffast-math -fomit-frame-pointer -fforce-mem -fforce-addr -funroll-loops 
-D_REENTRANT -I/usr/include/ncurses   -I/usr/X11R6/include 
-I/usr/local/include  -I/usr/X11R6/include 
-I/usr/ports/graphics/xaos/work/XaoS-3.0/src/include -L/usr/local/lib -o 
/usr/ports/graphics/xaos/work/XaoS-3.0/bin/xaos lib/libui.a 
lib/libengine.a  lib/libutil.a  lib/libfilter.a  lib/libuiaa.a 
lib/libuix11.a -lpng -lz -lm -laa -lncurses -lpthread 
-L/usr/X11R6/lib   -L/usr/X11R6/lib -lX11   -L/usr/X11R6/lib -lX11 
-L/usr/local/lib -L/usr/local/lib -lXext   -L/usr/X11R6/lib -lX11

What is -DNOP?  Why doesn't textproc/libxml2 require this?

Pete...