From owner-cvs-all@FreeBSD.ORG Sat May 3 14:04:48 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2476D37B404; Sat, 3 May 2003 14:04:47 -0700 (PDT) Received: from thalia.otenet.gr (mailsrv.otenet.gr [195.170.0.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8056143F3F; Sat, 3 May 2003 14:04:46 -0700 (PDT) (envelope-from keramida@ceid.upatras.gr) Received: from gothmog.gr (patr530-b207.otenet.gr [212.205.244.215]) by thalia.otenet.gr (8.12.9/8.12.9) with ESMTP id h43L4hmX023526; Sun, 4 May 2003 00:04:43 +0300 (EEST) Received: from gothmog.gr (gothmog [127.0.0.1]) by gothmog.gr (8.12.9/8.12.9) with ESMTP id h43L4goP004473; Sun, 4 May 2003 00:04:42 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) Received: (from giorgos@localhost) by gothmog.gr (8.12.9/8.12.9/Submit) id h43L4g91004472; Sun, 4 May 2003 00:04:42 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) Date: Sun, 4 May 2003 00:04:42 +0300 From: Giorgos Keramidas To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20030503210442.GC3907@gothmog.gr> References: <200305031639.h43GdYQ4049867@repoman.freebsd.org> <20030503205500.GB3907@gothmog.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030503205500.GB3907@gothmog.gr> Subject: Re: cvs commit: src/bin/ls extern.h ls.c print.c util.c src/bin/pax ar_io.c ar_subs.c cache.c cpio.c extern.h gen_subs.c getoldopt.c options.c pat_rep.c pax.c pax.h src/bin/ps fmt.c src/bin/rcp rcp.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 May 2003 21:04:48 -0000 On 2003-05-03 23:55, Giorgos Keramidas wrote: > On 2003-05-03 09:39, Mark Murray wrote: > > Modified files: > > bin/ls extern.h ls.c print.c util.c > > [...] > > Log: > > Fix a bazillion warnings. This makes almost the whole of src/bin/* > > WARNS=6, std=c99 clean. > > Now that you mentioned src/bin/... > FWIW, my recent buildworlds break at bin/ps. > > [...] > Index: bin/ps/Makefile > =================================================================== > RCS file: /home/ncvs/src/bin/ps/Makefile,v > retrieving revision 1.23 > diff -u -r1.23 Makefile > --- bin/ps/Makefile 2 May 2003 01:05:05 -0000 1.23 > +++ bin/ps/Makefile 3 May 2003 11:24:16 -0000 > @@ -9,7 +9,7 @@ > # keep ps from being an unnecessary load > # on large systems. > # > -WARNS= 1 > +WARNS= 0 > WFORMAT=0 > CFLAGS+=-DLAZY_PS > DPADD= ${LIBM} ${LIBKVM} An alternative is to fix the warnings by using different strftime() formats, but I'm not sure if this changes the output format of ps output. Could someone with more ps(1)-foo test this? With this change ps(1) builds with any WARNS level up to 5 here :-) %%% Index: Makefile =================================================================== RCS file: /home/ncvs/src/bin/ps/Makefile,v retrieving revision 1.23 diff -u -r1.23 Makefile --- Makefile 2 May 2003 01:05:05 -0000 1.23 +++ Makefile 3 May 2003 21:04:19 -0000 @@ -9,7 +9,7 @@ # keep ps from being an unnecessary load # on large systems. # -WARNS= 1 +WARNS?= 5 WFORMAT=0 CFLAGS+=-DLAZY_PS DPADD= ${LIBM} ${LIBKVM} Index: print.c =================================================================== RCS file: /home/ncvs/src/bin/ps/print.c,v retrieving revision 1.82 diff -u -r1.82 print.c --- print.c 15 Apr 2003 18:49:20 -0000 1.82 +++ print.c 3 May 2003 20:59:25 -0000 @@ -402,7 +402,7 @@ (void)strftime(buf, sizeof(buf), use_ampm ? "%a%I%p" : "%a%H ", tp); } else - (void)strftime(buf, sizeof(buf), "%e%b%y", tp); + (void)strftime(buf, sizeof(buf), "%e%b%Y", tp); (void)printf("%-*s", v->width, buf); } @@ -419,7 +419,7 @@ return; } then = k->ki_p->ki_start.tv_sec; - (void)strftime(buf, sizeof(buf), "%c", localtime(&then)); + (void)strftime(buf, sizeof(buf), "%a %b %e %T %Y", localtime(&then)); (void)printf("%-*s", v->width, buf); } %%%