From owner-p4-projects@FreeBSD.ORG  Sun Dec 28 05:30:48 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 7164316A4D0; Sun, 28 Dec 2003 05:30:48 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2CE0E16A4CE
	for <perforce@freebsd.org>; Sun, 28 Dec 2003 05:30:48 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 55F5643D2F
	for <perforce@freebsd.org>; Sun, 28 Dec 2003 05:30:47 -0800 (PST)
	(envelope-from jmallett@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id hBSDUl0B041131
	for <perforce@freebsd.org>; Sun, 28 Dec 2003 05:30:47 -0800 (PST)
	(envelope-from jmallett@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.10/8.12.10/Submit) id hBSDUkUZ041128
	for perforce@freebsd.org; Sun, 28 Dec 2003 05:30:46 -0800 (PST)
	(envelope-from jmallett@freebsd.org)
Date: Sun, 28 Dec 2003 05:30:46 -0800 (PST)
Message-Id: <200312281330.hBSDUkUZ041128@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jmallett@freebsd.org using -f
From: Juli Mallett <jmallett@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 44447 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Dec 2003 13:30:48 -0000

http://perforce.freebsd.org/chv.cgi?CH=44447

Change 44447 by jmallett@jmallett_oingo on 2003/12/28 05:30:15

	Maybe dirty PTEs coming in TLBMod is OK after all...

Affected files ...

.. //depot/projects/mips/sys/mips/mips/tlb.c#17 edit

Differences ...

==== //depot/projects/mips/sys/mips/mips/tlb.c#17 (text+ko) ====

@@ -237,8 +237,19 @@
 		panic("write to invalid page");
 	if (pte_ro(pte))
 		panic("write to ro page");
+
+ 	/*
+	 * XXX I don't like these, but it looks like the fact of the
+	 * matter is that they happen, for example I have something in
+	 * front of me right now where the even side of the buffer is
+	 * dirty, and so is the odd side, but in the buffer, the left
+	 * side is marked, and there's some reason why a reload didn't
+	 * happen, so just let it go... let it go...
+	 */
+#if 0
 	if (pte_dirty(pte))
 		panic("dirty page caused a TLBMod");
+#endif
 
 	/*
 	 * Mark the page dirty.