From owner-svn-ports-all@freebsd.org Thu Oct 8 11:24:50 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 01B603FD8B0; Thu, 8 Oct 2020 11:24:50 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from mail.anongoth.pl (mail.anongoth.pl [46.248.190.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X448 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "anongoth.pl", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C6TPs24QFz3f7X; Thu, 8 Oct 2020 11:24:49 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from anongoth.pl (unknown [192.168.1.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: pkubaj@anongoth.pl) by mail.anongoth.pl (Postfix) with ESMTPSA id B2955A2134; Thu, 8 Oct 2020 13:24:45 +0200 (CEST) Date: Thu, 8 Oct 2020 13:24:44 +0200 From: Piotr Kubaj To: Adam Weinberger Cc: ports-committers , svn-ports-all , svn-ports-head Subject: Re: svn commit: r551634 - head/databases/postgresql13-server Message-ID: <20201008112444.GA30140@KGPE-D16> References: <202010071306.097D6JOj080863@repo.freebsd.org> <20201008102448.GA35539@KGPE-D16> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6c2NcOVqGQ03X4Wi" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4C6TPs24QFz3f7X X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.85 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEFALL_USER(0.00)[pkubaj]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:46.248.190.61:c]; RCVD_TLS_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; MID_RHS_NOT_FQDN(0.50)[]; NEURAL_HAM_LONG(-1.05)[-1.049]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.40)[-0.397]; DMARC_POLICY_ALLOW(-0.50)[anongoth.pl,reject]; NEURAL_HAM_MEDIUM(-1.01)[-1.009]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:47544, ipnet:46.248.160.0/19, country:PL]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[svn-ports-all,svn-ports-head] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2020 11:24:50 -0000 --6c2NcOVqGQ03X4Wi Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 20-10-08 04:34:47, Adam Weinberger wrote: > On Thu, Oct 8, 2020 at 4:24 AM Piotr Kubaj wrote: > > > > It was previously committed in https://svnweb.freebsd.org/ports?view=3D= revision&revision=3D527871 and it seemed to work. Or is it that just no one= noticed it? > > > > I'm trying to understand why this issue appeared and how to fix it with= out reverting to the previous (also broken) behaviour. >=20 > The problem happens because of the extra level of indirection. The > ${CHOSEN_COMPILER_TYPE} causes it to be evaluated too late, > overwriting PORT_OPTIONS. >=20 > As to why it wasn't happening before, I'm not sure. Why not just > exclude it on gcc archs instead? > OPTIONS_DEFINE=3D ... LLVM > OPTIONS_EXCLUDE_fooarch=3D LLVM That wouldn't work. There are no architectures that use base GCC on head, b= ecause base GCC was removed. So it should be excluded on 11 and 12, but it = should also be enabled on 13. So ideally, it would need to be something like BROKEN: BROKEN_FreeBSD_12_powerpc64=3D I'll look whether something like this works: OPTIONS_EXCLUDE_powerpc64=3D ${OPTIONS_EXCLUDE_powerpc64_${OSREL:R}} OPTIONS_EXCLUDE_powerpc64_12=3D LLVM >=20 > I can certainly appreciate the clever approach you're taking here, but > it's apparently too clever for options.mk. >=20 > # Adam >=20 >=20 > > On 20-10-08 04:11:05, Adam Weinberger wrote: > > > On Wed, Oct 7, 2020 at 7:06 AM Piotr Kubaj wrote: > > > > > > > > Author: pkubaj > > > > Date: Wed Oct 7 13:06:19 2020 > > > > New Revision: 551634 > > > > URL: https://svnweb.freebsd.org/changeset/ports/551634 > > > > > > > > Log: > > > > databases/postgresql13-server: fix build on GCC architectures > > > > > > > > Add the previously removed disabling of LLVM when it's not in bas= e. > > > > > > > > > > +OPTIONS_DEFAULT+=3D ${OPTIONS_DEFAULT_${CHOSEN_COMPILER_TYPE}} > > > > +OPTIONS_DEFAULT_clang=3D LLVM > > > > > > This forces the LLVM option on for all clang users, and prevents it > > > from ever getting turned off. Please, turn the LLVM forcing off. >=20 >=20 > --=20 > Adam Weinberger > adamw@adamw.org > https://www.adamw.org --6c2NcOVqGQ03X4Wi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAl9+9vwACgkQelmbhSCD nJ2TpQ//XSedJ1TMf1TxRJdjU1P/4qPe8TwgiwFz54bZ5vyt745NWtaN+iBRWplh +vz5Z3s+nRidq6zlRZnqBF4KIbGVOyY0GQu43NOheHMgft1RuQdTKSKOYrmtI4VQ myxQ5K2XJHUA7z+Gdgbn8DPOy4uCaKp34b2cbVs/FBKgndF6hDN1uxIOEHCY1L47 pKR1AHedyhm17Mvd0m1Dq517xIjoGxQTmQ7HYNNp0F8JmrgtIpe89TBEpcYexLMq ztaoZZ6XvoEOhS2m+shZfpq/YqS/7LtUj49WLpt4f3afg4qESu8ZJQjtAnADjcfy kX7sJig2Lo7j7a2Ob0NXuzyMLa8yb8uV3SVX5IlWfXC7v+Lqr5u4YkYMquqCVjaI TiFGtkMIKDQlh+2FE2ccGiM6TR2t+HbSPzSfExa+h6+v4mHeGDOisuFyV0s6ghy7 EUvIVJ1iOh21uHOFNRao9ECQCpxUAn8IBi0q7BditpnShv6PhU7cHk3Tg1QmqRgz SI9zdtP8W/6E0utEqtLXMNjmuQ3qTXLFdKqJBy8P30+ocmPyHSonEpzfHQaE0LGb 1NztmIdJgkqWNU3aLK1gvnUhRmpcvlt2xhwWOtbwjT2onHKZuSM5sy2yIKeR5dEP IPnjwdw+vRe6p0cTzMeK2xhYPpsXE1srXpq+ukv4BeTBYhtsuaw= =0mct -----END PGP SIGNATURE----- --6c2NcOVqGQ03X4Wi--