From nobody Fri Jan 19 13:50:23 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TGgwv2nqLz56XNC; Fri, 19 Jan 2024 13:50:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TGgwv2G9Dz4q4X; Fri, 19 Jan 2024 13:50:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705672223; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fPH39f5ZEW9/3MMHKJOqQ2mpfjeeCB+K07lzGw+2YGA=; b=vOgyKmeyCRKWcr7BHnJfPbTVbIhxm63v0vV9+sNVqE6OV8FkKsHV8wQhZJM2IYI8L8+z7w LKbqoVWeZPjdoKQqL5lBnIArdlDt4sr58OjHiQfgplYrI2P6tMilnmoLmmuLsXvZgLqbko JvylM7wJ2LjbcyKyusIjulX1DzmBWY0xY9Px4++WOkGOY5fX5IQ022c5SJXDKwabmmMuQU 9eVgkqz8qaVFYvan+LqZnDsszQj7tMtN1j+gBINEaZqgz1jU4NMaUyT6JtEhP5NzVFKafa HDHRkfgg22C03qAZWSEE7F23FiepOE6p4K1qksQdE7KWeziFvdcsiDSOlyD4lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705672223; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fPH39f5ZEW9/3MMHKJOqQ2mpfjeeCB+K07lzGw+2YGA=; b=nRYwUw3fDiMAZJUBsG2KtwhNsbi/rzu8De5pfowneJwYcRYMPx7jcq2rgv+jZUZiz1/dN7 CeD2X7GrmuO9frjM2qz78XnXPIy37xMZMy6My/wPR4i6sEs9UkykPhEhWNec619XHuhbLi gP+fhX9QBCbWR9gAR8EyiGk//UXjwOQRFWQvpiJGeSr2XhIPOxtQmnrvcEx0wmzYGPUNAK BznLpVuO8qxOLLTVqVVjIbZgWqB/TcI0Y88+qTRRsiPOL+FoFFppvveE7aezN3ZH1syUMe ATn8YXklH7GPo/bVj+DKes/tn+C03SGZ4ETsHWA25zBXUsR9JFJea0dryugSRA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1705672223; a=rsa-sha256; cv=none; b=SWXskMn1/XF+yVyywl7Olb2p/PczAACW4k/YKh4y4CYnbQkwqRyiduS2ueclQ1U12/Or+b Mp0Ed4LXTdqiw7zLBlQs15um3HWIpwqP5xVWYHI5aSc6Ox9xQW3C6DJK3ZRLwoEPNJd1td AuPjAg0fWu8r3CyVlS0GPTiEO/sZNp75tBjsoei1piwxvcrKAFHeou+VZ8+8FIwpPXUXaG 3u72bhdBFeYi6uJt5JrOC9H3gxppLMC6uj89Xd2d4lgeWP8hNOFEj+Xo1eHYslxP+/DPhz x6WOp0hu3Z8AdgFPFYVVTB1HNkppY3YIq+3pMifzdsY6pDpOFAImEAEo9CpU/w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TGgwv1JvPztHF; Fri, 19 Jan 2024 13:50:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 40JDoNeg046705; Fri, 19 Jan 2024 13:50:23 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 40JDoNfu046703; Fri, 19 Jan 2024 13:50:23 GMT (envelope-from git) Date: Fri, 19 Jan 2024 13:50:23 GMT Message-Id: <202401191350.40JDoNfu046703@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Richard Scheffenegger Subject: git: dfe30e41967f - main - tcp: remove unused tcp_sack_output_debug() function List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rscheff X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: dfe30e41967f9b5112c42ca20ec2c366db74cef9 Auto-Submitted: auto-generated The branch main has been updated by rscheff: URL: https://cgit.FreeBSD.org/src/commit/?id=dfe30e41967f9b5112c42ca20ec2c366db74cef9 commit dfe30e41967f9b5112c42ca20ec2c366db74cef9 Author: Richard Scheffenegger AuthorDate: 2024-01-19 13:48:11 +0000 Commit: Richard Scheffenegger CommitDate: 2024-01-19 13:48:32 +0000 tcp: remove unused tcp_sack_output_debug() function This debugging code has been lingering for years with no known use. No functional change. Reviewed by: tuexen, #transport Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D43511 --- sys/netinet/tcp_sack.c | 26 -------------------------- 1 file changed, 26 deletions(-) diff --git a/sys/netinet/tcp_sack.c b/sys/netinet/tcp_sack.c index 48efe855f689..f9ca83850c09 100644 --- a/sys/netinet/tcp_sack.c +++ b/sys/netinet/tcp_sack.c @@ -994,32 +994,6 @@ tcp_sack_partialack(struct tcpcb *tp, struct tcphdr *th) (void) tcp_output(tp); } -#if 0 -/* - * Debug version of tcp_sack_output() that walks the scoreboard. Used for - * now to sanity check the hint. - */ -static struct sackhole * -tcp_sack_output_debug(struct tcpcb *tp, int *sack_bytes_rexmt) -{ - struct sackhole *p; - - INP_WLOCK_ASSERT(tptoinpcb(tp)); - *sack_bytes_rexmt = 0; - TAILQ_FOREACH(p, &tp->snd_holes, scblink) { - if (SEQ_LT(p->rxmit, p->end)) { - if (SEQ_LT(p->rxmit, tp->snd_una)) {/* old SACK hole */ - continue; - } - *sack_bytes_rexmt += (p->rxmit - p->start); - break; - } - *sack_bytes_rexmt += (SEQ_MIN(p->rxmit, p->end) - p->start); - } - return (p); -} -#endif - /* * Returns the next hole to retransmit and the number of retransmitted bytes * from the scoreboard. We store both the next hole and the number of