From owner-svn-ports-head@freebsd.org Thu Aug 6 11:50:04 2020 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C2C7C37DECC; Thu, 6 Aug 2020 11:50:04 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: from mail-ej1-f65.google.com (mail-ej1-f65.google.com [209.85.218.65]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BMmy33Ylgz42G8; Thu, 6 Aug 2020 11:50:03 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: by mail-ej1-f65.google.com with SMTP id f24so29480900ejx.6; Thu, 06 Aug 2020 04:50:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=PgxMPU7uKnbMuom9bPfCa4E2nk6JKvMKwO01Ixr5nUA=; b=gWUDU4U7n8rbtkHTj6okwQ+4tLAQVwwlzwl+ZLb5UUk4Zmh5y6OtxXUoZ4EJBhoY5H EqoDHa0S+L4mlNRJQ5wT0UkdjX68eCrWop89Cxua5l1Lwpaiv6drNqQxFzV+hMRmLlQP UVgYaxujJOR6knELXbt7ZVucqcCmd+hfMv6bHlutEDd6z2GN//I2jlTZJtPI7K8yYOrV nSOsudxjsfJgDq9O9qvK9lmup+MWChcZAy00iccrwzkaKXhxHSdV/gln6qWYqaXKrmn9 qq24n351Mi5VJ5bA+xTFF3Qrl9C5e0rnQqWWvDYws56t3OerYvrPmS01hXoCguLyPbSZ HmgQ== X-Gm-Message-State: AOAM5324zm3OQL+4yECJVP+7m7dEQZHX3A2CIeJZ4qoBzePTmNt5HIlR 5W3u8NRddBBw1EQqWO4SBSTw4bzGawM= X-Google-Smtp-Source: ABdhPJx+jvHSOWQ1pNUhqKrjqY8TtyanXk9Rg49gzol7FhIpCR8TWQGmr6hJgybMm/bl6yhSZzlXDg== X-Received: by 2002:a17:906:6a5b:: with SMTP id n27mr3754881ejs.221.1596714601629; Thu, 06 Aug 2020 04:50:01 -0700 (PDT) Received: from ?IPv6:2a02:8109:98c0:1bc0:5e5f:67ff:fef4:ffd8? ([2a02:8109:98c0:1bc0:5e5f:67ff:fef4:ffd8]) by smtp.gmail.com with ESMTPSA id e6sm3649806ejd.14.2020.08.06.04.50.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2020 04:50:00 -0700 (PDT) Subject: Re: svn commit: r544245 - head/x11/sakura To: =?UTF-8?Q?Danilo_Eg=c3=aaa_Gondolfo?= , Alexey Dokuchaev Cc: ports-committers , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <202008052155.075LtmtD072730@repo.freebsd.org> <20200806033440.GA53929@FreeBSD.org> From: Mateusz Piotrowski <0mp@FreeBSD.org> Message-ID: Date: Thu, 6 Aug 2020 13:50:09 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 4BMmy33Ylgz42G8 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of mpp302@gmail.com designates 209.85.218.65 as permitted sender) smtp.mailfrom=mpp302@gmail.com X-Spamd-Result: default: False [-0.69 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-0.64)[-0.640]; RWL_MAILSPIKE_GOOD(0.00)[209.85.218.65:from]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_MEDIUM(-0.06)[-0.058]; NEURAL_SPAM_SHORT(0.01)[0.005]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.218.65:from]; FORGED_SENDER(0.30)[0mp@FreeBSD.org,mpp302@gmail.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[0mp@FreeBSD.org,mpp302@gmail.com]; FREEMAIL_ENVFROM(0.00)[gmail.com] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Aug 2020 11:50:04 -0000 On 8/6/20 12:46 PM, Danilo Egêa Gondolfo wrote: > On Thu, Aug 6, 2020 at 4:34 AM Alexey Dokuchaev wrote: > >> On Wed, Aug 05, 2020 at 09:55:48PM +0000, Danilo Egea Gondolfo wrote: >>> New Revision: 544245 >>> URL: https://svnweb.freebsd.org/changeset/ports/544245 >>> >>> @@ -14,9 +14,10 @@ LICENSE= GPLv2 >>> LIB_DEPENDS= libgnutls.so:security/gnutls \ >>> libpcre2-8.so:devel/pcre2 >>> >>> +USES= cmake gnome pkgconfig gettext perl5 tar:bz2 xorg >>> + >>> OPTIONS_DEFINE= DOCS >>> >>> -USES= cmake gnome pkgconfig gettext perl5 xorg >>> USE_GNOME= cairo gdkpixbuf2 vte3 >> I'd argue that USES was placed better before this change (right next to >> USE_FOO knobs). It should've been left where it was and OPTIONS_DEFINE >> moved downwards instead. >> >> ./danfe >> > Just tried to make portlint happy on this one ("USES should appear > earlier"). Please try portfmt and portclippy from ports-mgmt/portfmt. They are much better for order fixes and simple style fixes than portlint in most cases. Cheers, Mateusz Piotrowski